Merge tag 'ib-mfd-extcon-3.16' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd into HEAD

Immutable branch between MFD and Extcon due for v3.16 merge-window.

2 files changed, 129 insertions, 49 deletions

diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index be56e8ac95e6..aebde489c291 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -28,13 +28,13 @@ config EXTCON_ADC_JACK
           Say Y here to enable extcon device driver based on ADC values.
 
 config EXTCON_MAX14577
-        tristate "MAX14577 EXTCON Support"
+        tristate "MAX14577/77836 EXTCON Support"
         depends on MFD_MAX14577
         select IRQ_DOMAIN
         select REGMAP_I2C
         help
           If you say yes here you get support for the MUIC device of
-          Maxim MAX14577 PMIC. The MAX14577 MUIC is a USB port accessory
+          Maxim MAX14577/77836. The MAX14577/77836 MUIC is a USB port accessory
           detector and switch.
 
 config EXTCON_MAX77693
diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
index 3846941801b8..c76734a70171 100644
--- a/drivers/extcon/extcon-max14577.c
+++ b/drivers/extcon/extcon-max14577.c
@@ -1,8 +1,9 @@
 /*
- * extcon-max14577.c - MAX14577 extcon driver to support MAX14577 MUIC
+ * extcon-max14577.c - MAX14577/77836 extcon driver to support MUIC
  *
- * Copyright (C) 2013 Samsung Electrnoics
+ * Copyright (C) 2013,2014 Samsung Electrnoics
  * Chanwoo Choi <cw00.choi@samsung.com>
+ * Krzysztof Kozlowski <k.kozlowski@samsung.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -24,7 +25,6 @@
 #include <linux/mfd/max14577-private.h>
 #include <linux/extcon.h>
 
-#define DEV_NAME                        "max14577-muic"
 #define DELAY_MS_DEFAULT                17000           /* unit: millisecond */
 
 enum max14577_muic_adc_debounce_time {
@@ -40,6 +40,42 @@ enum max14577_muic_status {
         MAX14577_MUIC_STATUS_END,
 };
 
+/**
+ * struct max14577_muic_irq
+ * @irq: the index of irq list of MUIC device.
+ * @name: the name of irq.
+ * @virq: the virtual irq to use irq domain
+ */
+struct max14577_muic_irq {
+        unsigned int irq;
+        const char *name;
+        unsigned int virq;
+};
+
+static struct max14577_muic_irq max14577_muic_irqs[] = {
+        { MAX14577_IRQ_INT1_ADC,        "muic-ADC" },
+        { MAX14577_IRQ_INT1_ADCLOW,     "muic-ADCLOW" },
+        { MAX14577_IRQ_INT1_ADCERR,     "muic-ADCError" },
+        { MAX14577_IRQ_INT2_CHGTYP,     "muic-CHGTYP" },
+        { MAX14577_IRQ_INT2_CHGDETRUN,  "muic-CHGDETRUN" },
+        { MAX14577_IRQ_INT2_DCDTMR,     "muic-DCDTMR" },
+        { MAX14577_IRQ_INT2_DBCHG,      "muic-DBCHG" },
+        { MAX14577_IRQ_INT2_VBVOLT,     "muic-VBVOLT" },
+};
+
+static struct max14577_muic_irq max77836_muic_irqs[] = {
+        { MAX14577_IRQ_INT1_ADC,        "muic-ADC" },
+        { MAX14577_IRQ_INT1_ADCLOW,     "muic-ADCLOW" },
+        { MAX14577_IRQ_INT1_ADCERR,     "muic-ADCError" },
+        { MAX77836_IRQ_INT1_ADC1K,      "muic-ADC1K" },
+        { MAX14577_IRQ_INT2_CHGTYP,     "muic-CHGTYP" },
+        { MAX14577_IRQ_INT2_CHGDETRUN,  "muic-CHGDETRUN" },
+        { MAX14577_IRQ_INT2_DCDTMR,     "muic-DCDTMR" },
+        { MAX14577_IRQ_INT2_DBCHG,      "muic-DBCHG" },
+        { MAX14577_IRQ_INT2_VBVOLT,     "muic-VBVOLT" },
+        { MAX77836_IRQ_INT2_VIDRM,      "muic-VIDRM" },
+};
+
 struct max14577_muic_info {
         struct device *dev;
         struct max14577 *max14577;
@@ -48,6 +84,8 @@ struct max14577_muic_info {
         int prev_chg_type;
         u8 status[MAX14577_MUIC_STATUS_END];
 
+        struct max14577_muic_irq *muic_irqs;
+        unsigned int muic_irqs_num;
         bool irq_adc;
         bool irq_chg;
         struct work_struct irq_work;
@@ -74,29 +112,6 @@ enum max14577_muic_cable_group {
         MAX14577_CABLE_GROUP_CHG,
 };
 
-/**
- * struct max14577_muic_irq
- * @irq: the index of irq list of MUIC device.
- * @name: the name of irq.
- * @virq: the virtual irq to use irq domain
- */
-struct max14577_muic_irq {
-        unsigned int irq;
-        const char *name;
-        unsigned int virq;
-};
-
-static struct max14577_muic_irq muic_irqs[] = {
-        { MAX14577_IRQ_INT1_ADC,        "muic-ADC" },
-        { MAX14577_IRQ_INT1_ADCLOW,     "muic-ADCLOW" },
-        { MAX14577_IRQ_INT1_ADCERR,     "muic-ADCError" },
-        { MAX14577_IRQ_INT2_CHGTYP,     "muic-CHGTYP" },
-        { MAX14577_IRQ_INT2_CHGDETRUN,  "muic-CHGDETRUN" },
-        { MAX14577_IRQ_INT2_DCDTMR,     "muic-DCDTMR" },
-        { MAX14577_IRQ_INT2_DBCHG,      "muic-DBCHG" },
-        { MAX14577_IRQ_INT2_VBVOLT,     "muic-VBVOLT" },
-};
-
 /* Define supported accessory type */
 enum max14577_muic_acc_type {
         MAX14577_MUIC_ADC_GROUND = 0x0,
@@ -528,21 +543,12 @@ static void max14577_muic_irq_work(struct work_struct *work)
         return;
 }
 
-static irqreturn_t max14577_muic_irq_handler(int irq, void *data)
+/*
+ * Sets irq_adc or irq_chg in max14577_muic_info and returns 1.
+ * Returns 0 if irq_type does not match registered IRQ for this device type.
+ */
+static int max14577_parse_irq(struct max14577_muic_info *info, int irq_type)
 {
-        struct max14577_muic_info *info = data;
-        int i, irq_type = -1;
-
-        /*
-         * We may be called multiple times for different nested IRQ-s.
-         * Including changes in INT1_ADC and INT2_CGHTYP at once.
-         * However we only need to know whether it was ADC, charger
-         * or both interrupts so decode IRQ and turn on proper flags.
-         */
-        for (i = 0; i < ARRAY_SIZE(muic_irqs); i++)
-                if (irq == muic_irqs[i].virq)
-                        irq_type = muic_irqs[i].irq;
-
         switch (irq_type) {
         case MAX14577_IRQ_INT1_ADC:
         case MAX14577_IRQ_INT1_ADCLOW:
@@ -550,7 +556,7 @@ static irqreturn_t max14577_muic_irq_handler(int irq, void *data)
                 /* Handle all of accessory except for
                    type of charger accessory */
                 info->irq_adc = true;
-                break;
+                return 1;
         case MAX14577_IRQ_INT2_CHGTYP:
         case MAX14577_IRQ_INT2_CHGDETRUN:
         case MAX14577_IRQ_INT2_DCDTMR:
@@ -558,8 +564,62 @@ static irqreturn_t max14577_muic_irq_handler(int irq, void *data)
         case MAX14577_IRQ_INT2_VBVOLT:
                 /* Handle charger accessory */
                 info->irq_chg = true;
+                return 1;
+        default:
+                return 0;
+        }
+}
+
+/*
+ * Sets irq_adc or irq_chg in max14577_muic_info and returns 1.
+ * Returns 0 if irq_type does not match registered IRQ for this device type.
+ */
+static int max77836_parse_irq(struct max14577_muic_info *info, int irq_type)
+{
+        /* First check common max14577 interrupts */
+        if (max14577_parse_irq(info, irq_type))
+                return 1;
+
+        switch (irq_type) {
+        case MAX77836_IRQ_INT1_ADC1K:
+                info->irq_adc = true;
+                return 1;
+        case MAX77836_IRQ_INT2_VIDRM:
+                /* Handle charger accessory */
+                info->irq_chg = true;
+                return 1;
+        default:
+                return 0;
+        }
+}
+
+static irqreturn_t max14577_muic_irq_handler(int irq, void *data)
+{
+        struct max14577_muic_info *info = data;
+        int i, irq_type = -1;
+        bool irq_parsed;
+
+        /*
+         * We may be called multiple times for different nested IRQ-s.
+         * Including changes in INT1_ADC and INT2_CGHTYP at once.
+         * However we only need to know whether it was ADC, charger
+         * or both interrupts so decode IRQ and turn on proper flags.
+         */
+        for (i = 0; i < info->muic_irqs_num; i++)
+                if (irq == info->muic_irqs[i].virq)
+                        irq_type = info->muic_irqs[i].irq;
+
+        switch (info->max14577->dev_type) {
+        case MAXIM_DEVICE_TYPE_MAX77836:
+                irq_parsed = max77836_parse_irq(info, irq_type);
                 break;
+        case MAXIM_DEVICE_TYPE_MAX14577:
         default:
+                irq_parsed = max14577_parse_irq(info, irq_type);
+                break;
+        }
+
+        if (!irq_parsed) {
                 dev_err(info->dev, "muic interrupt: irq %d occurred, skipped\n",
                                 irq_type);
                 return IRQ_HANDLED;
@@ -644,9 +704,20 @@ static int max14577_muic_probe(struct platform_device *pdev)
 
         INIT_WORK(&info->irq_work, max14577_muic_irq_work);
 
+        switch (max14577->dev_type) {
+        case MAXIM_DEVICE_TYPE_MAX77836:
+                info->muic_irqs = max77836_muic_irqs;
+                info->muic_irqs_num = ARRAY_SIZE(max77836_muic_irqs);
+                break;
+        case MAXIM_DEVICE_TYPE_MAX14577:
+        default:
+                info->muic_irqs = max14577_muic_irqs;
+                info->muic_irqs_num = ARRAY_SIZE(max14577_muic_irqs);
+        }
+
         /* Support irq domain for max14577 MUIC device */
-        for (i = 0; i < ARRAY_SIZE(muic_irqs); i++) {
-                struct max14577_muic_irq *muic_irq = &muic_irqs[i];
+        for (i = 0; i < info->muic_irqs_num; i++) {
+                struct max14577_muic_irq *muic_irq = &info->muic_irqs[i];
                 unsigned int virq = 0;
 
                 virq = regmap_irq_get_virq(max14577->irq_data, muic_irq->irq);
@@ -673,7 +744,8 @@ static int max14577_muic_probe(struct platform_device *pdev)
                 dev_err(&pdev->dev, "failed to allocate memory for extcon\n");
                 return -ENOMEM;
         }
-        info->edev->name = DEV_NAME;
+
+        info->edev->name = dev_name(&pdev->dev);
         info->edev->supported_cable = max14577_extcon_cable;
         ret = extcon_dev_register(info->edev);
         if (ret) {
@@ -735,18 +807,26 @@ static int max14577_muic_remove(struct platform_device *pdev)
         return 0;
 }
 
+static const struct platform_device_id max14577_muic_id[] = {
+        { "max14577-muic", MAXIM_DEVICE_TYPE_MAX14577, },
+        { "max77836-muic", MAXIM_DEVICE_TYPE_MAX77836, },
+        { }
+};
+MODULE_DEVICE_TABLE(platform, max14577_muic_id);
+
 static struct platform_driver max14577_muic_driver = {
         .driver         = {
-                .name   = DEV_NAME,
+                .name   = "max14577-muic",
                 .owner  = THIS_MODULE,
         },
         .probe          = max14577_muic_probe,
         .remove         = max14577_muic_remove,
+        .id_table       = max14577_muic_id,
 };
 
 module_platform_driver(max14577_muic_driver);
 
-MODULE_DESCRIPTION("MAXIM 14577 Extcon driver");
-MODULE_AUTHOR("Chanwoo Choi <cw00.choi@samsung.com>");
+MODULE_DESCRIPTION("Maxim 14577/77836 Extcon driver");
+MODULE_AUTHOR("Chanwoo Choi <cw00.choi@samsung.com>, Krzysztof Kozlowski <k.kozlowski@samsung.com>");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:extcon-max14577");