diff options
author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-04-16 14:11:08 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-05-28 18:13:45 -0400 |
commit | ad4d6e2311487299beaf36bd890c96569c691482 (patch) | |
tree | 0082a9f14f12d48e11cd98faf18e6570e27852b0 /drivers/edac | |
parent | 705213580b82090c1f4277d7d8fbee898d53895e (diff) |
mpc85xx_edac: convert driver to use the new edac ABI
The legacy edac ABI is going to be removed. Port the driver to use
and benefit from the new API functionality.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Shaohui Xie <Shaohui.Xie@freescale.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/edac')
-rw-r--r-- | drivers/edac/mpc85xx_edac.c | 22 |
1 files changed, 17 insertions, 5 deletions
diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c index c1d9e158972c..a15141025a94 100644 --- a/drivers/edac/mpc85xx_edac.c +++ b/drivers/edac/mpc85xx_edac.c | |||
@@ -854,12 +854,16 @@ static void mpc85xx_mc_check(struct mem_ctl_info *mci) | |||
854 | mpc85xx_mc_printk(mci, KERN_ERR, "PFN out of range!\n"); | 854 | mpc85xx_mc_printk(mci, KERN_ERR, "PFN out of range!\n"); |
855 | 855 | ||
856 | if (err_detect & DDR_EDE_SBE) | 856 | if (err_detect & DDR_EDE_SBE) |
857 | edac_mc_handle_ce(mci, pfn, err_addr & ~PAGE_MASK, | 857 | edac_mc_handle_error(HW_EVENT_ERR_CORRECTED, mci, |
858 | syndrome, row_index, 0, mci->ctl_name); | 858 | pfn, err_addr & ~PAGE_MASK, syndrome, |
859 | row_index, 0, -1, | ||
860 | mci->ctl_name, "", NULL); | ||
859 | 861 | ||
860 | if (err_detect & DDR_EDE_MBE) | 862 | if (err_detect & DDR_EDE_MBE) |
861 | edac_mc_handle_ue(mci, pfn, err_addr & ~PAGE_MASK, | 863 | edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci, |
862 | row_index, mci->ctl_name); | 864 | pfn, err_addr & ~PAGE_MASK, syndrome, |
865 | row_index, 0, -1, | ||
866 | mci->ctl_name, "", NULL); | ||
863 | 867 | ||
864 | out_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT, err_detect); | 868 | out_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT, err_detect); |
865 | } | 869 | } |
@@ -961,6 +965,7 @@ static void __devinit mpc85xx_init_csrows(struct mem_ctl_info *mci) | |||
961 | static int __devinit mpc85xx_mc_err_probe(struct platform_device *op) | 965 | static int __devinit mpc85xx_mc_err_probe(struct platform_device *op) |
962 | { | 966 | { |
963 | struct mem_ctl_info *mci; | 967 | struct mem_ctl_info *mci; |
968 | struct edac_mc_layer layers[2]; | ||
964 | struct mpc85xx_mc_pdata *pdata; | 969 | struct mpc85xx_mc_pdata *pdata; |
965 | struct resource r; | 970 | struct resource r; |
966 | u32 sdram_ctl; | 971 | u32 sdram_ctl; |
@@ -969,7 +974,14 @@ static int __devinit mpc85xx_mc_err_probe(struct platform_device *op) | |||
969 | if (!devres_open_group(&op->dev, mpc85xx_mc_err_probe, GFP_KERNEL)) | 974 | if (!devres_open_group(&op->dev, mpc85xx_mc_err_probe, GFP_KERNEL)) |
970 | return -ENOMEM; | 975 | return -ENOMEM; |
971 | 976 | ||
972 | mci = edac_mc_alloc(sizeof(*pdata), 4, 1, edac_mc_idx); | 977 | layers[0].type = EDAC_MC_LAYER_CHIP_SELECT; |
978 | layers[0].size = 4; | ||
979 | layers[0].is_virt_csrow = true; | ||
980 | layers[1].type = EDAC_MC_LAYER_CHANNEL; | ||
981 | layers[1].size = 1; | ||
982 | layers[1].is_virt_csrow = false; | ||
983 | mci = new_edac_mc_alloc(edac_mc_idx, ARRAY_SIZE(layers), layers, | ||
984 | sizeof(*pdata)); | ||
973 | if (!mci) { | 985 | if (!mci) { |
974 | devres_release_group(&op->dev, mpc85xx_mc_err_probe); | 986 | devres_release_group(&op->dev, mpc85xx_mc_err_probe); |
975 | return -ENOMEM; | 987 | return -ENOMEM; |