diff options
author | Kevin Winchester <kjwinchester@gmail.com> | 2011-12-20 19:52:22 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2011-12-21 03:25:09 -0500 |
commit | 141168c36cdee3ff23d9c7700b0edc47cb65479f (patch) | |
tree | 9b307514252062a7bd0cfa593e56e1843975e1c2 /drivers/edac | |
parent | b49d7d877ff96428c8cd2076b33ba72bf85ceaba (diff) |
x86: Simplify code by removing a !SMP #ifdefs from 'struct cpuinfo_x86'
Several fields in struct cpuinfo_x86 were not defined for the
!SMP case, likely to save space. However, those fields still
have some meaning for UP, and keeping them allows some #ifdef
removal from other files. The additional size of the UP kernel
from this change is not significant enough to worry about
keeping up the distinction:
text data bss dec hex filename
4737168 506459 972040 6215667 5ed7f3 vmlinux.o.before
4737444 506459 972040 6215943 5ed907 vmlinux.o.after
for a difference of 276 bytes for an example UP config.
If someone wants those 276 bytes back badly then it should
be implemented in a cleaner way.
Signed-off-by: Kevin Winchester <kjwinchester@gmail.com>
Cc: Steffen Persvold <sp@numascale.com>
Link: http://lkml.kernel.org/r/1324428742-12498-1-git-send-email-kjwinchester@gmail.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'drivers/edac')
-rw-r--r-- | drivers/edac/sb_edac.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c index 7a402bfbee7d..88df48956c1b 100644 --- a/drivers/edac/sb_edac.c +++ b/drivers/edac/sb_edac.c | |||
@@ -1609,11 +1609,9 @@ static int sbridge_mce_check_error(struct notifier_block *nb, unsigned long val, | |||
1609 | mce->cpuvendor, mce->cpuid, mce->time, | 1609 | mce->cpuvendor, mce->cpuid, mce->time, |
1610 | mce->socketid, mce->apicid); | 1610 | mce->socketid, mce->apicid); |
1611 | 1611 | ||
1612 | #ifdef CONFIG_SMP | ||
1613 | /* Only handle if it is the right mc controller */ | 1612 | /* Only handle if it is the right mc controller */ |
1614 | if (cpu_data(mce->cpu).phys_proc_id != pvt->sbridge_dev->mc) | 1613 | if (cpu_data(mce->cpu).phys_proc_id != pvt->sbridge_dev->mc) |
1615 | return NOTIFY_DONE; | 1614 | return NOTIFY_DONE; |
1616 | #endif | ||
1617 | 1615 | ||
1618 | smp_rmb(); | 1616 | smp_rmb(); |
1619 | if ((pvt->mce_out + 1) % MCE_LOG_LEN == pvt->mce_in) { | 1617 | if ((pvt->mce_out + 1) % MCE_LOG_LEN == pvt->mce_in) { |