diff options
author | Doug Thompson <norsk5@xmission.com> | 2006-06-30 04:56:08 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-30 14:25:39 -0400 |
commit | 2d7bbb91c8df26c60d223205a087507430024177 (patch) | |
tree | 98d51dac1c1e53b2b6a887c31abc2260160eb50d /drivers/edac/r82600_edac.c | |
parent | 37f04581abac20444e5b7106c1e1f28bec5b989c (diff) |
[PATCH] EDAC: mc numbers refactor 1-of-2
Remove add_mc_to_global_list(). In next patch, this function will be
reimplemented with different semantics.
1 Reimplement add_mc_to_global_list() with semantics that allow the caller to
determine the ID number for a mem_ctl_info structure. Then modify
edac_mc_add_mc() so that the caller specifies the ID number for the new
mem_ctl_info structure. Platform-specific code should be able to assign the
ID numbers in a platform-specific manner. For instance, on Opteron it makes
sense to have the ID of the mem_ctl_info structure match the ID of the node
that the memory controller belongs to.
2 Modify callers of edac_mc_add_mc() so they use the new semantics.
Signed-off-by: Doug Thompson <norsk5@xmission.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/edac/r82600_edac.c')
-rw-r--r-- | drivers/edac/r82600_edac.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/edac/r82600_edac.c b/drivers/edac/r82600_edac.c index d04769aade5d..eb3aa615dc57 100644 --- a/drivers/edac/r82600_edac.c +++ b/drivers/edac/r82600_edac.c | |||
@@ -304,7 +304,10 @@ static int r82600_probe1(struct pci_dev *pdev, int dev_idx) | |||
304 | 304 | ||
305 | r82600_get_error_info(mci, &discard); /* clear counters */ | 305 | r82600_get_error_info(mci, &discard); /* clear counters */ |
306 | 306 | ||
307 | if (edac_mc_add_mc(mci)) { | 307 | /* Here we assume that we will never see multiple instances of this |
308 | * type of memory controller. The ID is therefore hardcoded to 0. | ||
309 | */ | ||
310 | if (edac_mc_add_mc(mci,0)) { | ||
308 | debugf3("%s(): failed edac_mc_add_mc()\n", __func__); | 311 | debugf3("%s(): failed edac_mc_add_mc()\n", __func__); |
309 | goto fail; | 312 | goto fail; |
310 | } | 313 | } |