diff options
author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-04-29 10:59:14 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-06-11 12:23:47 -0400 |
commit | dd23cd6eb1f59ba722a6e6aa228adff7c01404de (patch) | |
tree | 32c45fb296293af1309f926b8c109eef329f4f22 /drivers/edac/i82875p_edac.c | |
parent | 2639c3ee298401881cc560c5e3987f8b222b9f7c (diff) |
edac: Don't add __func__ or __FILE__ for debugf[0-9] msgs
The debug macro already adds that. Most of the work here was
made by this small script:
$f .=$_ while (<>);
$f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*": /\1"/g;
$f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*/\1/g;
$f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*"MC: /\1"/g;
$f =~ s/(debugf[0-9]\s*\(\")\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+)__func__\s*\,\s*/\1\2/g;
$f =~ s/(debugf[0-9]\s*\(\")\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+),\s*__func__\s*\)/\1\2)/g;
$f =~ s/(debugf[0-9]\s*\(\"MC\:\s*)\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+)__func__\s*\,\s*/\1\2/g;
$f =~ s/(debugf[0-9]\s*\(\"MC\:\s*)\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+),\s*__func__\s*\)/\1\2)/g;
$f =~ s/\"MC\: \\n\"/"MC:\\n"/g;
print $f;
After running the script, manual cleanups were done to fix it the remaining
places.
While here, removed the __LINE__ on most places, as it doesn't actually give
useful info on most places.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/edac/i82875p_edac.c')
-rw-r--r-- | drivers/edac/i82875p_edac.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/drivers/edac/i82875p_edac.c b/drivers/edac/i82875p_edac.c index 97fd6b769c84..4ded498047f7 100644 --- a/drivers/edac/i82875p_edac.c +++ b/drivers/edac/i82875p_edac.c | |||
@@ -263,7 +263,7 @@ static void i82875p_check(struct mem_ctl_info *mci) | |||
263 | { | 263 | { |
264 | struct i82875p_error_info info; | 264 | struct i82875p_error_info info; |
265 | 265 | ||
266 | debugf1("MC%d: %s()\n", mci->mc_idx, __func__); | 266 | debugf1("MC%d\n", mci->mc_idx); |
267 | i82875p_get_error_info(mci, &info); | 267 | i82875p_get_error_info(mci, &info); |
268 | i82875p_process_error_info(mci, &info, 1); | 268 | i82875p_process_error_info(mci, &info, 1); |
269 | } | 269 | } |
@@ -371,7 +371,7 @@ static void i82875p_init_csrows(struct mem_ctl_info *mci, | |||
371 | 371 | ||
372 | value = readb(ovrfl_window + I82875P_DRB + index); | 372 | value = readb(ovrfl_window + I82875P_DRB + index); |
373 | cumul_size = value << (I82875P_DRB_SHIFT - PAGE_SHIFT); | 373 | cumul_size = value << (I82875P_DRB_SHIFT - PAGE_SHIFT); |
374 | debugf3("%s(): (%d) cumul_size 0x%x\n", __func__, index, | 374 | debugf3("(%d) cumul_size 0x%x\n", index, |
375 | cumul_size); | 375 | cumul_size); |
376 | if (cumul_size == last_cumul_size) | 376 | if (cumul_size == last_cumul_size) |
377 | continue; /* not populated */ | 377 | continue; /* not populated */ |
@@ -405,7 +405,7 @@ static int i82875p_probe1(struct pci_dev *pdev, int dev_idx) | |||
405 | u32 nr_chans; | 405 | u32 nr_chans; |
406 | struct i82875p_error_info discard; | 406 | struct i82875p_error_info discard; |
407 | 407 | ||
408 | debugf0("%s()\n", __func__); | 408 | debugf0("\n"); |
409 | 409 | ||
410 | ovrfl_pdev = pci_get_device(PCI_VEND_DEV(INTEL, 82875_6), NULL); | 410 | ovrfl_pdev = pci_get_device(PCI_VEND_DEV(INTEL, 82875_6), NULL); |
411 | 411 | ||
@@ -426,7 +426,7 @@ static int i82875p_probe1(struct pci_dev *pdev, int dev_idx) | |||
426 | goto fail0; | 426 | goto fail0; |
427 | } | 427 | } |
428 | 428 | ||
429 | debugf3("%s(): init mci\n", __func__); | 429 | debugf3("init mci\n"); |
430 | mci->pdev = &pdev->dev; | 430 | mci->pdev = &pdev->dev; |
431 | mci->mtype_cap = MEM_FLAG_DDR; | 431 | mci->mtype_cap = MEM_FLAG_DDR; |
432 | mci->edac_ctl_cap = EDAC_FLAG_NONE | EDAC_FLAG_SECDED; | 432 | mci->edac_ctl_cap = EDAC_FLAG_NONE | EDAC_FLAG_SECDED; |
@@ -437,7 +437,7 @@ static int i82875p_probe1(struct pci_dev *pdev, int dev_idx) | |||
437 | mci->dev_name = pci_name(pdev); | 437 | mci->dev_name = pci_name(pdev); |
438 | mci->edac_check = i82875p_check; | 438 | mci->edac_check = i82875p_check; |
439 | mci->ctl_page_to_phys = NULL; | 439 | mci->ctl_page_to_phys = NULL; |
440 | debugf3("%s(): init pvt\n", __func__); | 440 | debugf3("init pvt\n"); |
441 | pvt = (struct i82875p_pvt *)mci->pvt_info; | 441 | pvt = (struct i82875p_pvt *)mci->pvt_info; |
442 | pvt->ovrfl_pdev = ovrfl_pdev; | 442 | pvt->ovrfl_pdev = ovrfl_pdev; |
443 | pvt->ovrfl_window = ovrfl_window; | 443 | pvt->ovrfl_window = ovrfl_window; |
@@ -448,7 +448,7 @@ static int i82875p_probe1(struct pci_dev *pdev, int dev_idx) | |||
448 | * type of memory controller. The ID is therefore hardcoded to 0. | 448 | * type of memory controller. The ID is therefore hardcoded to 0. |
449 | */ | 449 | */ |
450 | if (edac_mc_add_mc(mci)) { | 450 | if (edac_mc_add_mc(mci)) { |
451 | debugf3("%s(): failed edac_mc_add_mc()\n", __func__); | 451 | debugf3("failed edac_mc_add_mc()\n"); |
452 | goto fail1; | 452 | goto fail1; |
453 | } | 453 | } |
454 | 454 | ||
@@ -464,7 +464,7 @@ static int i82875p_probe1(struct pci_dev *pdev, int dev_idx) | |||
464 | } | 464 | } |
465 | 465 | ||
466 | /* get this far and it's successful */ | 466 | /* get this far and it's successful */ |
467 | debugf3("%s(): success\n", __func__); | 467 | debugf3("success\n"); |
468 | return 0; | 468 | return 0; |
469 | 469 | ||
470 | fail1: | 470 | fail1: |
@@ -485,7 +485,7 @@ static int __devinit i82875p_init_one(struct pci_dev *pdev, | |||
485 | { | 485 | { |
486 | int rc; | 486 | int rc; |
487 | 487 | ||
488 | debugf0("%s()\n", __func__); | 488 | debugf0("\n"); |
489 | i82875p_printk(KERN_INFO, "i82875p init one\n"); | 489 | i82875p_printk(KERN_INFO, "i82875p init one\n"); |
490 | 490 | ||
491 | if (pci_enable_device(pdev) < 0) | 491 | if (pci_enable_device(pdev) < 0) |
@@ -504,7 +504,7 @@ static void __devexit i82875p_remove_one(struct pci_dev *pdev) | |||
504 | struct mem_ctl_info *mci; | 504 | struct mem_ctl_info *mci; |
505 | struct i82875p_pvt *pvt = NULL; | 505 | struct i82875p_pvt *pvt = NULL; |
506 | 506 | ||
507 | debugf0("%s()\n", __func__); | 507 | debugf0("\n"); |
508 | 508 | ||
509 | if (i82875p_pci) | 509 | if (i82875p_pci) |
510 | edac_pci_release_generic_ctl(i82875p_pci); | 510 | edac_pci_release_generic_ctl(i82875p_pci); |
@@ -550,7 +550,7 @@ static int __init i82875p_init(void) | |||
550 | { | 550 | { |
551 | int pci_rc; | 551 | int pci_rc; |
552 | 552 | ||
553 | debugf3("%s()\n", __func__); | 553 | debugf3("\n"); |
554 | 554 | ||
555 | /* Ensure that the OPSTATE is set correctly for POLL or NMI */ | 555 | /* Ensure that the OPSTATE is set correctly for POLL or NMI */ |
556 | opstate_init(); | 556 | opstate_init(); |
@@ -593,7 +593,7 @@ fail0: | |||
593 | 593 | ||
594 | static void __exit i82875p_exit(void) | 594 | static void __exit i82875p_exit(void) |
595 | { | 595 | { |
596 | debugf3("%s()\n", __func__); | 596 | debugf3("\n"); |
597 | 597 | ||
598 | i82875p_remove_one(mci_pdev); | 598 | i82875p_remove_one(mci_pdev); |
599 | pci_dev_put(mci_pdev); | 599 | pci_dev_put(mci_pdev); |