diff options
author | Joe Perches <joe@perches.com> | 2012-04-29 16:08:39 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-06-11 12:23:49 -0400 |
commit | 956b9ba156dbfdb9cede2b2927ddf8be2233b3a7 (patch) | |
tree | 6ece471eee029a1ca83ce649f7dc23020ebef182 /drivers/edac/i82860_edac.c | |
parent | 7e881856eee8b889b76cd1d8e04ce2fc79b72099 (diff) |
edac: Convert debugfX to edac_dbg(X,
Use a more common debugging style.
Remove __FILE__ uses, add missing newlines,
coalesce formats and align arguments.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/edac/i82860_edac.c')
-rw-r--r-- | drivers/edac/i82860_edac.c | 23 |
1 files changed, 11 insertions, 12 deletions
diff --git a/drivers/edac/i82860_edac.c b/drivers/edac/i82860_edac.c index d4ec21db22ba..832e7dd2c5fa 100644 --- a/drivers/edac/i82860_edac.c +++ b/drivers/edac/i82860_edac.c | |||
@@ -136,7 +136,7 @@ static void i82860_check(struct mem_ctl_info *mci) | |||
136 | { | 136 | { |
137 | struct i82860_error_info info; | 137 | struct i82860_error_info info; |
138 | 138 | ||
139 | debugf1("MC%d\n", mci->mc_idx); | 139 | edac_dbg(1, "MC%d\n", mci->mc_idx); |
140 | i82860_get_error_info(mci, &info); | 140 | i82860_get_error_info(mci, &info); |
141 | i82860_process_error_info(mci, &info, 1); | 141 | i82860_process_error_info(mci, &info, 1); |
142 | } | 142 | } |
@@ -167,8 +167,7 @@ static void i82860_init_csrows(struct mem_ctl_info *mci, struct pci_dev *pdev) | |||
167 | pci_read_config_word(pdev, I82860_GBA + index * 2, &value); | 167 | pci_read_config_word(pdev, I82860_GBA + index * 2, &value); |
168 | cumul_size = (value & I82860_GBA_MASK) << | 168 | cumul_size = (value & I82860_GBA_MASK) << |
169 | (I82860_GBA_SHIFT - PAGE_SHIFT); | 169 | (I82860_GBA_SHIFT - PAGE_SHIFT); |
170 | debugf3("(%d) cumul_size 0x%x\n", index, | 170 | edac_dbg(3, "(%d) cumul_size 0x%x\n", index, cumul_size); |
171 | cumul_size); | ||
172 | 171 | ||
173 | if (cumul_size == last_cumul_size) | 172 | if (cumul_size == last_cumul_size) |
174 | continue; /* not populated */ | 173 | continue; /* not populated */ |
@@ -210,7 +209,7 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx) | |||
210 | if (!mci) | 209 | if (!mci) |
211 | return -ENOMEM; | 210 | return -ENOMEM; |
212 | 211 | ||
213 | debugf3("init mci\n"); | 212 | edac_dbg(3, "init mci\n"); |
214 | mci->pdev = &pdev->dev; | 213 | mci->pdev = &pdev->dev; |
215 | mci->mtype_cap = MEM_FLAG_DDR; | 214 | mci->mtype_cap = MEM_FLAG_DDR; |
216 | mci->edac_ctl_cap = EDAC_FLAG_NONE | EDAC_FLAG_SECDED; | 215 | mci->edac_ctl_cap = EDAC_FLAG_NONE | EDAC_FLAG_SECDED; |
@@ -229,7 +228,7 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx) | |||
229 | * type of memory controller. The ID is therefore hardcoded to 0. | 228 | * type of memory controller. The ID is therefore hardcoded to 0. |
230 | */ | 229 | */ |
231 | if (edac_mc_add_mc(mci)) { | 230 | if (edac_mc_add_mc(mci)) { |
232 | debugf3("failed edac_mc_add_mc()\n"); | 231 | edac_dbg(3, "failed edac_mc_add_mc()\n"); |
233 | goto fail; | 232 | goto fail; |
234 | } | 233 | } |
235 | 234 | ||
@@ -245,7 +244,7 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx) | |||
245 | } | 244 | } |
246 | 245 | ||
247 | /* get this far and it's successful */ | 246 | /* get this far and it's successful */ |
248 | debugf3("success\n"); | 247 | edac_dbg(3, "success\n"); |
249 | 248 | ||
250 | return 0; | 249 | return 0; |
251 | 250 | ||
@@ -260,7 +259,7 @@ static int __devinit i82860_init_one(struct pci_dev *pdev, | |||
260 | { | 259 | { |
261 | int rc; | 260 | int rc; |
262 | 261 | ||
263 | debugf0("\n"); | 262 | edac_dbg(0, "\n"); |
264 | i82860_printk(KERN_INFO, "i82860 init one\n"); | 263 | i82860_printk(KERN_INFO, "i82860 init one\n"); |
265 | 264 | ||
266 | if (pci_enable_device(pdev) < 0) | 265 | if (pci_enable_device(pdev) < 0) |
@@ -278,7 +277,7 @@ static void __devexit i82860_remove_one(struct pci_dev *pdev) | |||
278 | { | 277 | { |
279 | struct mem_ctl_info *mci; | 278 | struct mem_ctl_info *mci; |
280 | 279 | ||
281 | debugf0("\n"); | 280 | edac_dbg(0, "\n"); |
282 | 281 | ||
283 | if (i82860_pci) | 282 | if (i82860_pci) |
284 | edac_pci_release_generic_ctl(i82860_pci); | 283 | edac_pci_release_generic_ctl(i82860_pci); |
@@ -311,7 +310,7 @@ static int __init i82860_init(void) | |||
311 | { | 310 | { |
312 | int pci_rc; | 311 | int pci_rc; |
313 | 312 | ||
314 | debugf3("\n"); | 313 | edac_dbg(3, "\n"); |
315 | 314 | ||
316 | /* Ensure that the OPSTATE is set correctly for POLL or NMI */ | 315 | /* Ensure that the OPSTATE is set correctly for POLL or NMI */ |
317 | opstate_init(); | 316 | opstate_init(); |
@@ -324,7 +323,7 @@ static int __init i82860_init(void) | |||
324 | PCI_DEVICE_ID_INTEL_82860_0, NULL); | 323 | PCI_DEVICE_ID_INTEL_82860_0, NULL); |
325 | 324 | ||
326 | if (mci_pdev == NULL) { | 325 | if (mci_pdev == NULL) { |
327 | debugf0("860 pci_get_device fail\n"); | 326 | edac_dbg(0, "860 pci_get_device fail\n"); |
328 | pci_rc = -ENODEV; | 327 | pci_rc = -ENODEV; |
329 | goto fail1; | 328 | goto fail1; |
330 | } | 329 | } |
@@ -332,7 +331,7 @@ static int __init i82860_init(void) | |||
332 | pci_rc = i82860_init_one(mci_pdev, i82860_pci_tbl); | 331 | pci_rc = i82860_init_one(mci_pdev, i82860_pci_tbl); |
333 | 332 | ||
334 | if (pci_rc < 0) { | 333 | if (pci_rc < 0) { |
335 | debugf0("860 init fail\n"); | 334 | edac_dbg(0, "860 init fail\n"); |
336 | pci_rc = -ENODEV; | 335 | pci_rc = -ENODEV; |
337 | goto fail1; | 336 | goto fail1; |
338 | } | 337 | } |
@@ -352,7 +351,7 @@ fail0: | |||
352 | 351 | ||
353 | static void __exit i82860_exit(void) | 352 | static void __exit i82860_exit(void) |
354 | { | 353 | { |
355 | debugf3("\n"); | 354 | edac_dbg(3, "\n"); |
356 | 355 | ||
357 | pci_unregister_driver(&i82860_driver); | 356 | pci_unregister_driver(&i82860_driver); |
358 | 357 | ||