aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/edac/i82860_edac.c
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab@redhat.com>2012-04-29 10:59:14 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-06-11 12:23:47 -0400
commitdd23cd6eb1f59ba722a6e6aa228adff7c01404de (patch)
tree32c45fb296293af1309f926b8c109eef329f4f22 /drivers/edac/i82860_edac.c
parent2639c3ee298401881cc560c5e3987f8b222b9f7c (diff)
edac: Don't add __func__ or __FILE__ for debugf[0-9] msgs
The debug macro already adds that. Most of the work here was made by this small script: $f .=$_ while (<>); $f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*": /\1"/g; $f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*/\1/g; $f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*"MC: /\1"/g; $f =~ s/(debugf[0-9]\s*\(\")\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+)__func__\s*\,\s*/\1\2/g; $f =~ s/(debugf[0-9]\s*\(\")\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+),\s*__func__\s*\)/\1\2)/g; $f =~ s/(debugf[0-9]\s*\(\"MC\:\s*)\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+)__func__\s*\,\s*/\1\2/g; $f =~ s/(debugf[0-9]\s*\(\"MC\:\s*)\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+),\s*__func__\s*\)/\1\2)/g; $f =~ s/\"MC\: \\n\"/"MC:\\n"/g; print $f; After running the script, manual cleanups were done to fix it the remaining places. While here, removed the __LINE__ on most places, as it doesn't actually give useful info on most places. Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/edac/i82860_edac.c')
-rw-r--r--drivers/edac/i82860_edac.c18
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/edac/i82860_edac.c b/drivers/edac/i82860_edac.c
index 06a3c8d26d19..d4ec21db22ba 100644
--- a/drivers/edac/i82860_edac.c
+++ b/drivers/edac/i82860_edac.c
@@ -136,7 +136,7 @@ static void i82860_check(struct mem_ctl_info *mci)
136{ 136{
137 struct i82860_error_info info; 137 struct i82860_error_info info;
138 138
139 debugf1("MC%d: %s()\n", mci->mc_idx, __func__); 139 debugf1("MC%d\n", mci->mc_idx);
140 i82860_get_error_info(mci, &info); 140 i82860_get_error_info(mci, &info);
141 i82860_process_error_info(mci, &info, 1); 141 i82860_process_error_info(mci, &info, 1);
142} 142}
@@ -167,7 +167,7 @@ static void i82860_init_csrows(struct mem_ctl_info *mci, struct pci_dev *pdev)
167 pci_read_config_word(pdev, I82860_GBA + index * 2, &value); 167 pci_read_config_word(pdev, I82860_GBA + index * 2, &value);
168 cumul_size = (value & I82860_GBA_MASK) << 168 cumul_size = (value & I82860_GBA_MASK) <<
169 (I82860_GBA_SHIFT - PAGE_SHIFT); 169 (I82860_GBA_SHIFT - PAGE_SHIFT);
170 debugf3("%s(): (%d) cumul_size 0x%x\n", __func__, index, 170 debugf3("(%d) cumul_size 0x%x\n", index,
171 cumul_size); 171 cumul_size);
172 172
173 if (cumul_size == last_cumul_size) 173 if (cumul_size == last_cumul_size)
@@ -210,7 +210,7 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx)
210 if (!mci) 210 if (!mci)
211 return -ENOMEM; 211 return -ENOMEM;
212 212
213 debugf3("%s(): init mci\n", __func__); 213 debugf3("init mci\n");
214 mci->pdev = &pdev->dev; 214 mci->pdev = &pdev->dev;
215 mci->mtype_cap = MEM_FLAG_DDR; 215 mci->mtype_cap = MEM_FLAG_DDR;
216 mci->edac_ctl_cap = EDAC_FLAG_NONE | EDAC_FLAG_SECDED; 216 mci->edac_ctl_cap = EDAC_FLAG_NONE | EDAC_FLAG_SECDED;
@@ -229,7 +229,7 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx)
229 * type of memory controller. The ID is therefore hardcoded to 0. 229 * type of memory controller. The ID is therefore hardcoded to 0.
230 */ 230 */
231 if (edac_mc_add_mc(mci)) { 231 if (edac_mc_add_mc(mci)) {
232 debugf3("%s(): failed edac_mc_add_mc()\n", __func__); 232 debugf3("failed edac_mc_add_mc()\n");
233 goto fail; 233 goto fail;
234 } 234 }
235 235
@@ -245,7 +245,7 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx)
245 } 245 }
246 246
247 /* get this far and it's successful */ 247 /* get this far and it's successful */
248 debugf3("%s(): success\n", __func__); 248 debugf3("success\n");
249 249
250 return 0; 250 return 0;
251 251
@@ -260,7 +260,7 @@ static int __devinit i82860_init_one(struct pci_dev *pdev,
260{ 260{
261 int rc; 261 int rc;
262 262
263 debugf0("%s()\n", __func__); 263 debugf0("\n");
264 i82860_printk(KERN_INFO, "i82860 init one\n"); 264 i82860_printk(KERN_INFO, "i82860 init one\n");
265 265
266 if (pci_enable_device(pdev) < 0) 266 if (pci_enable_device(pdev) < 0)
@@ -278,7 +278,7 @@ static void __devexit i82860_remove_one(struct pci_dev *pdev)
278{ 278{
279 struct mem_ctl_info *mci; 279 struct mem_ctl_info *mci;
280 280
281 debugf0("%s()\n", __func__); 281 debugf0("\n");
282 282
283 if (i82860_pci) 283 if (i82860_pci)
284 edac_pci_release_generic_ctl(i82860_pci); 284 edac_pci_release_generic_ctl(i82860_pci);
@@ -311,7 +311,7 @@ static int __init i82860_init(void)
311{ 311{
312 int pci_rc; 312 int pci_rc;
313 313
314 debugf3("%s()\n", __func__); 314 debugf3("\n");
315 315
316 /* Ensure that the OPSTATE is set correctly for POLL or NMI */ 316 /* Ensure that the OPSTATE is set correctly for POLL or NMI */
317 opstate_init(); 317 opstate_init();
@@ -352,7 +352,7 @@ fail0:
352 352
353static void __exit i82860_exit(void) 353static void __exit i82860_exit(void)
354{ 354{
355 debugf3("%s()\n", __func__); 355 debugf3("\n");
356 356
357 pci_unregister_driver(&i82860_driver); 357 pci_unregister_driver(&i82860_driver);
358 358