diff options
author | Dave Peterson <dsp@llnl.gov> | 2006-03-26 04:38:45 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-26 11:57:07 -0500 |
commit | 749ede57443b2a7ede2db105145f21047efcea6a (patch) | |
tree | 0d0ee972f55e8fbb9d8fba6209a6304fdd3c98f1 /drivers/edac/i82860_edac.c | |
parent | d38fde84f7521973fdfa5c3d03d62f014b42cd03 (diff) |
[PATCH] EDAC: cleanup code for clearing initial errors
Fix xxx_probe1() functions so they call xxx_get_error_info() functions
to clear initial errors. This is simpler and cleaner than duplicating
the low-level code for accessing PCI config space.
Signed-off-by: David S. Peterson <dsp@llnl.gov>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/edac/i82860_edac.c')
-rw-r--r-- | drivers/edac/i82860_edac.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/edac/i82860_edac.c b/drivers/edac/i82860_edac.c index e832778fc603..942129df0212 100644 --- a/drivers/edac/i82860_edac.c +++ b/drivers/edac/i82860_edac.c | |||
@@ -134,6 +134,7 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx) | |||
134 | int index; | 134 | int index; |
135 | struct mem_ctl_info *mci = NULL; | 135 | struct mem_ctl_info *mci = NULL; |
136 | unsigned long last_cumul_size; | 136 | unsigned long last_cumul_size; |
137 | struct i82860_error_info discard; | ||
137 | 138 | ||
138 | u16 mchcfg_ddim; /* DRAM Data Integrity Mode 0=none,2=edac */ | 139 | u16 mchcfg_ddim; /* DRAM Data Integrity Mode 0=none,2=edac */ |
139 | 140 | ||
@@ -200,8 +201,7 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx) | |||
200 | csrow->edac_mode = mchcfg_ddim ? EDAC_SECDED : EDAC_NONE; | 201 | csrow->edac_mode = mchcfg_ddim ? EDAC_SECDED : EDAC_NONE; |
201 | } | 202 | } |
202 | 203 | ||
203 | /* clear counters */ | 204 | i82860_get_error_info(mci, &discard); /* clear counters */ |
204 | pci_write_bits16(mci->pdev, I82860_ERRSTS, 0x0003, 0x0003); | ||
205 | 205 | ||
206 | if (edac_mc_add_mc(mci)) { | 206 | if (edac_mc_add_mc(mci)) { |
207 | debugf3("%s(): failed edac_mc_add_mc()\n", __func__); | 207 | debugf3("%s(): failed edac_mc_add_mc()\n", __func__); |