diff options
author | H. Peter Anvin <hpa@zytor.com> | 2012-05-30 15:11:26 -0400 |
---|---|---|
committer | H. Peter Anvin <hpa@zytor.com> | 2012-05-30 15:11:32 -0400 |
commit | bbd771474ec44b516107685d77e1c80bbe09f141 (patch) | |
tree | 0cb15781539a68f27b4ea6c89f827282630cbce6 /drivers/edac/i82443bxgx_edac.c | |
parent | 403e1c5b7495d7b80fae9fc4d0a7a6f5abdc3307 (diff) | |
parent | 319b6ffc6df892e4ccffff823cc5521a4a5d2dca (diff) |
Merge branch 'x86/trampoline' into x86/urgent
x86/trampoline contains an urgent commit which is necessarily on a
newer baseline.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'drivers/edac/i82443bxgx_edac.c')
-rw-r--r-- | drivers/edac/i82443bxgx_edac.c | 41 |
1 files changed, 25 insertions, 16 deletions
diff --git a/drivers/edac/i82443bxgx_edac.c b/drivers/edac/i82443bxgx_edac.c index 3bf2b2f490e7..52072c28a8a6 100644 --- a/drivers/edac/i82443bxgx_edac.c +++ b/drivers/edac/i82443bxgx_edac.c | |||
@@ -12,7 +12,7 @@ | |||
12 | * 440GX fix by Jason Uhlenkott <juhlenko@akamai.com>. | 12 | * 440GX fix by Jason Uhlenkott <juhlenko@akamai.com>. |
13 | * | 13 | * |
14 | * Written with reference to 82443BX Host Bridge Datasheet: | 14 | * Written with reference to 82443BX Host Bridge Datasheet: |
15 | * http://download.intel.com/design/chipsets/datashts/29063301.pdf | 15 | * http://download.intel.com/design/chipsets/datashts/29063301.pdf |
16 | * references to this document given in []. | 16 | * references to this document given in []. |
17 | * | 17 | * |
18 | * This module doesn't support the 440LX, but it may be possible to | 18 | * This module doesn't support the 440LX, but it may be possible to |
@@ -156,19 +156,19 @@ static int i82443bxgx_edacmc_process_error_info(struct mem_ctl_info *mci, | |||
156 | if (info->eap & I82443BXGX_EAP_OFFSET_SBE) { | 156 | if (info->eap & I82443BXGX_EAP_OFFSET_SBE) { |
157 | error_found = 1; | 157 | error_found = 1; |
158 | if (handle_errors) | 158 | if (handle_errors) |
159 | edac_mc_handle_ce(mci, page, pageoffset, | 159 | edac_mc_handle_error(HW_EVENT_ERR_CORRECTED, mci, |
160 | /* 440BX/GX don't make syndrome information | 160 | page, pageoffset, 0, |
161 | * available */ | 161 | edac_mc_find_csrow_by_page(mci, page), |
162 | 0, edac_mc_find_csrow_by_page(mci, page), 0, | 162 | 0, -1, mci->ctl_name, "", NULL); |
163 | mci->ctl_name); | ||
164 | } | 163 | } |
165 | 164 | ||
166 | if (info->eap & I82443BXGX_EAP_OFFSET_MBE) { | 165 | if (info->eap & I82443BXGX_EAP_OFFSET_MBE) { |
167 | error_found = 1; | 166 | error_found = 1; |
168 | if (handle_errors) | 167 | if (handle_errors) |
169 | edac_mc_handle_ue(mci, page, pageoffset, | 168 | edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci, |
170 | edac_mc_find_csrow_by_page(mci, page), | 169 | page, pageoffset, 0, |
171 | mci->ctl_name); | 170 | edac_mc_find_csrow_by_page(mci, page), |
171 | 0, -1, mci->ctl_name, "", NULL); | ||
172 | } | 172 | } |
173 | 173 | ||
174 | return error_found; | 174 | return error_found; |
@@ -189,6 +189,7 @@ static void i82443bxgx_init_csrows(struct mem_ctl_info *mci, | |||
189 | enum mem_type mtype) | 189 | enum mem_type mtype) |
190 | { | 190 | { |
191 | struct csrow_info *csrow; | 191 | struct csrow_info *csrow; |
192 | struct dimm_info *dimm; | ||
192 | int index; | 193 | int index; |
193 | u8 drbar, dramc; | 194 | u8 drbar, dramc; |
194 | u32 row_base, row_high_limit, row_high_limit_last; | 195 | u32 row_base, row_high_limit, row_high_limit_last; |
@@ -197,6 +198,8 @@ static void i82443bxgx_init_csrows(struct mem_ctl_info *mci, | |||
197 | row_high_limit_last = 0; | 198 | row_high_limit_last = 0; |
198 | for (index = 0; index < mci->nr_csrows; index++) { | 199 | for (index = 0; index < mci->nr_csrows; index++) { |
199 | csrow = &mci->csrows[index]; | 200 | csrow = &mci->csrows[index]; |
201 | dimm = csrow->channels[0].dimm; | ||
202 | |||
200 | pci_read_config_byte(pdev, I82443BXGX_DRB + index, &drbar); | 203 | pci_read_config_byte(pdev, I82443BXGX_DRB + index, &drbar); |
201 | debugf1("MC%d: %s: %s() Row=%d DRB = %#0x\n", | 204 | debugf1("MC%d: %s: %s() Row=%d DRB = %#0x\n", |
202 | mci->mc_idx, __FILE__, __func__, index, drbar); | 205 | mci->mc_idx, __FILE__, __func__, index, drbar); |
@@ -217,14 +220,14 @@ static void i82443bxgx_init_csrows(struct mem_ctl_info *mci, | |||
217 | row_base = row_high_limit_last; | 220 | row_base = row_high_limit_last; |
218 | csrow->first_page = row_base >> PAGE_SHIFT; | 221 | csrow->first_page = row_base >> PAGE_SHIFT; |
219 | csrow->last_page = (row_high_limit >> PAGE_SHIFT) - 1; | 222 | csrow->last_page = (row_high_limit >> PAGE_SHIFT) - 1; |
220 | csrow->nr_pages = csrow->last_page - csrow->first_page + 1; | 223 | dimm->nr_pages = csrow->last_page - csrow->first_page + 1; |
221 | /* EAP reports in 4kilobyte granularity [61] */ | 224 | /* EAP reports in 4kilobyte granularity [61] */ |
222 | csrow->grain = 1 << 12; | 225 | dimm->grain = 1 << 12; |
223 | csrow->mtype = mtype; | 226 | dimm->mtype = mtype; |
224 | /* I don't think 440BX can tell you device type? FIXME? */ | 227 | /* I don't think 440BX can tell you device type? FIXME? */ |
225 | csrow->dtype = DEV_UNKNOWN; | 228 | dimm->dtype = DEV_UNKNOWN; |
226 | /* Mode is global to all rows on 440BX */ | 229 | /* Mode is global to all rows on 440BX */ |
227 | csrow->edac_mode = edac_mode; | 230 | dimm->edac_mode = edac_mode; |
228 | row_high_limit_last = row_high_limit; | 231 | row_high_limit_last = row_high_limit; |
229 | } | 232 | } |
230 | } | 233 | } |
@@ -232,6 +235,7 @@ static void i82443bxgx_init_csrows(struct mem_ctl_info *mci, | |||
232 | static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx) | 235 | static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx) |
233 | { | 236 | { |
234 | struct mem_ctl_info *mci; | 237 | struct mem_ctl_info *mci; |
238 | struct edac_mc_layer layers[2]; | ||
235 | u8 dramc; | 239 | u8 dramc; |
236 | u32 nbxcfg, ecc_mode; | 240 | u32 nbxcfg, ecc_mode; |
237 | enum mem_type mtype; | 241 | enum mem_type mtype; |
@@ -245,8 +249,13 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx) | |||
245 | if (pci_read_config_dword(pdev, I82443BXGX_NBXCFG, &nbxcfg)) | 249 | if (pci_read_config_dword(pdev, I82443BXGX_NBXCFG, &nbxcfg)) |
246 | return -EIO; | 250 | return -EIO; |
247 | 251 | ||
248 | mci = edac_mc_alloc(0, I82443BXGX_NR_CSROWS, I82443BXGX_NR_CHANS, 0); | 252 | layers[0].type = EDAC_MC_LAYER_CHIP_SELECT; |
249 | 253 | layers[0].size = I82443BXGX_NR_CSROWS; | |
254 | layers[0].is_virt_csrow = true; | ||
255 | layers[1].type = EDAC_MC_LAYER_CHANNEL; | ||
256 | layers[1].size = I82443BXGX_NR_CHANS; | ||
257 | layers[1].is_virt_csrow = false; | ||
258 | mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers, 0); | ||
250 | if (mci == NULL) | 259 | if (mci == NULL) |
251 | return -ENOMEM; | 260 | return -ENOMEM; |
252 | 261 | ||