diff options
author | Hitoshi Mitake <h.mitake@gmail.com> | 2008-04-29 04:03:18 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-29 11:06:26 -0400 |
commit | c3c52bce6993c6d37af2c2de9b482a7013d646a7 (patch) | |
tree | dc03a88574a0029af51aad044c449cb90e52247f /drivers/edac/i82443bxgx_edac.c | |
parent | 1a45027d1afd7e85254b5ef8535e93ce3d588cf4 (diff) |
edac: fix module initialization on several modules 2nd time
I implemented opstate_init() as a inline function in linux/edac.h.
added calling opstate_init() to:
i82443bxgx_edac.c
i82860_edac.c
i82875p_edac.c
i82975x_edac.c
I wrote a fixed patch of
edac-fix-module-initialization-on-several-modules.patch,
and tested building 2.6.25-rc7 with applying this. It was succeed.
I think the patch is now correct.
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
Signed-off-by: Doug Thompson <dougthompson@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/edac/i82443bxgx_edac.c')
-rw-r--r-- | drivers/edac/i82443bxgx_edac.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/edac/i82443bxgx_edac.c b/drivers/edac/i82443bxgx_edac.c index 83bfe37c4bbb..c5305e3ee434 100644 --- a/drivers/edac/i82443bxgx_edac.c +++ b/drivers/edac/i82443bxgx_edac.c | |||
@@ -29,6 +29,7 @@ | |||
29 | 29 | ||
30 | #include <linux/slab.h> | 30 | #include <linux/slab.h> |
31 | 31 | ||
32 | #include <linux/edac.h> | ||
32 | #include "edac_core.h" | 33 | #include "edac_core.h" |
33 | 34 | ||
34 | #define I82443_REVISION "0.1" | 35 | #define I82443_REVISION "0.1" |
@@ -386,6 +387,9 @@ static struct pci_driver i82443bxgx_edacmc_driver = { | |||
386 | 387 | ||
387 | static int __init i82443bxgx_edacmc_init(void) | 388 | static int __init i82443bxgx_edacmc_init(void) |
388 | { | 389 | { |
390 | /* Ensure that the OPSTATE is set correctly for POLL or NMI */ | ||
391 | opstate_init(); | ||
392 | |||
389 | return pci_register_driver(&i82443bxgx_edacmc_driver); | 393 | return pci_register_driver(&i82443bxgx_edacmc_driver); |
390 | } | 394 | } |
391 | 395 | ||
@@ -400,3 +404,6 @@ module_exit(i82443bxgx_edacmc_exit); | |||
400 | MODULE_LICENSE("GPL"); | 404 | MODULE_LICENSE("GPL"); |
401 | MODULE_AUTHOR("Tim Small <tim@buttersideup.com> - WPAD"); | 405 | MODULE_AUTHOR("Tim Small <tim@buttersideup.com> - WPAD"); |
402 | MODULE_DESCRIPTION("EDAC MC support for Intel 82443BX/GX memory controllers"); | 406 | MODULE_DESCRIPTION("EDAC MC support for Intel 82443BX/GX memory controllers"); |
407 | |||
408 | module_param(edac_op_state, int, 0444); | ||
409 | MODULE_PARM_DESC(edac_op_state, "EDAC Error Reporting state: 0=Poll,1=NMI"); | ||