diff options
author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-08-26 22:19:54 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-08-30 13:56:45 -0400 |
commit | 116389ed21e4ad88f65e7ec5ed6ca224acb89115 (patch) | |
tree | 2e891ce607811b12b8be1ab1c9d69a3a2e3b98c1 /drivers/edac/i7300_edac.c | |
parent | c3af2eaf7a3257f7b44165ec487215574c47fd32 (diff) |
i7300_edac: Add a FIXME note about the error correction type
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/edac/i7300_edac.c')
-rw-r--r-- | drivers/edac/i7300_edac.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/edac/i7300_edac.c b/drivers/edac/i7300_edac.c index 7e035b6d0d0f..36265e21fef2 100644 --- a/drivers/edac/i7300_edac.c +++ b/drivers/edac/i7300_edac.c | |||
@@ -841,6 +841,15 @@ static int decode_mtr(struct i7300_pvt *pvt, | |||
841 | p_csrow->grain = 8; | 841 | p_csrow->grain = 8; |
842 | p_csrow->nr_pages = dinfo->megabytes << 8; | 842 | p_csrow->nr_pages = dinfo->megabytes << 8; |
843 | p_csrow->mtype = MEM_FB_DDR2; | 843 | p_csrow->mtype = MEM_FB_DDR2; |
844 | |||
845 | /* | ||
846 | * FIXME: the type of error detection actually depends of the | ||
847 | * mode of operation. When it is just one single memory chip, at | ||
848 | * socket 0, channel 0, it uses 8-byte-over-32-byte SECDED+ code. | ||
849 | * In normal or mirrored mode, it uses Single Device Data correction, | ||
850 | * with the possibility of using an extended algorithm for x8 memories | ||
851 | * See datasheet Sections 7.3.6 to 7.3.8 | ||
852 | */ | ||
844 | p_csrow->edac_mode = EDAC_S8ECD8ED; | 853 | p_csrow->edac_mode = EDAC_S8ECD8ED; |
845 | 854 | ||
846 | /* ask what device type on this row */ | 855 | /* ask what device type on this row */ |