diff options
author | Hitoshi Mitake <h.mitake@gmail.com> | 2008-04-29 04:03:18 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-29 11:06:26 -0400 |
commit | c3c52bce6993c6d37af2c2de9b482a7013d646a7 (patch) | |
tree | dc03a88574a0029af51aad044c449cb90e52247f /drivers/edac/e7xxx_edac.c | |
parent | 1a45027d1afd7e85254b5ef8535e93ce3d588cf4 (diff) |
edac: fix module initialization on several modules 2nd time
I implemented opstate_init() as a inline function in linux/edac.h.
added calling opstate_init() to:
i82443bxgx_edac.c
i82860_edac.c
i82875p_edac.c
i82975x_edac.c
I wrote a fixed patch of
edac-fix-module-initialization-on-several-modules.patch,
and tested building 2.6.25-rc7 with applying this. It was succeed.
I think the patch is now correct.
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
Signed-off-by: Doug Thompson <dougthompson@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/edac/e7xxx_edac.c')
-rw-r--r-- | drivers/edac/e7xxx_edac.c | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/drivers/edac/e7xxx_edac.c b/drivers/edac/e7xxx_edac.c index 96ecc4926641..c7d11cc4e21a 100644 --- a/drivers/edac/e7xxx_edac.c +++ b/drivers/edac/e7xxx_edac.c | |||
@@ -414,16 +414,6 @@ static int e7xxx_probe1(struct pci_dev *pdev, int dev_idx) | |||
414 | 414 | ||
415 | debugf0("%s(): mci\n", __func__); | 415 | debugf0("%s(): mci\n", __func__); |
416 | 416 | ||
417 | /* make sure error reporting method is sane */ | ||
418 | switch (edac_op_state) { | ||
419 | case EDAC_OPSTATE_POLL: | ||
420 | case EDAC_OPSTATE_NMI: | ||
421 | break; | ||
422 | default: | ||
423 | edac_op_state = EDAC_OPSTATE_POLL; | ||
424 | break; | ||
425 | } | ||
426 | |||
427 | pci_read_config_dword(pdev, E7XXX_DRC, &drc); | 417 | pci_read_config_dword(pdev, E7XXX_DRC, &drc); |
428 | 418 | ||
429 | drc_chan = dual_channel_active(drc, dev_idx); | 419 | drc_chan = dual_channel_active(drc, dev_idx); |
@@ -565,6 +555,9 @@ static struct pci_driver e7xxx_driver = { | |||
565 | 555 | ||
566 | static int __init e7xxx_init(void) | 556 | static int __init e7xxx_init(void) |
567 | { | 557 | { |
558 | /* Ensure that the OPSTATE is set correctly for POLL or NMI */ | ||
559 | opstate_init(); | ||
560 | |||
568 | return pci_register_driver(&e7xxx_driver); | 561 | return pci_register_driver(&e7xxx_driver); |
569 | } | 562 | } |
570 | 563 | ||