diff options
author | Doug Thompson <dougthompson@xmission.com> | 2009-04-27 13:46:08 -0400 |
---|---|---|
committer | Borislav Petkov <borislav.petkov@amd.com> | 2009-06-10 06:19:01 -0400 |
commit | f9431992b6227069bc54800d55531c6f78d276a7 (patch) | |
tree | d9b210e69b8d80308d7a512f047e598babf30084 /drivers/edac/amd64_edac.h | |
parent | 0ec449ee95b20245fef4aa9fa2486456f1540514 (diff) |
amd64_edac: add ECC reporting initializers
Borislav:
- convert to the new {rd|wr}msr_on_cpus interfaces.
- convert pvt->old_mcgctl to a bitmask thus saving some bytes
- fix/cleanup comments
- fix function return value patterns
- add a proper bugfix found by Doug to amd64_check_ecc_enabled where we
missed checking for the ECC enabled bit in NB CFG.
- cleanup debug calls
Reviewed-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Doug Thompson <dougthompson@xmission.com>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Diffstat (limited to 'drivers/edac/amd64_edac.h')
-rw-r--r-- | drivers/edac/amd64_edac.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h index 6f5d5d62cefc..e7aa760614ce 100644 --- a/drivers/edac/amd64_edac.h +++ b/drivers/edac/amd64_edac.h | |||
@@ -70,6 +70,7 @@ | |||
70 | #include <linux/slab.h> | 70 | #include <linux/slab.h> |
71 | #include <linux/mmzone.h> | 71 | #include <linux/mmzone.h> |
72 | #include <linux/edac.h> | 72 | #include <linux/edac.h> |
73 | #include <asm/msr.h> | ||
73 | #include "edac_core.h" | 74 | #include "edac_core.h" |
74 | 75 | ||
75 | #define amd64_printk(level, fmt, arg...) \ | 76 | #define amd64_printk(level, fmt, arg...) \ |
@@ -549,7 +550,7 @@ struct amd64_pvt { | |||
549 | /* Save old hw registers' values before we modified them */ | 550 | /* Save old hw registers' values before we modified them */ |
550 | u32 nbctl_mcgctl_saved; /* When true, following 2 are valid */ | 551 | u32 nbctl_mcgctl_saved; /* When true, following 2 are valid */ |
551 | u32 old_nbctl; | 552 | u32 old_nbctl; |
552 | u32 *old_mcgctl; /* per core on this node */ | 553 | unsigned long old_mcgctl; /* per core on this node */ |
553 | 554 | ||
554 | /* MC Type Index value: socket F vs Family 10h */ | 555 | /* MC Type Index value: socket F vs Family 10h */ |
555 | u32 mc_type_index; | 556 | u32 mc_type_index; |