diff options
author | Borislav Petkov <borislav.petkov@amd.com> | 2012-09-12 12:06:00 -0400 |
---|---|---|
committer | Borislav Petkov <bp@alien8.de> | 2012-11-28 05:45:46 -0500 |
commit | bb89f5a0547a56cf2406f1c3d6cd44f8fa62256d (patch) | |
tree | ab3801986b88f2f435a014684f4b802ac6779659 /drivers/edac/amd64_edac.c | |
parent | 33ca0643c9a0ea50d0dc9bf0e9e9044502c7038c (diff) |
amd64_edac: Fix K8 chip select reporting
This basically reverts 603adaf6b3e3 ("amd64_edac: fix K8 chip select
reporting") because it was a clumsy workaround for DIMM sizes reporting
on K8 which got superceded by a much more correct one with 41d8bfaba70
("amd64_edac: Improve DRAM address mapping") without removing the prior
one. Remove it now finally.
Reported-by: Josh Hunt <johunt@akamai.com>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Diffstat (limited to 'drivers/edac/amd64_edac.c')
-rw-r--r-- | drivers/edac/amd64_edac.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index d21efb246d43..cfb7e57786d1 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c | |||
@@ -1596,14 +1596,11 @@ static void f1x_map_sysaddr_to_csrow(struct mem_ctl_info *mci, u64 sys_addr, | |||
1596 | */ | 1596 | */ |
1597 | static void amd64_debug_display_dimm_sizes(struct amd64_pvt *pvt, u8 ctrl) | 1597 | static void amd64_debug_display_dimm_sizes(struct amd64_pvt *pvt, u8 ctrl) |
1598 | { | 1598 | { |
1599 | int dimm, size0, size1, factor = 0; | 1599 | int dimm, size0, size1; |
1600 | u32 *dcsb = ctrl ? pvt->csels[1].csbases : pvt->csels[0].csbases; | 1600 | u32 *dcsb = ctrl ? pvt->csels[1].csbases : pvt->csels[0].csbases; |
1601 | u32 dbam = ctrl ? pvt->dbam1 : pvt->dbam0; | 1601 | u32 dbam = ctrl ? pvt->dbam1 : pvt->dbam0; |
1602 | 1602 | ||
1603 | if (boot_cpu_data.x86 == 0xf) { | 1603 | if (boot_cpu_data.x86 == 0xf) { |
1604 | if (pvt->dclr0 & WIDTH_128) | ||
1605 | factor = 1; | ||
1606 | |||
1607 | /* K8 families < revF not supported yet */ | 1604 | /* K8 families < revF not supported yet */ |
1608 | if (pvt->ext_model < K8_REV_F) | 1605 | if (pvt->ext_model < K8_REV_F) |
1609 | return; | 1606 | return; |
@@ -1634,8 +1631,8 @@ static void amd64_debug_display_dimm_sizes(struct amd64_pvt *pvt, u8 ctrl) | |||
1634 | DBAM_DIMM(dimm, dbam)); | 1631 | DBAM_DIMM(dimm, dbam)); |
1635 | 1632 | ||
1636 | amd64_info(EDAC_MC ": %d: %5dMB %d: %5dMB\n", | 1633 | amd64_info(EDAC_MC ": %d: %5dMB %d: %5dMB\n", |
1637 | dimm * 2, size0 << factor, | 1634 | dimm * 2, size0, |
1638 | dimm * 2 + 1, size1 << factor); | 1635 | dimm * 2 + 1, size1); |
1639 | } | 1636 | } |
1640 | } | 1637 | } |
1641 | 1638 | ||