diff options
author | Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> | 2013-12-11 09:29:15 -0500 |
---|---|---|
committer | Vinod Koul <vinod.koul@intel.com> | 2014-03-06 01:05:23 -0500 |
commit | 42e4a12a0d92d09de66d8b5b2c85855b8051c15e (patch) | |
tree | 9a3f13d3f72f70f4e65f6668a2f01bdfb3eedcb5 /drivers/dma | |
parent | d6be34fbd39b7d577d25cb4edec538e8990ba07c (diff) |
DMA: shdma: Fix warnings due to improper casts and printk formats
Use the %zu and %pad printk specifiers to print size_t and dma_addr_t
variables, and cast pointers to uintptr_t instead of unsigned int where
applicable. This fixes warnings on platforms where pointers and/or
dma_addr_t have a different size than int
Cc: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma')
-rw-r--r-- | drivers/dma/sh/shdma-base.c | 10 | ||||
-rw-r--r-- | drivers/dma/sh/shdma-of.c | 3 | ||||
-rw-r--r-- | drivers/dma/sh/sudmac.c | 4 |
3 files changed, 9 insertions, 8 deletions
diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c index 2e7b394def80..52396771acbe 100644 --- a/drivers/dma/sh/shdma-base.c +++ b/drivers/dma/sh/shdma-base.c | |||
@@ -227,7 +227,7 @@ bool shdma_chan_filter(struct dma_chan *chan, void *arg) | |||
227 | struct shdma_chan *schan = to_shdma_chan(chan); | 227 | struct shdma_chan *schan = to_shdma_chan(chan); |
228 | struct shdma_dev *sdev = to_shdma_dev(schan->dma_chan.device); | 228 | struct shdma_dev *sdev = to_shdma_dev(schan->dma_chan.device); |
229 | const struct shdma_ops *ops = sdev->ops; | 229 | const struct shdma_ops *ops = sdev->ops; |
230 | int match = (int)arg; | 230 | int match = (long)arg; |
231 | int ret; | 231 | int ret; |
232 | 232 | ||
233 | if (match < 0) | 233 | if (match < 0) |
@@ -491,8 +491,8 @@ static struct shdma_desc *shdma_add_desc(struct shdma_chan *schan, | |||
491 | } | 491 | } |
492 | 492 | ||
493 | dev_dbg(schan->dev, | 493 | dev_dbg(schan->dev, |
494 | "chaining (%u/%u)@%x -> %x with %p, cookie %d\n", | 494 | "chaining (%zu/%zu)@%pad -> %pad with %p, cookie %d\n", |
495 | copy_size, *len, *src, *dst, &new->async_tx, | 495 | copy_size, *len, src, dst, &new->async_tx, |
496 | new->async_tx.cookie); | 496 | new->async_tx.cookie); |
497 | 497 | ||
498 | new->mark = DESC_PREPARED; | 498 | new->mark = DESC_PREPARED; |
@@ -555,8 +555,8 @@ static struct dma_async_tx_descriptor *shdma_prep_sg(struct shdma_chan *schan, | |||
555 | goto err_get_desc; | 555 | goto err_get_desc; |
556 | 556 | ||
557 | do { | 557 | do { |
558 | dev_dbg(schan->dev, "Add SG #%d@%p[%d], dma %llx\n", | 558 | dev_dbg(schan->dev, "Add SG #%d@%p[%zu], dma %pad\n", |
559 | i, sg, len, (unsigned long long)sg_addr); | 559 | i, sg, len, &sg_addr); |
560 | 560 | ||
561 | if (direction == DMA_DEV_TO_MEM) | 561 | if (direction == DMA_DEV_TO_MEM) |
562 | new = shdma_add_desc(schan, flags, | 562 | new = shdma_add_desc(schan, flags, |
diff --git a/drivers/dma/sh/shdma-of.c b/drivers/dma/sh/shdma-of.c index 06473a05fe4e..b4ff9d3e56d1 100644 --- a/drivers/dma/sh/shdma-of.c +++ b/drivers/dma/sh/shdma-of.c | |||
@@ -33,7 +33,8 @@ static struct dma_chan *shdma_of_xlate(struct of_phandle_args *dma_spec, | |||
33 | /* Only slave DMA channels can be allocated via DT */ | 33 | /* Only slave DMA channels can be allocated via DT */ |
34 | dma_cap_set(DMA_SLAVE, mask); | 34 | dma_cap_set(DMA_SLAVE, mask); |
35 | 35 | ||
36 | chan = dma_request_channel(mask, shdma_chan_filter, (void *)id); | 36 | chan = dma_request_channel(mask, shdma_chan_filter, |
37 | (void *)(uintptr_t)id); | ||
37 | if (chan) | 38 | if (chan) |
38 | to_shdma_chan(chan)->hw_req = id; | 39 | to_shdma_chan(chan)->hw_req = id; |
39 | 40 | ||
diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c index c7e9cdff0708..4e7df43b50d6 100644 --- a/drivers/dma/sh/sudmac.c +++ b/drivers/dma/sh/sudmac.c | |||
@@ -178,8 +178,8 @@ static int sudmac_desc_setup(struct shdma_chan *schan, | |||
178 | struct sudmac_chan *sc = to_chan(schan); | 178 | struct sudmac_chan *sc = to_chan(schan); |
179 | struct sudmac_desc *sd = to_desc(sdesc); | 179 | struct sudmac_desc *sd = to_desc(sdesc); |
180 | 180 | ||
181 | dev_dbg(sc->shdma_chan.dev, "%s: src=%x, dst=%x, len=%d\n", | 181 | dev_dbg(sc->shdma_chan.dev, "%s: src=%pad, dst=%pad, len=%zu\n", |
182 | __func__, src, dst, *len); | 182 | __func__, &src, &dst, *len); |
183 | 183 | ||
184 | if (*len > schan->max_xfer_len) | 184 | if (*len > schan->max_xfer_len) |
185 | *len = schan->max_xfer_len; | 185 | *len = schan->max_xfer_len; |