diff options
author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2014-08-22 08:19:44 -0400 |
---|---|---|
committer | Dan Williams <dan.j.williams@intel.com> | 2014-08-22 09:17:37 -0400 |
commit | 8e1f50d7433b9a6e52cb296943f53c3ce8189ea5 (patch) | |
tree | ead604fd4ce9da52cae2cec23f012b77384b31f5 /drivers/dma | |
parent | e628ce70cae5ccd67830b0e2c3d038831746d86b (diff) |
dmatest: prevent memory leakage on error path in thread
When we fail to allocate memory for thread->srcs or thread->dsts and src_cnt or
dst_cnt great than 1 we leak memory on error path. This patch fixes the issue.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/dma')
-rw-r--r-- | drivers/dma/dmatest.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index 05b6dea770a4..69616e2108fc 100644 --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c | |||
@@ -688,14 +688,14 @@ static int dmatest_func(void *data) | |||
688 | runtime = ktime_us_delta(ktime_get(), ktime); | 688 | runtime = ktime_us_delta(ktime_get(), ktime); |
689 | 689 | ||
690 | ret = 0; | 690 | ret = 0; |
691 | err_dstbuf: | ||
691 | for (i = 0; thread->dsts[i]; i++) | 692 | for (i = 0; thread->dsts[i]; i++) |
692 | kfree(thread->dsts[i]); | 693 | kfree(thread->dsts[i]); |
693 | err_dstbuf: | ||
694 | kfree(thread->dsts); | 694 | kfree(thread->dsts); |
695 | err_dsts: | 695 | err_dsts: |
696 | err_srcbuf: | ||
696 | for (i = 0; thread->srcs[i]; i++) | 697 | for (i = 0; thread->srcs[i]; i++) |
697 | kfree(thread->srcs[i]); | 698 | kfree(thread->srcs[i]); |
698 | err_srcbuf: | ||
699 | kfree(thread->srcs); | 699 | kfree(thread->srcs); |
700 | err_srcs: | 700 | err_srcs: |
701 | kfree(pq_coefs); | 701 | kfree(pq_coefs); |