diff options
author | Jingoo Han <jg1.han@samsung.com> | 2013-08-25 20:32:05 -0400 |
---|---|---|
committer | Vinod Koul <vinod.koul@intel.com> | 2013-08-27 04:56:29 -0400 |
commit | eb262a5419708319a3174d4ddf2777f472779182 (patch) | |
tree | 35861017dedc9c6ae9a68eed3e532a29b3359616 /drivers/dma | |
parent | 1e69653d40f1a280dbfef48b0c62473ac415dd57 (diff) |
dma: sh: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma')
-rw-r--r-- | drivers/dma/sh/shdmac.c | 3 | ||||
-rw-r--r-- | drivers/dma/sh/sudmac.c | 2 |
2 files changed, 0 insertions, 5 deletions
diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c index 77de5e4375f2..6128715973a4 100644 --- a/drivers/dma/sh/shdmac.c +++ b/drivers/dma/sh/shdmac.c | |||
@@ -890,7 +890,6 @@ rst_err: | |||
890 | pm_runtime_put(&pdev->dev); | 890 | pm_runtime_put(&pdev->dev); |
891 | pm_runtime_disable(&pdev->dev); | 891 | pm_runtime_disable(&pdev->dev); |
892 | 892 | ||
893 | platform_set_drvdata(pdev, NULL); | ||
894 | shdma_cleanup(&shdev->shdma_dev); | 893 | shdma_cleanup(&shdev->shdma_dev); |
895 | eshdma: | 894 | eshdma: |
896 | synchronize_rcu(); | 895 | synchronize_rcu(); |
@@ -919,8 +918,6 @@ static int sh_dmae_remove(struct platform_device *pdev) | |||
919 | sh_dmae_chan_remove(shdev); | 918 | sh_dmae_chan_remove(shdev); |
920 | shdma_cleanup(&shdev->shdma_dev); | 919 | shdma_cleanup(&shdev->shdma_dev); |
921 | 920 | ||
922 | platform_set_drvdata(pdev, NULL); | ||
923 | |||
924 | synchronize_rcu(); | 921 | synchronize_rcu(); |
925 | 922 | ||
926 | return 0; | 923 | return 0; |
diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c index 4600b429603e..90ba2ded2455 100644 --- a/drivers/dma/sh/sudmac.c +++ b/drivers/dma/sh/sudmac.c | |||
@@ -391,7 +391,6 @@ static int sudmac_probe(struct platform_device *pdev) | |||
391 | chan_probe_err: | 391 | chan_probe_err: |
392 | sudmac_chan_remove(su_dev); | 392 | sudmac_chan_remove(su_dev); |
393 | 393 | ||
394 | platform_set_drvdata(pdev, NULL); | ||
395 | shdma_cleanup(&su_dev->shdma_dev); | 394 | shdma_cleanup(&su_dev->shdma_dev); |
396 | 395 | ||
397 | return err; | 396 | return err; |
@@ -405,7 +404,6 @@ static int sudmac_remove(struct platform_device *pdev) | |||
405 | dma_async_device_unregister(dma_dev); | 404 | dma_async_device_unregister(dma_dev); |
406 | sudmac_chan_remove(su_dev); | 405 | sudmac_chan_remove(su_dev); |
407 | shdma_cleanup(&su_dev->shdma_dev); | 406 | shdma_cleanup(&su_dev->shdma_dev); |
408 | platform_set_drvdata(pdev, NULL); | ||
409 | 407 | ||
410 | return 0; | 408 | return 0; |
411 | } | 409 | } |