aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/dma
diff options
context:
space:
mode:
authorRussell King - ARM Linux <linux@arm.linux.org.uk>2011-01-03 17:35:28 -0500
committerDan Williams <dan.j.williams@intel.com>2011-01-04 22:16:11 -0500
commit7cb72ad959b16ac594118977b7954a7d2ec7a052 (patch)
treeeb6ea7ae69b7a8c2caef7d10eaec1a4dcf1110b4 /drivers/dma
parentf96ca9ec27159c1c8718aa8d0ed03051cd12e884 (diff)
ARM: PL08x: avoid 'void *' struct fields when we can type them properly
Avoid using 'void *' struct fields when the structs are not defined in linux/amba/pl08x.h - instead, forward declare the struct names, and use these instead. This ensures we have proper typechecking. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Acked-by: Linus Walleij <linus.walleij@stericsson.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/dma')
-rw-r--r--drivers/dma/amba-pl08x.c16
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 707fa081c9fa..fada97873d7d 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -107,7 +107,7 @@ struct vendor_data {
107 * An LLI struct - see PL08x TRM. Note that next uses bit[0] as a bus bit, 107 * An LLI struct - see PL08x TRM. Note that next uses bit[0] as a bus bit,
108 * start & end do not - their bus bit info is in cctl. 108 * start & end do not - their bus bit info is in cctl.
109 */ 109 */
110struct lli { 110struct pl08x_lli {
111 dma_addr_t src; 111 dma_addr_t src;
112 dma_addr_t dst; 112 dma_addr_t dst;
113 dma_addr_t next; 113 dma_addr_t next;
@@ -160,7 +160,7 @@ struct pl08x_driver_data {
160 160
161/* Maximum times we call dma_pool_alloc on this pool without freeing */ 161/* Maximum times we call dma_pool_alloc on this pool without freeing */
162#define PL08X_MAX_ALLOCS 0x40 162#define PL08X_MAX_ALLOCS 0x40
163#define MAX_NUM_TSFR_LLIS (PL08X_LLI_TSFR_SIZE/sizeof(struct lli)) 163#define MAX_NUM_TSFR_LLIS (PL08X_LLI_TSFR_SIZE/sizeof(struct pl08x_lli))
164#define PL08X_ALIGN 8 164#define PL08X_ALIGN 8
165 165
166static inline struct pl08x_dma_chan *to_pl08x_chan(struct dma_chan *chan) 166static inline struct pl08x_dma_chan *to_pl08x_chan(struct dma_chan *chan)
@@ -354,8 +354,8 @@ static u32 pl08x_getbytes_chan(struct pl08x_dma_chan *plchan)
354 * currently active transaction. 354 * currently active transaction.
355 */ 355 */
356 if (ch && txd) { 356 if (ch && txd) {
357 struct lli *llis_va = txd->llis_va; 357 struct pl08x_lli *llis_va = txd->llis_va;
358 struct lli *llis_bus = (struct lli *) txd->llis_bus; 358 struct pl08x_lli *llis_bus = (struct pl08x_lli *) txd->llis_bus;
359 u32 clli = readl(ch->base + PL080_CH_LLI); 359 u32 clli = readl(ch->base + PL080_CH_LLI);
360 360
361 /* First get the bytes in the current active LLI */ 361 /* First get the bytes in the current active LLI */
@@ -558,8 +558,8 @@ static int pl08x_fill_lli_for_desc(struct pl08x_driver_data *pl08x,
558 struct pl08x_txd *txd, int num_llis, int len, 558 struct pl08x_txd *txd, int num_llis, int len,
559 u32 cctl, u32 *remainder) 559 u32 cctl, u32 *remainder)
560{ 560{
561 struct lli *llis_va = txd->llis_va; 561 struct pl08x_lli *llis_va = txd->llis_va;
562 struct lli *llis_bus = (struct lli *) txd->llis_bus; 562 struct pl08x_lli *llis_bus = (struct pl08x_lli *) txd->llis_bus;
563 563
564 BUG_ON(num_llis >= MAX_NUM_TSFR_LLIS); 564 BUG_ON(num_llis >= MAX_NUM_TSFR_LLIS);
565 565
@@ -620,8 +620,8 @@ static int pl08x_fill_llis_for_desc(struct pl08x_driver_data *pl08x,
620 u32 cctl; 620 u32 cctl;
621 int max_bytes_per_lli; 621 int max_bytes_per_lli;
622 int total_bytes = 0; 622 int total_bytes = 0;
623 struct lli *llis_va; 623 struct pl08x_lli *llis_va;
624 struct lli *llis_bus; 624 struct pl08x_lli *llis_bus;
625 625
626 txd->llis_va = dma_pool_alloc(pl08x->pool, GFP_NOWAIT, 626 txd->llis_va = dma_pool_alloc(pl08x->pool, GFP_NOWAIT,
627 &txd->llis_bus); 627 &txd->llis_bus);