diff options
author | Javier Martin <javier.martin@vista-silicon.com> | 2012-03-22 09:54:13 -0400 |
---|---|---|
committer | Vinod Koul <vinod.koul@linux.intel.com> | 2012-03-26 02:01:32 -0400 |
commit | f9b283a6e41be584f4b1f4c6634625f41ff0c728 (patch) | |
tree | 1b51fcad35c28e4bcfceedd0fa15dae7ca92bea8 /drivers/dma/imx-dma.c | |
parent | cd5cf9da020293118800864641e09b71e23ba41c (diff) |
dmaengine: imx-dma: use 'dev_dbg' and 'dev_warn' for messages.
There were some 'pr_crit' and 'pr_debug' messages due to the
initial merge. Replace them by 'dev_dbg' and 'dev_warn' to be
consistent.
Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
Diffstat (limited to 'drivers/dma/imx-dma.c')
-rw-r--r-- | drivers/dma/imx-dma.c | 23 |
1 files changed, 12 insertions, 11 deletions
diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c index cdca95a5666c..307cd142f06a 100644 --- a/drivers/dma/imx-dma.c +++ b/drivers/dma/imx-dma.c | |||
@@ -227,8 +227,8 @@ static inline int imxdma_sg_next(struct imxdma_desc *d) | |||
227 | 227 | ||
228 | imx_dmav1_writel(imxdma, now, DMA_CNTR(imxdmac->channel)); | 228 | imx_dmav1_writel(imxdma, now, DMA_CNTR(imxdmac->channel)); |
229 | 229 | ||
230 | pr_debug("imxdma%d: next sg chunk dst 0x%08x, src 0x%08x, " | 230 | dev_dbg(imxdma->dev, " %s channel: %d dst 0x%08x, src 0x%08x, " |
231 | "size 0x%08x\n", imxdmac->channel, | 231 | "size 0x%08x\n", __func__, imxdmac->channel, |
232 | imx_dmav1_readl(imxdma, DMA_DAR(imxdmac->channel)), | 232 | imx_dmav1_readl(imxdma, DMA_DAR(imxdmac->channel)), |
233 | imx_dmav1_readl(imxdma, DMA_SAR(imxdmac->channel)), | 233 | imx_dmav1_readl(imxdma, DMA_SAR(imxdmac->channel)), |
234 | imx_dmav1_readl(imxdma, DMA_CNTR(imxdmac->channel))); | 234 | imx_dmav1_readl(imxdma, DMA_CNTR(imxdmac->channel))); |
@@ -243,7 +243,7 @@ static void imxdma_enable_hw(struct imxdma_desc *d) | |||
243 | int channel = imxdmac->channel; | 243 | int channel = imxdmac->channel; |
244 | unsigned long flags; | 244 | unsigned long flags; |
245 | 245 | ||
246 | pr_debug("imxdma%d: imx_dma_enable\n", channel); | 246 | dev_dbg(imxdma->dev, "%s channel %d\n", __func__, channel); |
247 | 247 | ||
248 | local_irq_save(flags); | 248 | local_irq_save(flags); |
249 | 249 | ||
@@ -274,7 +274,7 @@ static void imxdma_disable_hw(struct imxdma_channel *imxdmac) | |||
274 | int channel = imxdmac->channel; | 274 | int channel = imxdmac->channel; |
275 | unsigned long flags; | 275 | unsigned long flags; |
276 | 276 | ||
277 | pr_debug("imxdma%d: imx_dma_disable\n", channel); | 277 | dev_dbg(imxdma->dev, "%s channel %d\n", __func__, channel); |
278 | 278 | ||
279 | if (imxdma_hw_chain(imxdmac)) | 279 | if (imxdma_hw_chain(imxdmac)) |
280 | del_timer(&imxdmac->watchdog); | 280 | del_timer(&imxdmac->watchdog); |
@@ -298,7 +298,8 @@ static void imxdma_watchdog(unsigned long data) | |||
298 | 298 | ||
299 | /* Tasklet watchdog error handler */ | 299 | /* Tasklet watchdog error handler */ |
300 | tasklet_schedule(&imxdmac->dma_tasklet); | 300 | tasklet_schedule(&imxdmac->dma_tasklet); |
301 | pr_debug("imxdma%d: watchdog timeout!\n", imxdmac->channel); | 301 | dev_dbg(imxdma->dev, "channel %d: watchdog timeout!\n", |
302 | imxdmac->channel); | ||
302 | } | 303 | } |
303 | 304 | ||
304 | static irqreturn_t imxdma_err_handler(int irq, void *dev_id) | 305 | static irqreturn_t imxdma_err_handler(int irq, void *dev_id) |
@@ -426,8 +427,7 @@ static irqreturn_t dma_irq_handler(int irq, void *dev_id) | |||
426 | 427 | ||
427 | disr = imx_dmav1_readl(imxdma, DMA_DISR); | 428 | disr = imx_dmav1_readl(imxdma, DMA_DISR); |
428 | 429 | ||
429 | pr_debug("imxdma: dma_irq_handler called, disr=0x%08x\n", | 430 | dev_dbg(imxdma->dev, "%s called, disr=0x%08x\n", __func__, disr); |
430 | disr); | ||
431 | 431 | ||
432 | imx_dmav1_writel(imxdma, disr, DMA_DISR); | 432 | imx_dmav1_writel(imxdma, disr, DMA_DISR); |
433 | for (i = 0; i < IMX_DMA_CHANNELS; i++) { | 433 | for (i = 0; i < IMX_DMA_CHANNELS; i++) { |
@@ -875,14 +875,14 @@ static int __init imxdma_probe(struct platform_device *pdev) | |||
875 | if (cpu_is_mx1()) { | 875 | if (cpu_is_mx1()) { |
876 | ret = request_irq(MX1_DMA_INT, dma_irq_handler, 0, "DMA", imxdma); | 876 | ret = request_irq(MX1_DMA_INT, dma_irq_handler, 0, "DMA", imxdma); |
877 | if (ret) { | 877 | if (ret) { |
878 | pr_crit("Can't register IRQ for DMA\n"); | 878 | dev_warn(imxdma->dev, "Can't register IRQ for DMA\n"); |
879 | kfree(imxdma); | 879 | kfree(imxdma); |
880 | return ret; | 880 | return ret; |
881 | } | 881 | } |
882 | 882 | ||
883 | ret = request_irq(MX1_DMA_ERR, imxdma_err_handler, 0, "DMA", imxdma); | 883 | ret = request_irq(MX1_DMA_ERR, imxdma_err_handler, 0, "DMA", imxdma); |
884 | if (ret) { | 884 | if (ret) { |
885 | pr_crit("Can't register ERRIRQ for DMA\n"); | 885 | dev_warn(imxdma->dev, "Can't register ERRIRQ for DMA\n"); |
886 | free_irq(MX1_DMA_INT, NULL); | 886 | free_irq(MX1_DMA_INT, NULL); |
887 | kfree(imxdma); | 887 | kfree(imxdma); |
888 | return ret; | 888 | return ret; |
@@ -912,8 +912,9 @@ static int __init imxdma_probe(struct platform_device *pdev) | |||
912 | ret = request_irq(MX2x_INT_DMACH0 + i, | 912 | ret = request_irq(MX2x_INT_DMACH0 + i, |
913 | dma_irq_handler, 0, "DMA", imxdma); | 913 | dma_irq_handler, 0, "DMA", imxdma); |
914 | if (ret) { | 914 | if (ret) { |
915 | pr_crit("Can't register IRQ %d for DMA channel %d\n", | 915 | dev_warn(imxdma->dev, "Can't register IRQ %d " |
916 | MX2x_INT_DMACH0 + i, i); | 916 | "for DMA channel %d\n", |
917 | MX2x_INT_DMACH0 + i, i); | ||
917 | goto err_init; | 918 | goto err_init; |
918 | } | 919 | } |
919 | init_timer(&imxdmac->watchdog); | 920 | init_timer(&imxdmac->watchdog); |