diff options
author | Russell King - ARM Linux <linux@arm.linux.org.uk> | 2012-03-06 17:35:27 -0500 |
---|---|---|
committer | Vinod Koul <vinod.koul@linux.intel.com> | 2012-03-13 02:07:14 -0400 |
commit | 96a2af41c78b1fbb1f567a3486bdc63f7b31c5fd (patch) | |
tree | d977c6b2ff1a23dfd523e70315ebe976a3f3f079 /drivers/dma/fsldma.c | |
parent | f7fbce07c6ce26a25b4e0cb5f241c361fde87901 (diff) |
dmaengine: consolidate tx_status functions
Now that we have the completed cookie in the dma_chan structure, we
can consolidate the tx_status functions by providing a function to set
the txstate structure and returning the DMA status. We also provide
a separate helper to set the residue for cookies which are still in
progress.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Tested-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
[imx-sdma.c & mxs-dma.c]
Tested-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
Diffstat (limited to 'drivers/dma/fsldma.c')
-rw-r--r-- | drivers/dma/fsldma.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index f36e8b18cba2..2f6c806126e2 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c | |||
@@ -978,19 +978,14 @@ static enum dma_status fsl_tx_status(struct dma_chan *dchan, | |||
978 | struct dma_tx_state *txstate) | 978 | struct dma_tx_state *txstate) |
979 | { | 979 | { |
980 | struct fsldma_chan *chan = to_fsl_chan(dchan); | 980 | struct fsldma_chan *chan = to_fsl_chan(dchan); |
981 | dma_cookie_t last_complete; | 981 | enum dma_status ret; |
982 | dma_cookie_t last_used; | ||
983 | unsigned long flags; | 982 | unsigned long flags; |
984 | 983 | ||
985 | spin_lock_irqsave(&chan->desc_lock, flags); | 984 | spin_lock_irqsave(&chan->desc_lock, flags); |
986 | 985 | ret = dma_cookie_status(dchan, cookie, txstate); | |
987 | last_complete = dchan->completed_cookie; | ||
988 | last_used = dchan->cookie; | ||
989 | |||
990 | spin_unlock_irqrestore(&chan->desc_lock, flags); | 986 | spin_unlock_irqrestore(&chan->desc_lock, flags); |
991 | 987 | ||
992 | dma_set_tx_state(txstate, last_complete, last_used, 0); | 988 | return ret; |
993 | return dma_async_is_complete(cookie, last_complete, last_used); | ||
994 | } | 989 | } |
995 | 990 | ||
996 | /*----------------------------------------------------------------------------*/ | 991 | /*----------------------------------------------------------------------------*/ |