diff options
author | Vinod Koul <vinod.koul@intel.com> | 2013-11-16 01:24:17 -0500 |
---|---|---|
committer | Vinod Koul <vinod.koul@intel.com> | 2013-11-16 01:32:36 -0500 |
commit | df12a3178d340319b1955be6b973a4eb84aff754 (patch) | |
tree | 2b9c68f8a6c299d1e5a4026c60117b5c00d46008 /drivers/dma/dmatest.c | |
parent | 2f986ec6fa57a5dcf77f19f5f0d44b1f680a100f (diff) | |
parent | 82a1402eaee5dab1f3ab2d5aa4c316451374c5af (diff) |
Merge commit 'dmaengine-3.13-v2' of git://git.kernel.org/pub/scm/linux/kernel/git/djbw/dmaengine
Pull dmaengine changes from Dan
1/ Bartlomiej and Dan finalized a rework of the dma address unmap
implementation.
2/ In the course of testing 1/ a collection of enhancements to dmatest
fell out. Notably basic performance statistics, and fixed / enhanced
test control through new module parameters 'run', 'wait', 'noverify',
and 'verbose'. Thanks to Andriy and Linus for their review.
3/ Testing the raid related corner cases of 1/ triggered bugs in the
recently added 16-source operation support in the ioatdma driver.
4/ Some minor fixes / cleanups to mv_xor and ioatdma.
Conflicts:
drivers/dma/dmatest.c
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/dmatest.c')
-rw-r--r-- | drivers/dma/dmatest.c | 915 |
1 files changed, 351 insertions, 564 deletions
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index 59e287f56dfc..20f9a3aaf926 100644 --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c | |||
@@ -8,6 +8,8 @@ | |||
8 | * it under the terms of the GNU General Public License version 2 as | 8 | * it under the terms of the GNU General Public License version 2 as |
9 | * published by the Free Software Foundation. | 9 | * published by the Free Software Foundation. |
10 | */ | 10 | */ |
11 | #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt | ||
12 | |||
11 | #include <linux/delay.h> | 13 | #include <linux/delay.h> |
12 | #include <linux/dma-mapping.h> | 14 | #include <linux/dma-mapping.h> |
13 | #include <linux/dmaengine.h> | 15 | #include <linux/dmaengine.h> |
@@ -19,10 +21,6 @@ | |||
19 | #include <linux/random.h> | 21 | #include <linux/random.h> |
20 | #include <linux/slab.h> | 22 | #include <linux/slab.h> |
21 | #include <linux/wait.h> | 23 | #include <linux/wait.h> |
22 | #include <linux/ctype.h> | ||
23 | #include <linux/debugfs.h> | ||
24 | #include <linux/uaccess.h> | ||
25 | #include <linux/seq_file.h> | ||
26 | 24 | ||
27 | static unsigned int test_buf_size = 16384; | 25 | static unsigned int test_buf_size = 16384; |
28 | module_param(test_buf_size, uint, S_IRUGO | S_IWUSR); | 26 | module_param(test_buf_size, uint, S_IRUGO | S_IWUSR); |
@@ -68,92 +66,13 @@ module_param(timeout, uint, S_IRUGO | S_IWUSR); | |||
68 | MODULE_PARM_DESC(timeout, "Transfer Timeout in msec (default: 3000), " | 66 | MODULE_PARM_DESC(timeout, "Transfer Timeout in msec (default: 3000), " |
69 | "Pass -1 for infinite timeout"); | 67 | "Pass -1 for infinite timeout"); |
70 | 68 | ||
71 | /* Maximum amount of mismatched bytes in buffer to print */ | 69 | static bool noverify; |
72 | #define MAX_ERROR_COUNT 32 | 70 | module_param(noverify, bool, S_IRUGO | S_IWUSR); |
73 | 71 | MODULE_PARM_DESC(noverify, "Disable random data setup and verification"); | |
74 | /* | ||
75 | * Initialization patterns. All bytes in the source buffer has bit 7 | ||
76 | * set, all bytes in the destination buffer has bit 7 cleared. | ||
77 | * | ||
78 | * Bit 6 is set for all bytes which are to be copied by the DMA | ||
79 | * engine. Bit 5 is set for all bytes which are to be overwritten by | ||
80 | * the DMA engine. | ||
81 | * | ||
82 | * The remaining bits are the inverse of a counter which increments by | ||
83 | * one for each byte address. | ||
84 | */ | ||
85 | #define PATTERN_SRC 0x80 | ||
86 | #define PATTERN_DST 0x00 | ||
87 | #define PATTERN_COPY 0x40 | ||
88 | #define PATTERN_OVERWRITE 0x20 | ||
89 | #define PATTERN_COUNT_MASK 0x1f | ||
90 | |||
91 | enum dmatest_error_type { | ||
92 | DMATEST_ET_OK, | ||
93 | DMATEST_ET_MAP_SRC, | ||
94 | DMATEST_ET_MAP_DST, | ||
95 | DMATEST_ET_PREP, | ||
96 | DMATEST_ET_SUBMIT, | ||
97 | DMATEST_ET_TIMEOUT, | ||
98 | DMATEST_ET_DMA_ERROR, | ||
99 | DMATEST_ET_DMA_IN_PROGRESS, | ||
100 | DMATEST_ET_VERIFY, | ||
101 | DMATEST_ET_VERIFY_BUF, | ||
102 | }; | ||
103 | |||
104 | struct dmatest_verify_buffer { | ||
105 | unsigned int index; | ||
106 | u8 expected; | ||
107 | u8 actual; | ||
108 | }; | ||
109 | |||
110 | struct dmatest_verify_result { | ||
111 | unsigned int error_count; | ||
112 | struct dmatest_verify_buffer data[MAX_ERROR_COUNT]; | ||
113 | u8 pattern; | ||
114 | bool is_srcbuf; | ||
115 | }; | ||
116 | |||
117 | struct dmatest_thread_result { | ||
118 | struct list_head node; | ||
119 | unsigned int n; | ||
120 | unsigned int src_off; | ||
121 | unsigned int dst_off; | ||
122 | unsigned int len; | ||
123 | enum dmatest_error_type type; | ||
124 | union { | ||
125 | unsigned long data; | ||
126 | dma_cookie_t cookie; | ||
127 | enum dma_status status; | ||
128 | int error; | ||
129 | struct dmatest_verify_result *vr; | ||
130 | }; | ||
131 | }; | ||
132 | |||
133 | struct dmatest_result { | ||
134 | struct list_head node; | ||
135 | char *name; | ||
136 | struct list_head results; | ||
137 | }; | ||
138 | |||
139 | struct dmatest_info; | ||
140 | |||
141 | struct dmatest_thread { | ||
142 | struct list_head node; | ||
143 | struct dmatest_info *info; | ||
144 | struct task_struct *task; | ||
145 | struct dma_chan *chan; | ||
146 | u8 **srcs; | ||
147 | u8 **dsts; | ||
148 | enum dma_transaction_type type; | ||
149 | bool done; | ||
150 | }; | ||
151 | 72 | ||
152 | struct dmatest_chan { | 73 | static bool verbose; |
153 | struct list_head node; | 74 | module_param(verbose, bool, S_IRUGO | S_IWUSR); |
154 | struct dma_chan *chan; | 75 | MODULE_PARM_DESC(verbose, "Enable \"success\" result messages (default: off)"); |
155 | struct list_head threads; | ||
156 | }; | ||
157 | 76 | ||
158 | /** | 77 | /** |
159 | * struct dmatest_params - test parameters. | 78 | * struct dmatest_params - test parameters. |
@@ -177,6 +96,7 @@ struct dmatest_params { | |||
177 | unsigned int xor_sources; | 96 | unsigned int xor_sources; |
178 | unsigned int pq_sources; | 97 | unsigned int pq_sources; |
179 | int timeout; | 98 | int timeout; |
99 | bool noverify; | ||
180 | }; | 100 | }; |
181 | 101 | ||
182 | /** | 102 | /** |
@@ -184,7 +104,7 @@ struct dmatest_params { | |||
184 | * @params: test parameters | 104 | * @params: test parameters |
185 | * @lock: access protection to the fields of this structure | 105 | * @lock: access protection to the fields of this structure |
186 | */ | 106 | */ |
187 | struct dmatest_info { | 107 | static struct dmatest_info { |
188 | /* Test parameters */ | 108 | /* Test parameters */ |
189 | struct dmatest_params params; | 109 | struct dmatest_params params; |
190 | 110 | ||
@@ -192,16 +112,95 @@ struct dmatest_info { | |||
192 | struct list_head channels; | 112 | struct list_head channels; |
193 | unsigned int nr_channels; | 113 | unsigned int nr_channels; |
194 | struct mutex lock; | 114 | struct mutex lock; |
115 | bool did_init; | ||
116 | } test_info = { | ||
117 | .channels = LIST_HEAD_INIT(test_info.channels), | ||
118 | .lock = __MUTEX_INITIALIZER(test_info.lock), | ||
119 | }; | ||
120 | |||
121 | static int dmatest_run_set(const char *val, const struct kernel_param *kp); | ||
122 | static int dmatest_run_get(char *val, const struct kernel_param *kp); | ||
123 | static struct kernel_param_ops run_ops = { | ||
124 | .set = dmatest_run_set, | ||
125 | .get = dmatest_run_get, | ||
126 | }; | ||
127 | static bool dmatest_run; | ||
128 | module_param_cb(run, &run_ops, &dmatest_run, S_IRUGO | S_IWUSR); | ||
129 | MODULE_PARM_DESC(run, "Run the test (default: false)"); | ||
130 | |||
131 | /* Maximum amount of mismatched bytes in buffer to print */ | ||
132 | #define MAX_ERROR_COUNT 32 | ||
133 | |||
134 | /* | ||
135 | * Initialization patterns. All bytes in the source buffer has bit 7 | ||
136 | * set, all bytes in the destination buffer has bit 7 cleared. | ||
137 | * | ||
138 | * Bit 6 is set for all bytes which are to be copied by the DMA | ||
139 | * engine. Bit 5 is set for all bytes which are to be overwritten by | ||
140 | * the DMA engine. | ||
141 | * | ||
142 | * The remaining bits are the inverse of a counter which increments by | ||
143 | * one for each byte address. | ||
144 | */ | ||
145 | #define PATTERN_SRC 0x80 | ||
146 | #define PATTERN_DST 0x00 | ||
147 | #define PATTERN_COPY 0x40 | ||
148 | #define PATTERN_OVERWRITE 0x20 | ||
149 | #define PATTERN_COUNT_MASK 0x1f | ||
195 | 150 | ||
196 | /* debugfs related stuff */ | 151 | struct dmatest_thread { |
197 | struct dentry *root; | 152 | struct list_head node; |
153 | struct dmatest_info *info; | ||
154 | struct task_struct *task; | ||
155 | struct dma_chan *chan; | ||
156 | u8 **srcs; | ||
157 | u8 **dsts; | ||
158 | enum dma_transaction_type type; | ||
159 | bool done; | ||
160 | }; | ||
198 | 161 | ||
199 | /* Test results */ | 162 | struct dmatest_chan { |
200 | struct list_head results; | 163 | struct list_head node; |
201 | struct mutex results_lock; | 164 | struct dma_chan *chan; |
165 | struct list_head threads; | ||
202 | }; | 166 | }; |
203 | 167 | ||
204 | static struct dmatest_info test_info; | 168 | static DECLARE_WAIT_QUEUE_HEAD(thread_wait); |
169 | static bool wait; | ||
170 | |||
171 | static bool is_threaded_test_run(struct dmatest_info *info) | ||
172 | { | ||
173 | struct dmatest_chan *dtc; | ||
174 | |||
175 | list_for_each_entry(dtc, &info->channels, node) { | ||
176 | struct dmatest_thread *thread; | ||
177 | |||
178 | list_for_each_entry(thread, &dtc->threads, node) { | ||
179 | if (!thread->done) | ||
180 | return true; | ||
181 | } | ||
182 | } | ||
183 | |||
184 | return false; | ||
185 | } | ||
186 | |||
187 | static int dmatest_wait_get(char *val, const struct kernel_param *kp) | ||
188 | { | ||
189 | struct dmatest_info *info = &test_info; | ||
190 | struct dmatest_params *params = &info->params; | ||
191 | |||
192 | if (params->iterations) | ||
193 | wait_event(thread_wait, !is_threaded_test_run(info)); | ||
194 | wait = true; | ||
195 | return param_get_bool(val, kp); | ||
196 | } | ||
197 | |||
198 | static struct kernel_param_ops wait_ops = { | ||
199 | .get = dmatest_wait_get, | ||
200 | .set = param_set_bool, | ||
201 | }; | ||
202 | module_param_cb(wait, &wait_ops, &wait, S_IRUGO); | ||
203 | MODULE_PARM_DESC(wait, "Wait for tests to complete (default: false)"); | ||
205 | 204 | ||
206 | static bool dmatest_match_channel(struct dmatest_params *params, | 205 | static bool dmatest_match_channel(struct dmatest_params *params, |
207 | struct dma_chan *chan) | 206 | struct dma_chan *chan) |
@@ -223,7 +222,7 @@ static unsigned long dmatest_random(void) | |||
223 | { | 222 | { |
224 | unsigned long buf; | 223 | unsigned long buf; |
225 | 224 | ||
226 | get_random_bytes(&buf, sizeof(buf)); | 225 | prandom_bytes(&buf, sizeof(buf)); |
227 | return buf; | 226 | return buf; |
228 | } | 227 | } |
229 | 228 | ||
@@ -262,9 +261,31 @@ static void dmatest_init_dsts(u8 **bufs, unsigned int start, unsigned int len, | |||
262 | } | 261 | } |
263 | } | 262 | } |
264 | 263 | ||
265 | static unsigned int dmatest_verify(struct dmatest_verify_result *vr, u8 **bufs, | 264 | static void dmatest_mismatch(u8 actual, u8 pattern, unsigned int index, |
266 | unsigned int start, unsigned int end, unsigned int counter, | 265 | unsigned int counter, bool is_srcbuf) |
267 | u8 pattern, bool is_srcbuf) | 266 | { |
267 | u8 diff = actual ^ pattern; | ||
268 | u8 expected = pattern | (~counter & PATTERN_COUNT_MASK); | ||
269 | const char *thread_name = current->comm; | ||
270 | |||
271 | if (is_srcbuf) | ||
272 | pr_warn("%s: srcbuf[0x%x] overwritten! Expected %02x, got %02x\n", | ||
273 | thread_name, index, expected, actual); | ||
274 | else if ((pattern & PATTERN_COPY) | ||
275 | && (diff & (PATTERN_COPY | PATTERN_OVERWRITE))) | ||
276 | pr_warn("%s: dstbuf[0x%x] not copied! Expected %02x, got %02x\n", | ||
277 | thread_name, index, expected, actual); | ||
278 | else if (diff & PATTERN_SRC) | ||
279 | pr_warn("%s: dstbuf[0x%x] was copied! Expected %02x, got %02x\n", | ||
280 | thread_name, index, expected, actual); | ||
281 | else | ||
282 | pr_warn("%s: dstbuf[0x%x] mismatch! Expected %02x, got %02x\n", | ||
283 | thread_name, index, expected, actual); | ||
284 | } | ||
285 | |||
286 | static unsigned int dmatest_verify(u8 **bufs, unsigned int start, | ||
287 | unsigned int end, unsigned int counter, u8 pattern, | ||
288 | bool is_srcbuf) | ||
268 | { | 289 | { |
269 | unsigned int i; | 290 | unsigned int i; |
270 | unsigned int error_count = 0; | 291 | unsigned int error_count = 0; |
@@ -272,7 +293,6 @@ static unsigned int dmatest_verify(struct dmatest_verify_result *vr, u8 **bufs, | |||
272 | u8 expected; | 293 | u8 expected; |
273 | u8 *buf; | 294 | u8 *buf; |
274 | unsigned int counter_orig = counter; | 295 | unsigned int counter_orig = counter; |
275 | struct dmatest_verify_buffer *vb; | ||
276 | 296 | ||
277 | for (; (buf = *bufs); bufs++) { | 297 | for (; (buf = *bufs); bufs++) { |
278 | counter = counter_orig; | 298 | counter = counter_orig; |
@@ -280,12 +300,9 @@ static unsigned int dmatest_verify(struct dmatest_verify_result *vr, u8 **bufs, | |||
280 | actual = buf[i]; | 300 | actual = buf[i]; |
281 | expected = pattern | (~counter & PATTERN_COUNT_MASK); | 301 | expected = pattern | (~counter & PATTERN_COUNT_MASK); |
282 | if (actual != expected) { | 302 | if (actual != expected) { |
283 | if (error_count < MAX_ERROR_COUNT && vr) { | 303 | if (error_count < MAX_ERROR_COUNT) |
284 | vb = &vr->data[error_count]; | 304 | dmatest_mismatch(actual, pattern, i, |
285 | vb->index = i; | 305 | counter, is_srcbuf); |
286 | vb->expected = expected; | ||
287 | vb->actual = actual; | ||
288 | } | ||
289 | error_count++; | 306 | error_count++; |
290 | } | 307 | } |
291 | counter++; | 308 | counter++; |
@@ -293,7 +310,7 @@ static unsigned int dmatest_verify(struct dmatest_verify_result *vr, u8 **bufs, | |||
293 | } | 310 | } |
294 | 311 | ||
295 | if (error_count > MAX_ERROR_COUNT) | 312 | if (error_count > MAX_ERROR_COUNT) |
296 | pr_warning("%s: %u errors suppressed\n", | 313 | pr_warn("%s: %u errors suppressed\n", |
297 | current->comm, error_count - MAX_ERROR_COUNT); | 314 | current->comm, error_count - MAX_ERROR_COUNT); |
298 | 315 | ||
299 | return error_count; | 316 | return error_count; |
@@ -313,20 +330,6 @@ static void dmatest_callback(void *arg) | |||
313 | wake_up_all(done->wait); | 330 | wake_up_all(done->wait); |
314 | } | 331 | } |
315 | 332 | ||
316 | static inline void unmap_src(struct device *dev, dma_addr_t *addr, size_t len, | ||
317 | unsigned int count) | ||
318 | { | ||
319 | while (count--) | ||
320 | dma_unmap_single(dev, addr[count], len, DMA_TO_DEVICE); | ||
321 | } | ||
322 | |||
323 | static inline void unmap_dst(struct device *dev, dma_addr_t *addr, size_t len, | ||
324 | unsigned int count) | ||
325 | { | ||
326 | while (count--) | ||
327 | dma_unmap_single(dev, addr[count], len, DMA_BIDIRECTIONAL); | ||
328 | } | ||
329 | |||
330 | static unsigned int min_odd(unsigned int x, unsigned int y) | 333 | static unsigned int min_odd(unsigned int x, unsigned int y) |
331 | { | 334 | { |
332 | unsigned int val = min(x, y); | 335 | unsigned int val = min(x, y); |
@@ -334,172 +337,49 @@ static unsigned int min_odd(unsigned int x, unsigned int y) | |||
334 | return val % 2 ? val : val - 1; | 337 | return val % 2 ? val : val - 1; |
335 | } | 338 | } |
336 | 339 | ||
337 | static char *verify_result_get_one(struct dmatest_verify_result *vr, | 340 | static void result(const char *err, unsigned int n, unsigned int src_off, |
338 | unsigned int i) | 341 | unsigned int dst_off, unsigned int len, unsigned long data) |
339 | { | 342 | { |
340 | struct dmatest_verify_buffer *vb = &vr->data[i]; | 343 | pr_info("%s: result #%u: '%s' with src_off=0x%x dst_off=0x%x len=0x%x (%lu)", |
341 | u8 diff = vb->actual ^ vr->pattern; | 344 | current->comm, n, err, src_off, dst_off, len, data); |
342 | static char buf[512]; | ||
343 | char *msg; | ||
344 | |||
345 | if (vr->is_srcbuf) | ||
346 | msg = "srcbuf overwritten!"; | ||
347 | else if ((vr->pattern & PATTERN_COPY) | ||
348 | && (diff & (PATTERN_COPY | PATTERN_OVERWRITE))) | ||
349 | msg = "dstbuf not copied!"; | ||
350 | else if (diff & PATTERN_SRC) | ||
351 | msg = "dstbuf was copied!"; | ||
352 | else | ||
353 | msg = "dstbuf mismatch!"; | ||
354 | |||
355 | snprintf(buf, sizeof(buf) - 1, "%s [0x%x] Expected %02x, got %02x", msg, | ||
356 | vb->index, vb->expected, vb->actual); | ||
357 | |||
358 | return buf; | ||
359 | } | 345 | } |
360 | 346 | ||
361 | static char *thread_result_get(const char *name, | 347 | static void dbg_result(const char *err, unsigned int n, unsigned int src_off, |
362 | struct dmatest_thread_result *tr) | 348 | unsigned int dst_off, unsigned int len, |
349 | unsigned long data) | ||
363 | { | 350 | { |
364 | static const char * const messages[] = { | 351 | pr_debug("%s: result #%u: '%s' with src_off=0x%x dst_off=0x%x len=0x%x (%lu)", |
365 | [DMATEST_ET_OK] = "No errors", | 352 | current->comm, n, err, src_off, dst_off, len, data); |
366 | [DMATEST_ET_MAP_SRC] = "src mapping error", | ||
367 | [DMATEST_ET_MAP_DST] = "dst mapping error", | ||
368 | [DMATEST_ET_PREP] = "prep error", | ||
369 | [DMATEST_ET_SUBMIT] = "submit error", | ||
370 | [DMATEST_ET_TIMEOUT] = "test timed out", | ||
371 | [DMATEST_ET_DMA_ERROR] = | ||
372 | "got completion callback (DMA_ERROR)", | ||
373 | [DMATEST_ET_DMA_IN_PROGRESS] = | ||
374 | "got completion callback (DMA_IN_PROGRESS)", | ||
375 | [DMATEST_ET_VERIFY] = "errors", | ||
376 | [DMATEST_ET_VERIFY_BUF] = "verify errors", | ||
377 | }; | ||
378 | static char buf[512]; | ||
379 | |||
380 | snprintf(buf, sizeof(buf) - 1, | ||
381 | "%s: #%u: %s with src_off=0x%x ""dst_off=0x%x len=0x%x (%lu)", | ||
382 | name, tr->n, messages[tr->type], tr->src_off, tr->dst_off, | ||
383 | tr->len, tr->data); | ||
384 | |||
385 | return buf; | ||
386 | } | 353 | } |
387 | 354 | ||
388 | static int thread_result_add(struct dmatest_info *info, | 355 | #define verbose_result(err, n, src_off, dst_off, len, data) ({ \ |
389 | struct dmatest_result *r, enum dmatest_error_type type, | 356 | if (verbose) \ |
390 | unsigned int n, unsigned int src_off, unsigned int dst_off, | 357 | result(err, n, src_off, dst_off, len, data); \ |
391 | unsigned int len, unsigned long data) | 358 | else \ |
392 | { | 359 | dbg_result(err, n, src_off, dst_off, len, data); \ |
393 | struct dmatest_thread_result *tr; | 360 | }) |
394 | |||
395 | tr = kzalloc(sizeof(*tr), GFP_KERNEL); | ||
396 | if (!tr) | ||
397 | return -ENOMEM; | ||
398 | |||
399 | tr->type = type; | ||
400 | tr->n = n; | ||
401 | tr->src_off = src_off; | ||
402 | tr->dst_off = dst_off; | ||
403 | tr->len = len; | ||
404 | tr->data = data; | ||
405 | 361 | ||
406 | mutex_lock(&info->results_lock); | 362 | static unsigned long long dmatest_persec(s64 runtime, unsigned int val) |
407 | list_add_tail(&tr->node, &r->results); | ||
408 | mutex_unlock(&info->results_lock); | ||
409 | |||
410 | if (tr->type == DMATEST_ET_OK) | ||
411 | pr_debug("%s\n", thread_result_get(r->name, tr)); | ||
412 | else | ||
413 | pr_warn("%s\n", thread_result_get(r->name, tr)); | ||
414 | |||
415 | return 0; | ||
416 | } | ||
417 | |||
418 | static unsigned int verify_result_add(struct dmatest_info *info, | ||
419 | struct dmatest_result *r, unsigned int n, | ||
420 | unsigned int src_off, unsigned int dst_off, unsigned int len, | ||
421 | u8 **bufs, int whence, unsigned int counter, u8 pattern, | ||
422 | bool is_srcbuf) | ||
423 | { | 363 | { |
424 | struct dmatest_verify_result *vr; | 364 | unsigned long long per_sec = 1000000; |
425 | unsigned int error_count; | ||
426 | unsigned int buf_off = is_srcbuf ? src_off : dst_off; | ||
427 | unsigned int start, end; | ||
428 | |||
429 | if (whence < 0) { | ||
430 | start = 0; | ||
431 | end = buf_off; | ||
432 | } else if (whence > 0) { | ||
433 | start = buf_off + len; | ||
434 | end = info->params.buf_size; | ||
435 | } else { | ||
436 | start = buf_off; | ||
437 | end = buf_off + len; | ||
438 | } | ||
439 | 365 | ||
440 | vr = kmalloc(sizeof(*vr), GFP_KERNEL); | 366 | if (runtime <= 0) |
441 | if (!vr) { | 367 | return 0; |
442 | pr_warn("dmatest: No memory to store verify result\n"); | ||
443 | return dmatest_verify(NULL, bufs, start, end, counter, pattern, | ||
444 | is_srcbuf); | ||
445 | } | ||
446 | |||
447 | vr->pattern = pattern; | ||
448 | vr->is_srcbuf = is_srcbuf; | ||
449 | |||
450 | error_count = dmatest_verify(vr, bufs, start, end, counter, pattern, | ||
451 | is_srcbuf); | ||
452 | if (error_count) { | ||
453 | vr->error_count = error_count; | ||
454 | thread_result_add(info, r, DMATEST_ET_VERIFY_BUF, n, src_off, | ||
455 | dst_off, len, (unsigned long)vr); | ||
456 | return error_count; | ||
457 | } | ||
458 | |||
459 | kfree(vr); | ||
460 | return 0; | ||
461 | } | ||
462 | |||
463 | static void result_free(struct dmatest_info *info, const char *name) | ||
464 | { | ||
465 | struct dmatest_result *r, *_r; | ||
466 | |||
467 | mutex_lock(&info->results_lock); | ||
468 | list_for_each_entry_safe(r, _r, &info->results, node) { | ||
469 | struct dmatest_thread_result *tr, *_tr; | ||
470 | |||
471 | if (name && strcmp(r->name, name)) | ||
472 | continue; | ||
473 | |||
474 | list_for_each_entry_safe(tr, _tr, &r->results, node) { | ||
475 | if (tr->type == DMATEST_ET_VERIFY_BUF) | ||
476 | kfree(tr->vr); | ||
477 | list_del(&tr->node); | ||
478 | kfree(tr); | ||
479 | } | ||
480 | 368 | ||
481 | kfree(r->name); | 369 | /* drop precision until runtime is 32-bits */ |
482 | list_del(&r->node); | 370 | while (runtime > UINT_MAX) { |
483 | kfree(r); | 371 | runtime >>= 1; |
372 | per_sec <<= 1; | ||
484 | } | 373 | } |
485 | 374 | ||
486 | mutex_unlock(&info->results_lock); | 375 | per_sec *= val; |
376 | do_div(per_sec, runtime); | ||
377 | return per_sec; | ||
487 | } | 378 | } |
488 | 379 | ||
489 | static struct dmatest_result *result_init(struct dmatest_info *info, | 380 | static unsigned long long dmatest_KBs(s64 runtime, unsigned long long len) |
490 | const char *name) | ||
491 | { | 381 | { |
492 | struct dmatest_result *r; | 382 | return dmatest_persec(runtime, len >> 10); |
493 | |||
494 | r = kzalloc(sizeof(*r), GFP_KERNEL); | ||
495 | if (r) { | ||
496 | r->name = kstrdup(name, GFP_KERNEL); | ||
497 | INIT_LIST_HEAD(&r->results); | ||
498 | mutex_lock(&info->results_lock); | ||
499 | list_add_tail(&r->node, &info->results); | ||
500 | mutex_unlock(&info->results_lock); | ||
501 | } | ||
502 | return r; | ||
503 | } | 383 | } |
504 | 384 | ||
505 | /* | 385 | /* |
@@ -525,7 +405,6 @@ static int dmatest_func(void *data) | |||
525 | struct dmatest_params *params; | 405 | struct dmatest_params *params; |
526 | struct dma_chan *chan; | 406 | struct dma_chan *chan; |
527 | struct dma_device *dev; | 407 | struct dma_device *dev; |
528 | const char *thread_name; | ||
529 | unsigned int src_off, dst_off, len; | 408 | unsigned int src_off, dst_off, len; |
530 | unsigned int error_count; | 409 | unsigned int error_count; |
531 | unsigned int failed_tests = 0; | 410 | unsigned int failed_tests = 0; |
@@ -538,9 +417,10 @@ static int dmatest_func(void *data) | |||
538 | int src_cnt; | 417 | int src_cnt; |
539 | int dst_cnt; | 418 | int dst_cnt; |
540 | int i; | 419 | int i; |
541 | struct dmatest_result *result; | 420 | ktime_t ktime; |
421 | s64 runtime = 0; | ||
422 | unsigned long long total_len = 0; | ||
542 | 423 | ||
543 | thread_name = current->comm; | ||
544 | set_freezable(); | 424 | set_freezable(); |
545 | 425 | ||
546 | ret = -ENOMEM; | 426 | ret = -ENOMEM; |
@@ -570,10 +450,6 @@ static int dmatest_func(void *data) | |||
570 | } else | 450 | } else |
571 | goto err_thread_type; | 451 | goto err_thread_type; |
572 | 452 | ||
573 | result = result_init(info, thread_name); | ||
574 | if (!result) | ||
575 | goto err_srcs; | ||
576 | |||
577 | thread->srcs = kcalloc(src_cnt+1, sizeof(u8 *), GFP_KERNEL); | 453 | thread->srcs = kcalloc(src_cnt+1, sizeof(u8 *), GFP_KERNEL); |
578 | if (!thread->srcs) | 454 | if (!thread->srcs) |
579 | goto err_srcs; | 455 | goto err_srcs; |
@@ -597,17 +473,17 @@ static int dmatest_func(void *data) | |||
597 | set_user_nice(current, 10); | 473 | set_user_nice(current, 10); |
598 | 474 | ||
599 | /* | 475 | /* |
600 | * src buffers are freed by the DMAEngine code with dma_unmap_single() | 476 | * src and dst buffers are freed by ourselves below |
601 | * dst buffers are freed by ourselves below | ||
602 | */ | 477 | */ |
603 | flags = DMA_CTRL_ACK | DMA_PREP_INTERRUPT | 478 | flags = DMA_CTRL_ACK | DMA_PREP_INTERRUPT; |
604 | | DMA_COMPL_SKIP_DEST_UNMAP | DMA_COMPL_SRC_UNMAP_SINGLE; | ||
605 | 479 | ||
480 | ktime = ktime_get(); | ||
606 | while (!kthread_should_stop() | 481 | while (!kthread_should_stop() |
607 | && !(params->iterations && total_tests >= params->iterations)) { | 482 | && !(params->iterations && total_tests >= params->iterations)) { |
608 | struct dma_async_tx_descriptor *tx = NULL; | 483 | struct dma_async_tx_descriptor *tx = NULL; |
609 | dma_addr_t dma_srcs[src_cnt]; | 484 | struct dmaengine_unmap_data *um; |
610 | dma_addr_t dma_dsts[dst_cnt]; | 485 | dma_addr_t srcs[src_cnt]; |
486 | dma_addr_t *dsts; | ||
611 | u8 align = 0; | 487 | u8 align = 0; |
612 | 488 | ||
613 | total_tests++; | 489 | total_tests++; |
@@ -626,81 +502,103 @@ static int dmatest_func(void *data) | |||
626 | break; | 502 | break; |
627 | } | 503 | } |
628 | 504 | ||
629 | len = dmatest_random() % params->buf_size + 1; | 505 | if (params->noverify) { |
506 | len = params->buf_size; | ||
507 | src_off = 0; | ||
508 | dst_off = 0; | ||
509 | } else { | ||
510 | len = dmatest_random() % params->buf_size + 1; | ||
511 | len = (len >> align) << align; | ||
512 | if (!len) | ||
513 | len = 1 << align; | ||
514 | src_off = dmatest_random() % (params->buf_size - len + 1); | ||
515 | dst_off = dmatest_random() % (params->buf_size - len + 1); | ||
516 | |||
517 | src_off = (src_off >> align) << align; | ||
518 | dst_off = (dst_off >> align) << align; | ||
519 | |||
520 | dmatest_init_srcs(thread->srcs, src_off, len, | ||
521 | params->buf_size); | ||
522 | dmatest_init_dsts(thread->dsts, dst_off, len, | ||
523 | params->buf_size); | ||
524 | } | ||
525 | |||
630 | len = (len >> align) << align; | 526 | len = (len >> align) << align; |
631 | if (!len) | 527 | if (!len) |
632 | len = 1 << align; | 528 | len = 1 << align; |
633 | src_off = dmatest_random() % (params->buf_size - len + 1); | 529 | total_len += len; |
634 | dst_off = dmatest_random() % (params->buf_size - len + 1); | ||
635 | 530 | ||
636 | src_off = (src_off >> align) << align; | 531 | um = dmaengine_get_unmap_data(dev->dev, src_cnt+dst_cnt, |
637 | dst_off = (dst_off >> align) << align; | 532 | GFP_KERNEL); |
638 | 533 | if (!um) { | |
639 | dmatest_init_srcs(thread->srcs, src_off, len, params->buf_size); | 534 | failed_tests++; |
640 | dmatest_init_dsts(thread->dsts, dst_off, len, params->buf_size); | 535 | result("unmap data NULL", total_tests, |
536 | src_off, dst_off, len, ret); | ||
537 | continue; | ||
538 | } | ||
641 | 539 | ||
540 | um->len = params->buf_size; | ||
642 | for (i = 0; i < src_cnt; i++) { | 541 | for (i = 0; i < src_cnt; i++) { |
643 | u8 *buf = thread->srcs[i] + src_off; | 542 | unsigned long buf = (unsigned long) thread->srcs[i]; |
644 | 543 | struct page *pg = virt_to_page(buf); | |
645 | dma_srcs[i] = dma_map_single(dev->dev, buf, len, | 544 | unsigned pg_off = buf & ~PAGE_MASK; |
646 | DMA_TO_DEVICE); | 545 | |
647 | ret = dma_mapping_error(dev->dev, dma_srcs[i]); | 546 | um->addr[i] = dma_map_page(dev->dev, pg, pg_off, |
547 | um->len, DMA_TO_DEVICE); | ||
548 | srcs[i] = um->addr[i] + src_off; | ||
549 | ret = dma_mapping_error(dev->dev, um->addr[i]); | ||
648 | if (ret) { | 550 | if (ret) { |
649 | unmap_src(dev->dev, dma_srcs, len, i); | 551 | dmaengine_unmap_put(um); |
650 | thread_result_add(info, result, | 552 | result("src mapping error", total_tests, |
651 | DMATEST_ET_MAP_SRC, | 553 | src_off, dst_off, len, ret); |
652 | total_tests, src_off, dst_off, | ||
653 | len, ret); | ||
654 | failed_tests++; | 554 | failed_tests++; |
655 | continue; | 555 | continue; |
656 | } | 556 | } |
557 | um->to_cnt++; | ||
657 | } | 558 | } |
658 | /* map with DMA_BIDIRECTIONAL to force writeback/invalidate */ | 559 | /* map with DMA_BIDIRECTIONAL to force writeback/invalidate */ |
560 | dsts = &um->addr[src_cnt]; | ||
659 | for (i = 0; i < dst_cnt; i++) { | 561 | for (i = 0; i < dst_cnt; i++) { |
660 | dma_dsts[i] = dma_map_single(dev->dev, thread->dsts[i], | 562 | unsigned long buf = (unsigned long) thread->dsts[i]; |
661 | params->buf_size, | 563 | struct page *pg = virt_to_page(buf); |
662 | DMA_BIDIRECTIONAL); | 564 | unsigned pg_off = buf & ~PAGE_MASK; |
663 | ret = dma_mapping_error(dev->dev, dma_dsts[i]); | 565 | |
566 | dsts[i] = dma_map_page(dev->dev, pg, pg_off, um->len, | ||
567 | DMA_BIDIRECTIONAL); | ||
568 | ret = dma_mapping_error(dev->dev, dsts[i]); | ||
664 | if (ret) { | 569 | if (ret) { |
665 | unmap_src(dev->dev, dma_srcs, len, src_cnt); | 570 | dmaengine_unmap_put(um); |
666 | unmap_dst(dev->dev, dma_dsts, params->buf_size, | 571 | result("dst mapping error", total_tests, |
667 | i); | 572 | src_off, dst_off, len, ret); |
668 | thread_result_add(info, result, | ||
669 | DMATEST_ET_MAP_DST, | ||
670 | total_tests, src_off, dst_off, | ||
671 | len, ret); | ||
672 | failed_tests++; | 573 | failed_tests++; |
673 | continue; | 574 | continue; |
674 | } | 575 | } |
576 | um->bidi_cnt++; | ||
675 | } | 577 | } |
676 | 578 | ||
677 | if (thread->type == DMA_MEMCPY) | 579 | if (thread->type == DMA_MEMCPY) |
678 | tx = dev->device_prep_dma_memcpy(chan, | 580 | tx = dev->device_prep_dma_memcpy(chan, |
679 | dma_dsts[0] + dst_off, | 581 | dsts[0] + dst_off, |
680 | dma_srcs[0], len, | 582 | srcs[0], len, flags); |
681 | flags); | ||
682 | else if (thread->type == DMA_XOR) | 583 | else if (thread->type == DMA_XOR) |
683 | tx = dev->device_prep_dma_xor(chan, | 584 | tx = dev->device_prep_dma_xor(chan, |
684 | dma_dsts[0] + dst_off, | 585 | dsts[0] + dst_off, |
685 | dma_srcs, src_cnt, | 586 | srcs, src_cnt, |
686 | len, flags); | 587 | len, flags); |
687 | else if (thread->type == DMA_PQ) { | 588 | else if (thread->type == DMA_PQ) { |
688 | dma_addr_t dma_pq[dst_cnt]; | 589 | dma_addr_t dma_pq[dst_cnt]; |
689 | 590 | ||
690 | for (i = 0; i < dst_cnt; i++) | 591 | for (i = 0; i < dst_cnt; i++) |
691 | dma_pq[i] = dma_dsts[i] + dst_off; | 592 | dma_pq[i] = dsts[i] + dst_off; |
692 | tx = dev->device_prep_dma_pq(chan, dma_pq, dma_srcs, | 593 | tx = dev->device_prep_dma_pq(chan, dma_pq, srcs, |
693 | src_cnt, pq_coefs, | 594 | src_cnt, pq_coefs, |
694 | len, flags); | 595 | len, flags); |
695 | } | 596 | } |
696 | 597 | ||
697 | if (!tx) { | 598 | if (!tx) { |
698 | unmap_src(dev->dev, dma_srcs, len, src_cnt); | 599 | dmaengine_unmap_put(um); |
699 | unmap_dst(dev->dev, dma_dsts, params->buf_size, | 600 | result("prep error", total_tests, src_off, |
700 | dst_cnt); | 601 | dst_off, len, ret); |
701 | thread_result_add(info, result, DMATEST_ET_PREP, | ||
702 | total_tests, src_off, dst_off, | ||
703 | len, 0); | ||
704 | msleep(100); | 602 | msleep(100); |
705 | failed_tests++; | 603 | failed_tests++; |
706 | continue; | 604 | continue; |
@@ -712,9 +610,9 @@ static int dmatest_func(void *data) | |||
712 | cookie = tx->tx_submit(tx); | 610 | cookie = tx->tx_submit(tx); |
713 | 611 | ||
714 | if (dma_submit_error(cookie)) { | 612 | if (dma_submit_error(cookie)) { |
715 | thread_result_add(info, result, DMATEST_ET_SUBMIT, | 613 | dmaengine_unmap_put(um); |
716 | total_tests, src_off, dst_off, | 614 | result("submit error", total_tests, src_off, |
717 | len, cookie); | 615 | dst_off, len, ret); |
718 | msleep(100); | 616 | msleep(100); |
719 | failed_tests++; | 617 | failed_tests++; |
720 | continue; | 618 | continue; |
@@ -735,59 +633,59 @@ static int dmatest_func(void *data) | |||
735 | * free it this time?" dancing. For now, just | 633 | * free it this time?" dancing. For now, just |
736 | * leave it dangling. | 634 | * leave it dangling. |
737 | */ | 635 | */ |
738 | thread_result_add(info, result, DMATEST_ET_TIMEOUT, | 636 | dmaengine_unmap_put(um); |
739 | total_tests, src_off, dst_off, | 637 | result("test timed out", total_tests, src_off, dst_off, |
740 | len, 0); | 638 | len, 0); |
741 | failed_tests++; | 639 | failed_tests++; |
742 | continue; | 640 | continue; |
743 | } else if (status != DMA_COMPLETE) { | 641 | } else if (status != DMA_COMPLETE) { |
744 | enum dmatest_error_type type = (status == DMA_ERROR) ? | 642 | dmaengine_unmap_put(um); |
745 | DMATEST_ET_DMA_ERROR : DMATEST_ET_DMA_IN_PROGRESS; | 643 | result(status == DMA_ERROR ? |
746 | thread_result_add(info, result, type, | 644 | "completion error status" : |
747 | total_tests, src_off, dst_off, | 645 | "completion busy status", total_tests, src_off, |
748 | len, status); | 646 | dst_off, len, ret); |
749 | failed_tests++; | 647 | failed_tests++; |
750 | continue; | 648 | continue; |
751 | } | 649 | } |
752 | 650 | ||
753 | /* Unmap by myself (see DMA_COMPL_SKIP_DEST_UNMAP above) */ | 651 | dmaengine_unmap_put(um); |
754 | unmap_dst(dev->dev, dma_dsts, params->buf_size, dst_cnt); | ||
755 | 652 | ||
756 | error_count = 0; | 653 | if (params->noverify) { |
654 | verbose_result("test passed", total_tests, src_off, | ||
655 | dst_off, len, 0); | ||
656 | continue; | ||
657 | } | ||
757 | 658 | ||
758 | pr_debug("%s: verifying source buffer...\n", thread_name); | 659 | pr_debug("%s: verifying source buffer...\n", current->comm); |
759 | error_count += verify_result_add(info, result, total_tests, | 660 | error_count = dmatest_verify(thread->srcs, 0, src_off, |
760 | src_off, dst_off, len, thread->srcs, -1, | ||
761 | 0, PATTERN_SRC, true); | 661 | 0, PATTERN_SRC, true); |
762 | error_count += verify_result_add(info, result, total_tests, | 662 | error_count += dmatest_verify(thread->srcs, src_off, |
763 | src_off, dst_off, len, thread->srcs, 0, | 663 | src_off + len, src_off, |
764 | src_off, PATTERN_SRC | PATTERN_COPY, true); | 664 | PATTERN_SRC | PATTERN_COPY, true); |
765 | error_count += verify_result_add(info, result, total_tests, | 665 | error_count += dmatest_verify(thread->srcs, src_off + len, |
766 | src_off, dst_off, len, thread->srcs, 1, | 666 | params->buf_size, src_off + len, |
767 | src_off + len, PATTERN_SRC, true); | 667 | PATTERN_SRC, true); |
768 | 668 | ||
769 | pr_debug("%s: verifying dest buffer...\n", thread_name); | 669 | pr_debug("%s: verifying dest buffer...\n", current->comm); |
770 | error_count += verify_result_add(info, result, total_tests, | 670 | error_count += dmatest_verify(thread->dsts, 0, dst_off, |
771 | src_off, dst_off, len, thread->dsts, -1, | ||
772 | 0, PATTERN_DST, false); | 671 | 0, PATTERN_DST, false); |
773 | error_count += verify_result_add(info, result, total_tests, | 672 | error_count += dmatest_verify(thread->dsts, dst_off, |
774 | src_off, dst_off, len, thread->dsts, 0, | 673 | dst_off + len, src_off, |
775 | src_off, PATTERN_SRC | PATTERN_COPY, false); | 674 | PATTERN_SRC | PATTERN_COPY, false); |
776 | error_count += verify_result_add(info, result, total_tests, | 675 | error_count += dmatest_verify(thread->dsts, dst_off + len, |
777 | src_off, dst_off, len, thread->dsts, 1, | 676 | params->buf_size, dst_off + len, |
778 | dst_off + len, PATTERN_DST, false); | 677 | PATTERN_DST, false); |
779 | 678 | ||
780 | if (error_count) { | 679 | if (error_count) { |
781 | thread_result_add(info, result, DMATEST_ET_VERIFY, | 680 | result("data error", total_tests, src_off, dst_off, |
782 | total_tests, src_off, dst_off, | 681 | len, error_count); |
783 | len, error_count); | ||
784 | failed_tests++; | 682 | failed_tests++; |
785 | } else { | 683 | } else { |
786 | thread_result_add(info, result, DMATEST_ET_OK, | 684 | verbose_result("test passed", total_tests, src_off, |
787 | total_tests, src_off, dst_off, | 685 | dst_off, len, 0); |
788 | len, 0); | ||
789 | } | 686 | } |
790 | } | 687 | } |
688 | runtime = ktime_us_delta(ktime_get(), ktime); | ||
791 | 689 | ||
792 | ret = 0; | 690 | ret = 0; |
793 | for (i = 0; thread->dsts[i]; i++) | 691 | for (i = 0; thread->dsts[i]; i++) |
@@ -802,20 +700,17 @@ err_srcbuf: | |||
802 | err_srcs: | 700 | err_srcs: |
803 | kfree(pq_coefs); | 701 | kfree(pq_coefs); |
804 | err_thread_type: | 702 | err_thread_type: |
805 | pr_notice("%s: terminating after %u tests, %u failures (status %d)\n", | 703 | pr_info("%s: summary %u tests, %u failures %llu iops %llu KB/s (%d)\n", |
806 | thread_name, total_tests, failed_tests, ret); | 704 | current->comm, total_tests, failed_tests, |
705 | dmatest_persec(runtime, total_tests), | ||
706 | dmatest_KBs(runtime, total_len), ret); | ||
807 | 707 | ||
808 | /* terminate all transfers on specified channels */ | 708 | /* terminate all transfers on specified channels */ |
809 | if (ret) | 709 | if (ret) |
810 | dmaengine_terminate_all(chan); | 710 | dmaengine_terminate_all(chan); |
811 | 711 | ||
812 | thread->done = true; | 712 | thread->done = true; |
813 | 713 | wake_up(&thread_wait); | |
814 | if (params->iterations > 0) | ||
815 | while (!kthread_should_stop()) { | ||
816 | DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wait_dmatest_exit); | ||
817 | interruptible_sleep_on(&wait_dmatest_exit); | ||
818 | } | ||
819 | 714 | ||
820 | return ret; | 715 | return ret; |
821 | } | 716 | } |
@@ -828,9 +723,10 @@ static void dmatest_cleanup_channel(struct dmatest_chan *dtc) | |||
828 | 723 | ||
829 | list_for_each_entry_safe(thread, _thread, &dtc->threads, node) { | 724 | list_for_each_entry_safe(thread, _thread, &dtc->threads, node) { |
830 | ret = kthread_stop(thread->task); | 725 | ret = kthread_stop(thread->task); |
831 | pr_debug("dmatest: thread %s exited with status %d\n", | 726 | pr_debug("thread %s exited with status %d\n", |
832 | thread->task->comm, ret); | 727 | thread->task->comm, ret); |
833 | list_del(&thread->node); | 728 | list_del(&thread->node); |
729 | put_task_struct(thread->task); | ||
834 | kfree(thread); | 730 | kfree(thread); |
835 | } | 731 | } |
836 | 732 | ||
@@ -861,27 +757,27 @@ static int dmatest_add_threads(struct dmatest_info *info, | |||
861 | for (i = 0; i < params->threads_per_chan; i++) { | 757 | for (i = 0; i < params->threads_per_chan; i++) { |
862 | thread = kzalloc(sizeof(struct dmatest_thread), GFP_KERNEL); | 758 | thread = kzalloc(sizeof(struct dmatest_thread), GFP_KERNEL); |
863 | if (!thread) { | 759 | if (!thread) { |
864 | pr_warning("dmatest: No memory for %s-%s%u\n", | 760 | pr_warn("No memory for %s-%s%u\n", |
865 | dma_chan_name(chan), op, i); | 761 | dma_chan_name(chan), op, i); |
866 | |||
867 | break; | 762 | break; |
868 | } | 763 | } |
869 | thread->info = info; | 764 | thread->info = info; |
870 | thread->chan = dtc->chan; | 765 | thread->chan = dtc->chan; |
871 | thread->type = type; | 766 | thread->type = type; |
872 | smp_wmb(); | 767 | smp_wmb(); |
873 | thread->task = kthread_run(dmatest_func, thread, "%s-%s%u", | 768 | thread->task = kthread_create(dmatest_func, thread, "%s-%s%u", |
874 | dma_chan_name(chan), op, i); | 769 | dma_chan_name(chan), op, i); |
875 | if (IS_ERR(thread->task)) { | 770 | if (IS_ERR(thread->task)) { |
876 | pr_warning("dmatest: Failed to run thread %s-%s%u\n", | 771 | pr_warn("Failed to create thread %s-%s%u\n", |
877 | dma_chan_name(chan), op, i); | 772 | dma_chan_name(chan), op, i); |
878 | kfree(thread); | 773 | kfree(thread); |
879 | break; | 774 | break; |
880 | } | 775 | } |
881 | 776 | ||
882 | /* srcbuf and dstbuf are allocated by the thread itself */ | 777 | /* srcbuf and dstbuf are allocated by the thread itself */ |
883 | 778 | get_task_struct(thread->task); | |
884 | list_add_tail(&thread->node, &dtc->threads); | 779 | list_add_tail(&thread->node, &dtc->threads); |
780 | wake_up_process(thread->task); | ||
885 | } | 781 | } |
886 | 782 | ||
887 | return i; | 783 | return i; |
@@ -897,7 +793,7 @@ static int dmatest_add_channel(struct dmatest_info *info, | |||
897 | 793 | ||
898 | dtc = kmalloc(sizeof(struct dmatest_chan), GFP_KERNEL); | 794 | dtc = kmalloc(sizeof(struct dmatest_chan), GFP_KERNEL); |
899 | if (!dtc) { | 795 | if (!dtc) { |
900 | pr_warning("dmatest: No memory for %s\n", dma_chan_name(chan)); | 796 | pr_warn("No memory for %s\n", dma_chan_name(chan)); |
901 | return -ENOMEM; | 797 | return -ENOMEM; |
902 | } | 798 | } |
903 | 799 | ||
@@ -917,7 +813,7 @@ static int dmatest_add_channel(struct dmatest_info *info, | |||
917 | thread_count += cnt > 0 ? cnt : 0; | 813 | thread_count += cnt > 0 ? cnt : 0; |
918 | } | 814 | } |
919 | 815 | ||
920 | pr_info("dmatest: Started %u threads using %s\n", | 816 | pr_info("Started %u threads using %s\n", |
921 | thread_count, dma_chan_name(chan)); | 817 | thread_count, dma_chan_name(chan)); |
922 | 818 | ||
923 | list_add_tail(&dtc->node, &info->channels); | 819 | list_add_tail(&dtc->node, &info->channels); |
@@ -937,20 +833,20 @@ static bool filter(struct dma_chan *chan, void *param) | |||
937 | return true; | 833 | return true; |
938 | } | 834 | } |
939 | 835 | ||
940 | static int __run_threaded_test(struct dmatest_info *info) | 836 | static void request_channels(struct dmatest_info *info, |
837 | enum dma_transaction_type type) | ||
941 | { | 838 | { |
942 | dma_cap_mask_t mask; | 839 | dma_cap_mask_t mask; |
943 | struct dma_chan *chan; | ||
944 | struct dmatest_params *params = &info->params; | ||
945 | int err = 0; | ||
946 | 840 | ||
947 | dma_cap_zero(mask); | 841 | dma_cap_zero(mask); |
948 | dma_cap_set(DMA_MEMCPY, mask); | 842 | dma_cap_set(type, mask); |
949 | for (;;) { | 843 | for (;;) { |
844 | struct dmatest_params *params = &info->params; | ||
845 | struct dma_chan *chan; | ||
846 | |||
950 | chan = dma_request_channel(mask, filter, params); | 847 | chan = dma_request_channel(mask, filter, params); |
951 | if (chan) { | 848 | if (chan) { |
952 | err = dmatest_add_channel(info, chan); | 849 | if (dmatest_add_channel(info, chan)) { |
953 | if (err) { | ||
954 | dma_release_channel(chan); | 850 | dma_release_channel(chan); |
955 | break; /* add_channel failed, punt */ | 851 | break; /* add_channel failed, punt */ |
956 | } | 852 | } |
@@ -960,22 +856,30 @@ static int __run_threaded_test(struct dmatest_info *info) | |||
960 | info->nr_channels >= params->max_channels) | 856 | info->nr_channels >= params->max_channels) |
961 | break; /* we have all we need */ | 857 | break; /* we have all we need */ |
962 | } | 858 | } |
963 | return err; | ||
964 | } | 859 | } |
965 | 860 | ||
966 | #ifndef MODULE | 861 | static void run_threaded_test(struct dmatest_info *info) |
967 | static int run_threaded_test(struct dmatest_info *info) | ||
968 | { | 862 | { |
969 | int ret; | 863 | struct dmatest_params *params = &info->params; |
970 | 864 | ||
971 | mutex_lock(&info->lock); | 865 | /* Copy test parameters */ |
972 | ret = __run_threaded_test(info); | 866 | params->buf_size = test_buf_size; |
973 | mutex_unlock(&info->lock); | 867 | strlcpy(params->channel, strim(test_channel), sizeof(params->channel)); |
974 | return ret; | 868 | strlcpy(params->device, strim(test_device), sizeof(params->device)); |
869 | params->threads_per_chan = threads_per_chan; | ||
870 | params->max_channels = max_channels; | ||
871 | params->iterations = iterations; | ||
872 | params->xor_sources = xor_sources; | ||
873 | params->pq_sources = pq_sources; | ||
874 | params->timeout = timeout; | ||
875 | params->noverify = noverify; | ||
876 | |||
877 | request_channels(info, DMA_MEMCPY); | ||
878 | request_channels(info, DMA_XOR); | ||
879 | request_channels(info, DMA_PQ); | ||
975 | } | 880 | } |
976 | #endif | ||
977 | 881 | ||
978 | static void __stop_threaded_test(struct dmatest_info *info) | 882 | static void stop_threaded_test(struct dmatest_info *info) |
979 | { | 883 | { |
980 | struct dmatest_chan *dtc, *_dtc; | 884 | struct dmatest_chan *dtc, *_dtc; |
981 | struct dma_chan *chan; | 885 | struct dma_chan *chan; |
@@ -984,203 +888,86 @@ static void __stop_threaded_test(struct dmatest_info *info) | |||
984 | list_del(&dtc->node); | 888 | list_del(&dtc->node); |
985 | chan = dtc->chan; | 889 | chan = dtc->chan; |
986 | dmatest_cleanup_channel(dtc); | 890 | dmatest_cleanup_channel(dtc); |
987 | pr_debug("dmatest: dropped channel %s\n", dma_chan_name(chan)); | 891 | pr_debug("dropped channel %s\n", dma_chan_name(chan)); |
988 | dma_release_channel(chan); | 892 | dma_release_channel(chan); |
989 | } | 893 | } |
990 | 894 | ||
991 | info->nr_channels = 0; | 895 | info->nr_channels = 0; |
992 | } | 896 | } |
993 | 897 | ||
994 | static void stop_threaded_test(struct dmatest_info *info) | 898 | static void restart_threaded_test(struct dmatest_info *info, bool run) |
995 | { | 899 | { |
996 | mutex_lock(&info->lock); | 900 | /* we might be called early to set run=, defer running until all |
997 | __stop_threaded_test(info); | 901 | * parameters have been evaluated |
998 | mutex_unlock(&info->lock); | 902 | */ |
999 | } | 903 | if (!info->did_init) |
1000 | 904 | return; | |
1001 | static int __restart_threaded_test(struct dmatest_info *info, bool run) | ||
1002 | { | ||
1003 | struct dmatest_params *params = &info->params; | ||
1004 | 905 | ||
1005 | /* Stop any running test first */ | 906 | /* Stop any running test first */ |
1006 | __stop_threaded_test(info); | 907 | stop_threaded_test(info); |
1007 | |||
1008 | if (run == false) | ||
1009 | return 0; | ||
1010 | |||
1011 | /* Clear results from previous run */ | ||
1012 | result_free(info, NULL); | ||
1013 | |||
1014 | /* Copy test parameters */ | ||
1015 | params->buf_size = test_buf_size; | ||
1016 | strlcpy(params->channel, strim(test_channel), sizeof(params->channel)); | ||
1017 | strlcpy(params->device, strim(test_device), sizeof(params->device)); | ||
1018 | params->threads_per_chan = threads_per_chan; | ||
1019 | params->max_channels = max_channels; | ||
1020 | params->iterations = iterations; | ||
1021 | params->xor_sources = xor_sources; | ||
1022 | params->pq_sources = pq_sources; | ||
1023 | params->timeout = timeout; | ||
1024 | 908 | ||
1025 | /* Run test with new parameters */ | 909 | /* Run test with new parameters */ |
1026 | return __run_threaded_test(info); | 910 | run_threaded_test(info); |
1027 | } | ||
1028 | |||
1029 | static bool __is_threaded_test_run(struct dmatest_info *info) | ||
1030 | { | ||
1031 | struct dmatest_chan *dtc; | ||
1032 | |||
1033 | list_for_each_entry(dtc, &info->channels, node) { | ||
1034 | struct dmatest_thread *thread; | ||
1035 | |||
1036 | list_for_each_entry(thread, &dtc->threads, node) { | ||
1037 | if (!thread->done) | ||
1038 | return true; | ||
1039 | } | ||
1040 | } | ||
1041 | |||
1042 | return false; | ||
1043 | } | 911 | } |
1044 | 912 | ||
1045 | static ssize_t dtf_read_run(struct file *file, char __user *user_buf, | 913 | static int dmatest_run_get(char *val, const struct kernel_param *kp) |
1046 | size_t count, loff_t *ppos) | ||
1047 | { | 914 | { |
1048 | struct dmatest_info *info = file->private_data; | 915 | struct dmatest_info *info = &test_info; |
1049 | char buf[3]; | ||
1050 | 916 | ||
1051 | mutex_lock(&info->lock); | 917 | mutex_lock(&info->lock); |
1052 | 918 | if (is_threaded_test_run(info)) { | |
1053 | if (__is_threaded_test_run(info)) { | 919 | dmatest_run = true; |
1054 | buf[0] = 'Y'; | ||
1055 | } else { | 920 | } else { |
1056 | __stop_threaded_test(info); | 921 | stop_threaded_test(info); |
1057 | buf[0] = 'N'; | 922 | dmatest_run = false; |
1058 | } | 923 | } |
1059 | |||
1060 | mutex_unlock(&info->lock); | 924 | mutex_unlock(&info->lock); |
1061 | buf[1] = '\n'; | ||
1062 | buf[2] = 0x00; | ||
1063 | return simple_read_from_buffer(user_buf, count, ppos, buf, 2); | ||
1064 | } | ||
1065 | |||
1066 | static ssize_t dtf_write_run(struct file *file, const char __user *user_buf, | ||
1067 | size_t count, loff_t *ppos) | ||
1068 | { | ||
1069 | struct dmatest_info *info = file->private_data; | ||
1070 | char buf[16]; | ||
1071 | bool bv; | ||
1072 | int ret = 0; | ||
1073 | 925 | ||
1074 | if (copy_from_user(buf, user_buf, min(count, (sizeof(buf) - 1)))) | 926 | return param_get_bool(val, kp); |
1075 | return -EFAULT; | ||
1076 | |||
1077 | if (strtobool(buf, &bv) == 0) { | ||
1078 | mutex_lock(&info->lock); | ||
1079 | |||
1080 | if (__is_threaded_test_run(info)) | ||
1081 | ret = -EBUSY; | ||
1082 | else | ||
1083 | ret = __restart_threaded_test(info, bv); | ||
1084 | |||
1085 | mutex_unlock(&info->lock); | ||
1086 | } | ||
1087 | |||
1088 | return ret ? ret : count; | ||
1089 | } | 927 | } |
1090 | 928 | ||
1091 | static const struct file_operations dtf_run_fops = { | 929 | static int dmatest_run_set(const char *val, const struct kernel_param *kp) |
1092 | .read = dtf_read_run, | ||
1093 | .write = dtf_write_run, | ||
1094 | .open = simple_open, | ||
1095 | .llseek = default_llseek, | ||
1096 | }; | ||
1097 | |||
1098 | static int dtf_results_show(struct seq_file *sf, void *data) | ||
1099 | { | 930 | { |
1100 | struct dmatest_info *info = sf->private; | 931 | struct dmatest_info *info = &test_info; |
1101 | struct dmatest_result *result; | 932 | int ret; |
1102 | struct dmatest_thread_result *tr; | ||
1103 | unsigned int i; | ||
1104 | 933 | ||
1105 | mutex_lock(&info->results_lock); | 934 | mutex_lock(&info->lock); |
1106 | list_for_each_entry(result, &info->results, node) { | 935 | ret = param_set_bool(val, kp); |
1107 | list_for_each_entry(tr, &result->results, node) { | 936 | if (ret) { |
1108 | seq_printf(sf, "%s\n", | 937 | mutex_unlock(&info->lock); |
1109 | thread_result_get(result->name, tr)); | 938 | return ret; |
1110 | if (tr->type == DMATEST_ET_VERIFY_BUF) { | ||
1111 | for (i = 0; i < tr->vr->error_count; i++) { | ||
1112 | seq_printf(sf, "\t%s\n", | ||
1113 | verify_result_get_one(tr->vr, i)); | ||
1114 | } | ||
1115 | } | ||
1116 | } | ||
1117 | } | 939 | } |
1118 | 940 | ||
1119 | mutex_unlock(&info->results_lock); | 941 | if (is_threaded_test_run(info)) |
1120 | return 0; | 942 | ret = -EBUSY; |
1121 | } | 943 | else if (dmatest_run) |
1122 | 944 | restart_threaded_test(info, dmatest_run); | |
1123 | static int dtf_results_open(struct inode *inode, struct file *file) | ||
1124 | { | ||
1125 | return single_open(file, dtf_results_show, inode->i_private); | ||
1126 | } | ||
1127 | |||
1128 | static const struct file_operations dtf_results_fops = { | ||
1129 | .open = dtf_results_open, | ||
1130 | .read = seq_read, | ||
1131 | .llseek = seq_lseek, | ||
1132 | .release = single_release, | ||
1133 | }; | ||
1134 | |||
1135 | static int dmatest_register_dbgfs(struct dmatest_info *info) | ||
1136 | { | ||
1137 | struct dentry *d; | ||
1138 | |||
1139 | d = debugfs_create_dir("dmatest", NULL); | ||
1140 | if (IS_ERR(d)) | ||
1141 | return PTR_ERR(d); | ||
1142 | if (!d) | ||
1143 | goto err_root; | ||
1144 | 945 | ||
1145 | info->root = d; | 946 | mutex_unlock(&info->lock); |
1146 | |||
1147 | /* Run or stop threaded test */ | ||
1148 | debugfs_create_file("run", S_IWUSR | S_IRUGO, info->root, info, | ||
1149 | &dtf_run_fops); | ||
1150 | |||
1151 | /* Results of test in progress */ | ||
1152 | debugfs_create_file("results", S_IRUGO, info->root, info, | ||
1153 | &dtf_results_fops); | ||
1154 | |||
1155 | return 0; | ||
1156 | 947 | ||
1157 | err_root: | 948 | return ret; |
1158 | pr_err("dmatest: Failed to initialize debugfs\n"); | ||
1159 | return -ENOMEM; | ||
1160 | } | 949 | } |
1161 | 950 | ||
1162 | static int __init dmatest_init(void) | 951 | static int __init dmatest_init(void) |
1163 | { | 952 | { |
1164 | struct dmatest_info *info = &test_info; | 953 | struct dmatest_info *info = &test_info; |
1165 | int ret; | 954 | struct dmatest_params *params = &info->params; |
1166 | |||
1167 | memset(info, 0, sizeof(*info)); | ||
1168 | 955 | ||
1169 | mutex_init(&info->lock); | 956 | if (dmatest_run) { |
1170 | INIT_LIST_HEAD(&info->channels); | 957 | mutex_lock(&info->lock); |
958 | run_threaded_test(info); | ||
959 | mutex_unlock(&info->lock); | ||
960 | } | ||
1171 | 961 | ||
1172 | mutex_init(&info->results_lock); | 962 | if (params->iterations && wait) |
1173 | INIT_LIST_HEAD(&info->results); | 963 | wait_event(thread_wait, !is_threaded_test_run(info)); |
1174 | 964 | ||
1175 | ret = dmatest_register_dbgfs(info); | 965 | /* module parameters are stable, inittime tests are started, |
1176 | if (ret) | 966 | * let userspace take over 'run' control |
1177 | return ret; | 967 | */ |
968 | info->did_init = true; | ||
1178 | 969 | ||
1179 | #ifdef MODULE | ||
1180 | return 0; | 970 | return 0; |
1181 | #else | ||
1182 | return run_threaded_test(info); | ||
1183 | #endif | ||
1184 | } | 971 | } |
1185 | /* when compiled-in wait for drivers to load first */ | 972 | /* when compiled-in wait for drivers to load first */ |
1186 | late_initcall(dmatest_init); | 973 | late_initcall(dmatest_init); |
@@ -1189,9 +976,9 @@ static void __exit dmatest_exit(void) | |||
1189 | { | 976 | { |
1190 | struct dmatest_info *info = &test_info; | 977 | struct dmatest_info *info = &test_info; |
1191 | 978 | ||
1192 | debugfs_remove_recursive(info->root); | 979 | mutex_lock(&info->lock); |
1193 | stop_threaded_test(info); | 980 | stop_threaded_test(info); |
1194 | result_free(info, NULL); | 981 | mutex_unlock(&info->lock); |
1195 | } | 982 | } |
1196 | module_exit(dmatest_exit); | 983 | module_exit(dmatest_exit); |
1197 | 984 | ||