diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-08-14 08:58:32 -0400 |
---|---|---|
committer | Vinod Koul <vinod.koul@linux.intel.com> | 2012-08-22 00:21:04 -0400 |
commit | 983d7beb7de4ba7c715ea62e982c9fe54fa554a1 (patch) | |
tree | a0239501e8ceb20ece6288c8667a8b88861b8a2d /drivers/dma/amba-pl08x.c | |
parent | 94d3901c11ab4115740ec3891d07f086f18c8cd6 (diff) |
drivers/dma/amba-pl08x.c: fix error return code
Convert a 0 error return code to a negative one, as returned elsewhere in the
function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier ret;
expression e,e1,e2,e3,e4,x;
@@
(
if (\(ret != 0\|ret < 0\) || ...) { ... return ...; }
|
ret = 0
)
... when != ret = e1
*x = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\|ioremap\|ioremap_nocache\|devm_ioremap\|devm_ioremap_nocache\)(...);
... when != x = e2
when != ret = e3
*if (x == NULL || ...)
{
... when != ret = e4
* return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
Diffstat (limited to 'drivers/dma/amba-pl08x.c')
-rw-r--r-- | drivers/dma/amba-pl08x.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 6fbeebb9486f..d1cc5791476b 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c | |||
@@ -1892,6 +1892,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id) | |||
1892 | pl08x->pd = dev_get_platdata(&adev->dev); | 1892 | pl08x->pd = dev_get_platdata(&adev->dev); |
1893 | if (!pl08x->pd) { | 1893 | if (!pl08x->pd) { |
1894 | dev_err(&adev->dev, "no platform data supplied\n"); | 1894 | dev_err(&adev->dev, "no platform data supplied\n"); |
1895 | ret = -EINVAL; | ||
1895 | goto out_no_platdata; | 1896 | goto out_no_platdata; |
1896 | } | 1897 | } |
1897 | 1898 | ||
@@ -1943,6 +1944,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id) | |||
1943 | dev_err(&adev->dev, "%s failed to allocate " | 1944 | dev_err(&adev->dev, "%s failed to allocate " |
1944 | "physical channel holders\n", | 1945 | "physical channel holders\n", |
1945 | __func__); | 1946 | __func__); |
1947 | ret = -ENOMEM; | ||
1946 | goto out_no_phychans; | 1948 | goto out_no_phychans; |
1947 | } | 1949 | } |
1948 | 1950 | ||