diff options
author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2014-08-13 21:00:44 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2014-08-25 08:34:04 -0400 |
commit | 65fafbe9bddf49d53a2bbae92498909e3c5f964b (patch) | |
tree | 110a432d59abb22f14ec11234fd2bc4defac20bb /drivers/crypto | |
parent | e5ffbfc182bc148f44840bdd3970ea4c8bf80c3c (diff) |
crypto: qat - Fix return value check in adf_chr_drv_create()
In case of error, the function device_create() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
-rw-r--r-- | drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/qat/qat_common/adf_ctl_drv.c b/drivers/crypto/qat/qat_common/adf_ctl_drv.c index d97069b8a8e4..6f7816e2c421 100644 --- a/drivers/crypto/qat/qat_common/adf_ctl_drv.c +++ b/drivers/crypto/qat/qat_common/adf_ctl_drv.c | |||
@@ -111,7 +111,7 @@ static int adf_chr_drv_create(void) | |||
111 | drv_device = device_create(adt_ctl_drv.drv_class, NULL, | 111 | drv_device = device_create(adt_ctl_drv.drv_class, NULL, |
112 | MKDEV(adt_ctl_drv.major, 0), | 112 | MKDEV(adt_ctl_drv.major, 0), |
113 | NULL, DEVICE_NAME); | 113 | NULL, DEVICE_NAME); |
114 | if (!drv_device) { | 114 | if (IS_ERR(drv_device)) { |
115 | pr_err("QAT: failed to create device\n"); | 115 | pr_err("QAT: failed to create device\n"); |
116 | goto err_cdev_del; | 116 | goto err_cdev_del; |
117 | } | 117 | } |