diff options
author | Lars-Peter Clausen <lars@metafoo.de> | 2013-05-20 13:14:50 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2013-05-28 03:43:04 -0400 |
commit | b02266531f3e7f9b3ce8fc95c06a15b99fd13b7f (patch) | |
tree | 63f0981b522ef1ec12ed394db66d0e5b02f38f89 /drivers/crypto/hifn_795x.c | |
parent | 519d8b1a9d81be7e4ffad8aa6b0e3ea03984bb86 (diff) |
crypto: hifn_795x - Pass correct pointer to free_irq()
free_irq() expects the same pointer that was passed to request_irq(), otherwise
the IRQ is not freed.
The issue was found using the following coccinelle script:
<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)
@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)
@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/hifn_795x.c')
-rw-r--r-- | drivers/crypto/hifn_795x.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c index ebf130e894b5..12fea3e22348 100644 --- a/drivers/crypto/hifn_795x.c +++ b/drivers/crypto/hifn_795x.c | |||
@@ -2676,7 +2676,7 @@ err_out_stop_device: | |||
2676 | hifn_reset_dma(dev, 1); | 2676 | hifn_reset_dma(dev, 1); |
2677 | hifn_stop_device(dev); | 2677 | hifn_stop_device(dev); |
2678 | err_out_free_irq: | 2678 | err_out_free_irq: |
2679 | free_irq(dev->irq, dev->name); | 2679 | free_irq(dev->irq, dev); |
2680 | tasklet_kill(&dev->tasklet); | 2680 | tasklet_kill(&dev->tasklet); |
2681 | err_out_free_desc: | 2681 | err_out_free_desc: |
2682 | pci_free_consistent(pdev, sizeof(struct hifn_dma), | 2682 | pci_free_consistent(pdev, sizeof(struct hifn_dma), |
@@ -2711,7 +2711,7 @@ static void hifn_remove(struct pci_dev *pdev) | |||
2711 | hifn_reset_dma(dev, 1); | 2711 | hifn_reset_dma(dev, 1); |
2712 | hifn_stop_device(dev); | 2712 | hifn_stop_device(dev); |
2713 | 2713 | ||
2714 | free_irq(dev->irq, dev->name); | 2714 | free_irq(dev->irq, dev); |
2715 | tasklet_kill(&dev->tasklet); | 2715 | tasklet_kill(&dev->tasklet); |
2716 | 2716 | ||
2717 | hifn_flush(dev); | 2717 | hifn_flush(dev); |