diff options
author | Jussi Kivilinna <jussi.kivilinna@mbnet.fi> | 2012-07-11 07:20:56 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2012-08-01 05:47:28 -0400 |
commit | e15aa3692da1dcee3172966a878b04a1e0f514b3 (patch) | |
tree | 0b9f118a6a38317524969845f21e8722f3414742 /drivers/crypto/atmel-aes.c | |
parent | 7af6c2456851eb08d51d95de38ae8302994031e9 (diff) |
crypto: drivers - remove cra_list initialization
Initialization of cra_list is currently mixed, most ciphers initialize this
field and most shashes do not. Initialization however is not needed at all
since cra_list is initialized/overwritten in __crypto_register_alg() with
list_add(). Therefore perform cleanup to remove all unneeded initializations
of this field in 'crypto/drivers/'.
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-geode@lists.infradead.org
Cc: Michal Ludvig <michal@logix.cz>
Cc: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
Cc: Varun Wadekar <vwadekar@nvidia.com>
Cc: Eric BĂ©nard <eric@eukrea.com>
Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Acked-by: Kent Yoder <key@linux.vnet.ibm.com>
Acked-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/atmel-aes.c')
-rw-r--r-- | drivers/crypto/atmel-aes.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index 6bb20fffbf49..872ca8c8d83b 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c | |||
@@ -1017,7 +1017,6 @@ static int atmel_aes_register_algs(struct atmel_aes_dev *dd) | |||
1017 | int err, i, j; | 1017 | int err, i, j; |
1018 | 1018 | ||
1019 | for (i = 0; i < ARRAY_SIZE(aes_algs); i++) { | 1019 | for (i = 0; i < ARRAY_SIZE(aes_algs); i++) { |
1020 | INIT_LIST_HEAD(&aes_algs[i].cra_list); | ||
1021 | err = crypto_register_alg(&aes_algs[i]); | 1020 | err = crypto_register_alg(&aes_algs[i]); |
1022 | if (err) | 1021 | if (err) |
1023 | goto err_aes_algs; | 1022 | goto err_aes_algs; |
@@ -1026,7 +1025,6 @@ static int atmel_aes_register_algs(struct atmel_aes_dev *dd) | |||
1026 | atmel_aes_hw_version_init(dd); | 1025 | atmel_aes_hw_version_init(dd); |
1027 | 1026 | ||
1028 | if (dd->hw_version >= 0x130) { | 1027 | if (dd->hw_version >= 0x130) { |
1029 | INIT_LIST_HEAD(&aes_cfb64_alg[0].cra_list); | ||
1030 | err = crypto_register_alg(&aes_cfb64_alg[0]); | 1028 | err = crypto_register_alg(&aes_cfb64_alg[0]); |
1031 | if (err) | 1029 | if (err) |
1032 | goto err_aes_cfb64_alg; | 1030 | goto err_aes_cfb64_alg; |