diff options
author | Chuansheng Liu <chuansheng.liu@intel.com> | 2014-09-04 03:17:55 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2014-09-19 06:35:16 -0400 |
commit | 2ed903c5485bad0eafdd3d59ff993598736e4f31 (patch) | |
tree | 11fbb80a8589d123a89f85f2cbfda9f7bb9589a3 /drivers/cpuidle | |
parent | c6f4459fc3ba532e896cb678e29b45cb985f82bf (diff) |
cpuidle: Use wake_up_all_idle_cpus() to wake up all idle cpus
Currently kick_all_cpus_sync() or smp_call_function() can not
break the polling idle cpu immediately.
Instead using wake_up_all_idle_cpus() which can wake up the polling idle
cpu quickly is much more helpful for power.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: linux-pm@vger.kernel.org
Cc: changcheng.liu@intel.com
Cc: xiaoming.wang@intel.com
Cc: souvik.k.chakravarty@intel.com
Cc: luto@amacapital.net
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: linux-pm@vger.kernel.org
Link: http://lkml.kernel.org/r/1409815075-4180-3-git-send-email-chuansheng.liu@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'drivers/cpuidle')
-rw-r--r-- | drivers/cpuidle/cpuidle.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index ee9df5e3f5eb..d31e04ca8703 100644 --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c | |||
@@ -223,7 +223,7 @@ void cpuidle_uninstall_idle_handler(void) | |||
223 | { | 223 | { |
224 | if (enabled_devices) { | 224 | if (enabled_devices) { |
225 | initialized = 0; | 225 | initialized = 0; |
226 | kick_all_cpus_sync(); | 226 | wake_up_all_idle_cpus(); |
227 | } | 227 | } |
228 | } | 228 | } |
229 | 229 | ||
@@ -530,11 +530,6 @@ EXPORT_SYMBOL_GPL(cpuidle_register); | |||
530 | 530 | ||
531 | #ifdef CONFIG_SMP | 531 | #ifdef CONFIG_SMP |
532 | 532 | ||
533 | static void smp_callback(void *v) | ||
534 | { | ||
535 | /* we already woke the CPU up, nothing more to do */ | ||
536 | } | ||
537 | |||
538 | /* | 533 | /* |
539 | * This function gets called when a part of the kernel has a new latency | 534 | * This function gets called when a part of the kernel has a new latency |
540 | * requirement. This means we need to get all processors out of their C-state, | 535 | * requirement. This means we need to get all processors out of their C-state, |
@@ -544,7 +539,7 @@ static void smp_callback(void *v) | |||
544 | static int cpuidle_latency_notify(struct notifier_block *b, | 539 | static int cpuidle_latency_notify(struct notifier_block *b, |
545 | unsigned long l, void *v) | 540 | unsigned long l, void *v) |
546 | { | 541 | { |
547 | smp_call_function(smp_callback, NULL, 1); | 542 | wake_up_all_idle_cpus(); |
548 | return NOTIFY_OK; | 543 | return NOTIFY_OK; |
549 | } | 544 | } |
550 | 545 | ||