diff options
author | Viresh Kumar <viresh.kumar@linaro.org> | 2013-08-14 10:08:24 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-10-30 19:11:08 -0400 |
commit | d4019f0a92ab802f385cc9c8ad3ab7b5449712cb (patch) | |
tree | ebd06695585e457ae1bf219653452b111e7508db /drivers/cpufreq/elanfreq.c | |
parent | 7dbf694db6ac7c759599316d50d7050efcbd512a (diff) |
cpufreq: move freq change notifications to cpufreq core
Most of the drivers do following in their ->target_index() routines:
struct cpufreq_freqs freqs;
freqs.old = old freq...
freqs.new = new freq...
cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE);
/* Change rate here */
cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);
This is replicated over all cpufreq drivers today and there doesn't exists a
good enough reason why this shouldn't be moved to cpufreq core instead.
There are few special cases though, like exynos5440, which doesn't do everything
on the call to ->target_index() routine and call some kind of bottom halves for
doing this work, work/tasklet/etc..
They may continue doing notification from their own code as flag:
CPUFREQ_ASYNC_NOTIFICATION is already set for them.
All drivers are also modified in this patch to avoid breaking 'git bisect', as
double notification would happen otherwise.
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Russell King <linux@arm.linux.org.uk>
Acked-by: Stephen Warren <swarren@nvidia.com>
Tested-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Reviewed-by: Lan Tianyu <tianyu.lan@intel.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpufreq/elanfreq.c')
-rw-r--r-- | drivers/cpufreq/elanfreq.c | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/drivers/cpufreq/elanfreq.c b/drivers/cpufreq/elanfreq.c index 4ab41539514f..de08acff5101 100644 --- a/drivers/cpufreq/elanfreq.c +++ b/drivers/cpufreq/elanfreq.c | |||
@@ -108,17 +108,6 @@ static unsigned int elanfreq_get_cpu_frequency(unsigned int cpu) | |||
108 | static int elanfreq_target(struct cpufreq_policy *policy, | 108 | static int elanfreq_target(struct cpufreq_policy *policy, |
109 | unsigned int state) | 109 | unsigned int state) |
110 | { | 110 | { |
111 | struct cpufreq_freqs freqs; | ||
112 | |||
113 | freqs.old = elanfreq_get_cpu_frequency(0); | ||
114 | freqs.new = elan_multiplier[state].clock; | ||
115 | |||
116 | cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE); | ||
117 | |||
118 | printk(KERN_INFO "elanfreq: attempting to set frequency to %i kHz\n", | ||
119 | elan_multiplier[state].clock); | ||
120 | |||
121 | |||
122 | /* | 111 | /* |
123 | * Access to the Elan's internal registers is indexed via | 112 | * Access to the Elan's internal registers is indexed via |
124 | * 0x22: Chip Setup & Control Register Index Register (CSCI) | 113 | * 0x22: Chip Setup & Control Register Index Register (CSCI) |
@@ -149,8 +138,6 @@ static int elanfreq_target(struct cpufreq_policy *policy, | |||
149 | udelay(10000); | 138 | udelay(10000); |
150 | local_irq_enable(); | 139 | local_irq_enable(); |
151 | 140 | ||
152 | cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE); | ||
153 | |||
154 | return 0; | 141 | return 0; |
155 | } | 142 | } |
156 | /* | 143 | /* |