diff options
author | Alexey Dobriyan <adobriyan@gmail.com> | 2007-02-10 04:45:54 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-11 13:51:32 -0500 |
commit | b653d081c17e26101980c858a9808740533b78b4 (patch) | |
tree | 907b6e6d97f30b61840cf4b1654f88a1df56945c /drivers/char | |
parent | 891dcd2f7ab15e2aaad07f6925b3a53fd8d5c02f (diff) |
[PATCH] proc: remove useless (and buggy) ->nlink settings
Bug: pnx8550 code creates directory but resets ->nlink to 1.
create_proc_entry() et al will correctly set ->nlink for you.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Corey Minyard <minyard@acm.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Greg KH <greg@kroah.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char')
-rw-r--r-- | drivers/char/ipmi/ipmi_msghandler.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 230064ede08d..3aff5e99b674 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c | |||
@@ -1887,7 +1887,6 @@ int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name, | |||
1887 | kfree(entry); | 1887 | kfree(entry); |
1888 | rv = -ENOMEM; | 1888 | rv = -ENOMEM; |
1889 | } else { | 1889 | } else { |
1890 | file->nlink = 1; | ||
1891 | file->data = data; | 1890 | file->data = data; |
1892 | file->read_proc = read_proc; | 1891 | file->read_proc = read_proc; |
1893 | file->write_proc = write_proc; | 1892 | file->write_proc = write_proc; |