aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/char
diff options
context:
space:
mode:
authorJiri Slaby <jirislaby@gmail.com>2007-02-10 04:45:22 -0500
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-02-11 13:51:29 -0500
commit722d5e4ae89f061582cc46ccbbd3b5ae87a6e165 (patch)
tree3f73ee6a96b26e119696daea26e673c1bce9ca44 /drivers/char
parentf64c84a1668930d1ca2b7dbaa92146c2139cb508 (diff)
[PATCH] Char: mxser_new, do not null driver_data
driver_data are initialzed to NULL from tty layer, no need to do it in the driver. In this case it cases oops, since driver_data may be NULL for a short while for another closing process. Signed-off-by: Jiri Slaby <jirislaby@gmail.com> Cc: <osv@javad.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/mxser_new.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/char/mxser_new.c b/drivers/char/mxser_new.c
index 4c805496fb36..1c8e00c4caad 100644
--- a/drivers/char/mxser_new.c
+++ b/drivers/char/mxser_new.c
@@ -927,9 +927,6 @@ static int mxser_open(struct tty_struct *tty, struct file *filp)
927 struct mxser_port *info; 927 struct mxser_port *info;
928 int retval, line; 928 int retval, line;
929 929
930 /* initialize driver_data in case something fails */
931 tty->driver_data = NULL;
932
933 line = tty->index; 930 line = tty->index;
934 if (line == MXSER_PORTS) 931 if (line == MXSER_PORTS)
935 return 0; 932 return 0;