Merge branch 'tracing/ftrace'; commit 'v2.6.29-rc2' into tracing/core

11 files changed, 207 insertions, 69 deletions

diff --git a/drivers/char/amiserial.c b/drivers/char/amiserial.c
index 4e0cfdeab146..a58869ea8513 100644
--- a/drivers/char/amiserial.c
+++ b/drivers/char/amiserial.c
@@ -1963,6 +1963,7 @@ static int __init rs_init(void)
 {
         unsigned long flags;
         struct serial_state * state;
+        int error;
 
         if (!MACH_IS_AMIGA || !AMIGAHW_PRESENT(AMI_SERIAL))
                 return -ENODEV;
@@ -1975,8 +1976,11 @@ static int __init rs_init(void)
          *  We request SERDAT and SERPER only, because the serial registers are
          *  too spreaded over the custom register space
          */
-        if (!request_mem_region(CUSTOM_PHYSADDR+0x30, 4, "amiserial [Paula]"))
-                return -EBUSY;
+        if (!request_mem_region(CUSTOM_PHYSADDR+0x30, 4,
+                                "amiserial [Paula]")) {
+                error = -EBUSY;
+                goto fail_put_tty_driver;
+        }
 
         IRQ_ports = NULL;
 
@@ -1997,8 +2001,9 @@ static int __init rs_init(void)
         serial_driver->flags = TTY_DRIVER_REAL_RAW;
         tty_set_operations(serial_driver, &serial_ops);
 
-        if (tty_register_driver(serial_driver))
-                panic("Couldn't register serial driver\n");
+        error = tty_register_driver(serial_driver);
+        if (error)
+                goto fail_release_mem_region;
 
         state = rs_table;
         state->magic = SSTATE_MAGIC;
@@ -2024,8 +2029,14 @@ static int __init rs_init(void)
         local_irq_save(flags);
 
         /* set ISRs, and then disable the rx interrupts */
-        request_irq(IRQ_AMIGA_TBE, ser_tx_int, 0, "serial TX", state);
-        request_irq(IRQ_AMIGA_RBF, ser_rx_int, IRQF_DISABLED, "serial RX", state);
+        error = request_irq(IRQ_AMIGA_TBE, ser_tx_int, 0, "serial TX", state);
+        if (error)
+                goto fail_unregister;
+
+        error = request_irq(IRQ_AMIGA_RBF, ser_rx_int, IRQF_DISABLED,
+                            "serial RX", state);
+        if (error)
+                goto fail_free_irq;
 
         /* turn off Rx and Tx interrupts */
         custom.intena = IF_RBF | IF_TBE;
@@ -2045,6 +2056,16 @@ static int __init rs_init(void)
         ciab.ddra &= ~(SER_DCD | SER_CTS | SER_DSR);  /* inputs */
 
         return 0;
+
+fail_free_irq:
+        free_irq(IRQ_AMIGA_TBE, state);
+fail_unregister:
+        tty_unregister_driver(serial_driver);
+fail_release_mem_region:
+        release_mem_region(CUSTOM_PHYSADDR+0x30, 4);
+fail_put_tty_driver:
+        put_tty_driver(serial_driver);
+        return error;
 }
 
 static __exit void rs_exit(void) 
@@ -2064,6 +2085,9 @@ static __exit void rs_exit(void)
           kfree(info);
         }
 
+        free_irq(IRQ_AMIGA_TBE, rs_table);
+        free_irq(IRQ_AMIGA_RBF, rs_table);
+
         release_mem_region(CUSTOM_PHYSADDR+0x30, 4);
 }
 
diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
index 977dfb1096a0..f6094ae0ef33 100644
--- a/drivers/char/bsr.c
+++ b/drivers/char/bsr.c
@@ -103,7 +103,7 @@ static ssize_t
 bsr_len_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
         struct bsr_dev *bsr_dev = dev_get_drvdata(dev);
-        return sprintf(buf, "%lu\n", bsr_dev->bsr_len);
+        return sprintf(buf, "%llu\n", bsr_dev->bsr_len);
 }
 
 static struct device_attribute bsr_dev_attrs[] = {
diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console.c
index 5a8a4c28c867..94e7e3c8c05a 100644
--- a/drivers/char/hvc_console.c
+++ b/drivers/char/hvc_console.c
@@ -318,7 +318,6 @@ static int hvc_open(struct tty_struct *tty, struct file * filp)
         } /* else count == 0 */
 
         tty->driver_data = hp;
-        tty->low_latency = 1; /* Makes flushes to ldisc synchronous. */
 
         hp->tty = tty;
 
@@ -764,13 +763,11 @@ struct hvc_struct __devinit *hvc_alloc(uint32_t vtermno, int data,
                         return ERR_PTR(err);
         }
 
-        hp = kmalloc(ALIGN(sizeof(*hp), sizeof(long)) + outbuf_size,
+        hp = kzalloc(ALIGN(sizeof(*hp), sizeof(long)) + outbuf_size,
                         GFP_KERNEL);
         if (!hp)
                 return ERR_PTR(-ENOMEM);
 
-        memset(hp, 0x00, sizeof(*hp));
-
         hp->vtermno = vtermno;
         hp->data = data;
         hp->ops = ops;
@@ -876,8 +873,11 @@ static int hvc_init(void)
                 goto stop_thread;
         }
 
-        /* FIXME: This mb() seems completely random.  Remove it. */
-        mb();
+        /*
+         * Make sure tty is fully registered before allowing it to be
+         * found by hvc_console_device.
+         */
+        smp_mb();
         hvc_driver = drv;
         return 0;
 
diff --git a/drivers/char/hvc_irq.c b/drivers/char/hvc_irq.c
index d09e5688d449..2623e177e8d6 100644
--- a/drivers/char/hvc_irq.c
+++ b/drivers/char/hvc_irq.c
@@ -37,7 +37,7 @@ int notifier_add_irq(struct hvc_struct *hp, int irq)
 
 void notifier_del_irq(struct hvc_struct *hp, int irq)
 {
-        if (!irq)
+        if (!hp->irq_requested)
                 return;
         free_irq(irq, hp);
         hp->irq_requested = 0;
diff --git a/drivers/char/ps3flash.c b/drivers/char/ps3flash.c
index 79b6f461be75..afbe45676d71 100644
--- a/drivers/char/ps3flash.c
+++ b/drivers/char/ps3flash.c
@@ -44,7 +44,7 @@ static ssize_t ps3flash_read_write_sectors(struct ps3_storage_device *dev,
         u64 res = ps3stor_read_write_sectors(dev, lpar, start_sector, sectors,
                                              write);
         if (res) {
-                dev_err(&dev->sbd.core, "%s:%u: %s failed 0x%lx\n", __func__,
+                dev_err(&dev->sbd.core, "%s:%u: %s failed 0x%llx\n", __func__,
                         __LINE__, write ? "write" : "read", res);
                 return -EIO;
         }
@@ -59,7 +59,7 @@ static ssize_t ps3flash_read_sectors(struct ps3_storage_device *dev,
 
         max_sectors = dev->bounce_size / dev->blk_size;
         if (sectors > max_sectors) {
-                dev_dbg(&dev->sbd.core, "%s:%u Limiting sectors to %lu\n",
+                dev_dbg(&dev->sbd.core, "%s:%u Limiting sectors to %llu\n",
                         __func__, __LINE__, max_sectors);
                 sectors = max_sectors;
         }
@@ -144,7 +144,7 @@ static ssize_t ps3flash_read(struct file *file, char __user *buf, size_t count,
                         goto fail;
                 }
 
-                n = min(remaining, sectors_read*dev->blk_size-offset);
+                n = min_t(u64, remaining, sectors_read*dev->blk_size-offset);
                 dev_dbg(&dev->sbd.core,
                         "%s:%u: copy %lu bytes from 0x%p to user 0x%p\n",
                         __func__, __LINE__, n, dev->bounce_buf+offset, buf);
@@ -225,7 +225,7 @@ static ssize_t ps3flash_write(struct file *file, const char __user *buf,
                 if (end_read_sector >= start_read_sector) {
                         /* Merge head and tail */
                         dev_dbg(&dev->sbd.core,
-                                "Merged head and tail: %lu sectors at %lu\n",
+                                "Merged head and tail: %llu sectors at %llu\n",
                                 chunk_sectors, start_write_sector);
                         res = ps3flash_read_sectors(dev, start_write_sector,
                                                     chunk_sectors, 0);
@@ -235,7 +235,7 @@ static ssize_t ps3flash_write(struct file *file, const char __user *buf,
                         if (head) {
                                 /* Read head */
                                 dev_dbg(&dev->sbd.core,
-                                        "head: %lu sectors at %lu\n", head,
+                                        "head: %llu sectors at %llu\n", head,
                                         start_write_sector);
                                 res = ps3flash_read_sectors(dev,
                                                             start_write_sector,
@@ -247,7 +247,7 @@ static ssize_t ps3flash_write(struct file *file, const char __user *buf,
                             start_write_sector+chunk_sectors) {
                                 /* Read tail */
                                 dev_dbg(&dev->sbd.core,
-                                        "tail: %lu sectors at %lu\n", tail,
+                                        "tail: %llu sectors at %llu\n", tail,
                                         start_read_sector);
                                 sec_off = start_read_sector-start_write_sector;
                                 res = ps3flash_read_sectors(dev,
@@ -258,7 +258,7 @@ static ssize_t ps3flash_write(struct file *file, const char __user *buf,
                         }
                 }
 
-                n = min(remaining, dev->bounce_size-offset);
+                n = min_t(u64, remaining, dev->bounce_size-offset);
                 dev_dbg(&dev->sbd.core,
                         "%s:%u: copy %lu bytes from user 0x%p to 0x%p\n",
                         __func__, __LINE__, n, buf, dev->bounce_buf+offset);
@@ -299,11 +299,11 @@ static irqreturn_t ps3flash_interrupt(int irq, void *data)
 
         if (tag != dev->tag)
                 dev_err(&dev->sbd.core,
-                        "%s:%u: tag mismatch, got %lx, expected %lx\n",
+                        "%s:%u: tag mismatch, got %llx, expected %llx\n",
                         __func__, __LINE__, tag, dev->tag);
 
         if (res) {
-                dev_err(&dev->sbd.core, "%s:%u: res=%d status=0x%lx\n",
+                dev_err(&dev->sbd.core, "%s:%u: res=%d status=0x%llx\n",
                         __func__, __LINE__, res, status);
         } else {
                 dev->lv1_status = status;
diff --git a/drivers/char/pty.c b/drivers/char/pty.c
index 146c97613da0..31038a0052a2 100644
--- a/drivers/char/pty.c
+++ b/drivers/char/pty.c
@@ -230,9 +230,7 @@ static void pty_set_termios(struct tty_struct *tty,
 /**
  *      pty_do_resize           -       resize event
  *      @tty: tty being resized
- *      @real_tty: real tty (not the same as tty if using a pty/tty pair)
- *      @rows: rows (character)
- *      @cols: cols (character)
+ *      @ws: window size being set.
  *
  *      Update the termios variables and send the neccessary signals to
  *      peform a terminal resize correctly
diff --git a/drivers/char/ser_a2232.c b/drivers/char/ser_a2232.c
index 33872a219df6..33a2b531802e 100644
--- a/drivers/char/ser_a2232.c
+++ b/drivers/char/ser_a2232.c
@@ -718,6 +718,7 @@ static int __init a2232board_init(void)
         u_char *from;
         volatile u_char *to;
         volatile struct a2232memory *mem;
+        int error, i;
 
 #ifdef CONFIG_SMP
         return -ENODEV; /* This driver is not SMP aware. Is there an SMP ZorroII-bus-machine? */
@@ -797,8 +798,15 @@ static int __init a2232board_init(void)
         */
         if (a2232_init_drivers()) return -ENODEV; // maybe we should use a different -Exxx?
 
-        request_irq(IRQ_AMIGA_VERTB, a2232_vbl_inter, 0, "A2232 serial VBL", a2232_driver_ID);
-        return 0;
+        error = request_irq(IRQ_AMIGA_VERTB, a2232_vbl_inter, 0,
+                            "A2232 serial VBL", a2232_driver_ID);
+        if (error) {
+                for (i = 0; i < nr_a2232; i++)
+                        zorro_release_device(zd_a2232[i]);
+                tty_unregister_driver(a2232_driver);
+                put_tty_driver(a2232_driver);
+        }
+        return error;
 }
 
 static void __exit a2232board_exit(void)
diff --git a/drivers/char/synclink_gt.c b/drivers/char/synclink_gt.c
index 53544e21f191..f329f459817c 100644
--- a/drivers/char/synclink_gt.c
+++ b/drivers/char/synclink_gt.c
@@ -1,6 +1,4 @@
 /*
- * $Id: synclink_gt.c,v 4.50 2007/07/25 19:29:25 paulkf Exp $
- *
  * Device driver for Microgate SyncLink GT serial adapters.
  *
  * written by Paul Fulghum for Microgate Corporation
@@ -91,7 +89,6 @@
  * module identification
  */
 static char *driver_name     = "SyncLink GT";
-static char *driver_version  = "$Revision: 4.50 $";
 static char *tty_driver_name = "synclink_gt";
 static char *tty_dev_prefix  = "ttySLG";
 MODULE_LICENSE("GPL");
@@ -1309,7 +1306,7 @@ static int read_proc(char *page, char **start, off_t off, int count,
         off_t   begin = 0;
         struct slgt_info *info;
 
-        len += sprintf(page, "synclink_gt driver:%s\n", driver_version);
+        len += sprintf(page, "synclink_gt driver\n");
 
         info = slgt_device_list;
         while( info ) {
@@ -2441,7 +2438,7 @@ static void program_hw(struct slgt_info *info)
         info->ri_chkcount = 0;
         info->dsr_chkcount = 0;
 
-        slgt_irq_on(info, IRQ_DCD | IRQ_CTS | IRQ_DSR);
+        slgt_irq_on(info, IRQ_DCD | IRQ_CTS | IRQ_DSR | IRQ_RI);
         get_signals(info);
 
         if (info->netcount ||
@@ -3576,7 +3573,7 @@ static void slgt_cleanup(void)
         struct slgt_info *info;
         struct slgt_info *tmp;
 
-        printk("unload %s %s\n", driver_name, driver_version);
+        printk(KERN_INFO "unload %s\n", driver_name);
 
         if (serial_driver) {
                 for (info=slgt_device_list ; info != NULL ; info=info->next_device)
@@ -3619,7 +3616,7 @@ static int __init slgt_init(void)
 {
         int rc;
 
-        printk("%s %s\n", driver_name, driver_version);
+        printk(KERN_INFO "%s\n", driver_name);
 
         serial_driver = alloc_tty_driver(MAX_DEVICES);
         if (!serial_driver) {
@@ -3650,9 +3647,8 @@ static int __init slgt_init(void)
                 goto error;
         }
 
-        printk("%s %s, tty major#%d\n",
-                driver_name, driver_version,
-                serial_driver->major);
+        printk(KERN_INFO "%s, tty major#%d\n",
+               driver_name, serial_driver->major);
 
         slgt_device_count = 0;
         if ((rc = pci_register_driver(&pci_driver)) < 0) {
diff --git a/drivers/char/sysrq.c b/drivers/char/sysrq.c
index 985dc8f6c747..30659ce9bcf4 100644
--- a/drivers/char/sysrq.c
+++ b/drivers/char/sysrq.c
@@ -473,6 +473,12 @@ void __handle_sysrq(int key, struct tty_struct *tty, int check_mask)
         unsigned long flags;
 
         spin_lock_irqsave(&sysrq_key_table_lock, flags);
+        /*
+         * Raise the apparent loglevel to maximum so that the sysrq header
+         * is shown to provide the user with positive feedback.  We do not
+         * simply emit this at KERN_EMERG as that would change message
+         * routing in the consumers of /proc/kmsg.
+         */
         orig_log_level = console_loglevel;
         console_loglevel = 7;
         printk(KERN_INFO "SysRq : ");
diff --git a/drivers/char/tty_ioctl.c b/drivers/char/tty_ioctl.c
index a408c8e487ec..6f4c7d0a53bf 100644
--- a/drivers/char/tty_ioctl.c
+++ b/drivers/char/tty_ioctl.c
@@ -1057,7 +1057,7 @@ int tty_perform_flush(struct tty_struct *tty, unsigned long arg)
         if (retval)
                 return retval;
 
-        ld = tty_ldisc_ref(tty);
+        ld = tty_ldisc_ref_wait(tty);
         switch (arg) {
         case TCIFLUSH:
                 if (ld && ld->ops->flush_buffer)
diff --git a/drivers/char/vme_scc.c b/drivers/char/vme_scc.c
index 0e8234bd0e19..994e1a58b987 100644
--- a/drivers/char/vme_scc.c
+++ b/drivers/char/vme_scc.c
@@ -198,6 +198,7 @@ static void scc_init_portstructs(void)
 static int mvme147_scc_init(void)
 {
         struct scc_port *port;
+        int error;
 
         printk(KERN_INFO "SCC: MVME147 Serial Driver\n");
         /* Init channel A */
@@ -207,14 +208,23 @@ static int mvme147_scc_init(void)
         port->datap = port->ctrlp + 1;
         port->port_a = &scc_ports[0];
         port->port_b = &scc_ports[1];
-        request_irq(MVME147_IRQ_SCCA_TX, scc_tx_int, IRQF_DISABLED,
+        error = request_irq(MVME147_IRQ_SCCA_TX, scc_tx_int, IRQF_DISABLED,
                             "SCC-A TX", port);
-        request_irq(MVME147_IRQ_SCCA_STAT, scc_stat_int, IRQF_DISABLED,
+        if (error)
+                goto fail;
+        error = request_irq(MVME147_IRQ_SCCA_STAT, scc_stat_int, IRQF_DISABLED,
                             "SCC-A status", port);
-        request_irq(MVME147_IRQ_SCCA_RX, scc_rx_int, IRQF_DISABLED,
+        if (error)
+                goto fail_free_a_tx;
+        error = request_irq(MVME147_IRQ_SCCA_RX, scc_rx_int, IRQF_DISABLED,
                             "SCC-A RX", port);
-        request_irq(MVME147_IRQ_SCCA_SPCOND, scc_spcond_int, IRQF_DISABLED,
-                            "SCC-A special cond", port);
+        if (error)
+                goto fail_free_a_stat;
+        error = request_irq(MVME147_IRQ_SCCA_SPCOND, scc_spcond_int,
+                            IRQF_DISABLED, "SCC-A special cond", port);
+        if (error)
+                goto fail_free_a_rx;
+
         {
                 SCC_ACCESS_INIT(port);
 
@@ -234,14 +244,23 @@ static int mvme147_scc_init(void)
         port->datap = port->ctrlp + 1;
         port->port_a = &scc_ports[0];
         port->port_b = &scc_ports[1];
-        request_irq(MVME147_IRQ_SCCB_TX, scc_tx_int, IRQF_DISABLED,
+        error = request_irq(MVME147_IRQ_SCCB_TX, scc_tx_int, IRQF_DISABLED,
                             "SCC-B TX", port);
-        request_irq(MVME147_IRQ_SCCB_STAT, scc_stat_int, IRQF_DISABLED,
+        if (error)
+                goto fail_free_a_spcond;
+        error = request_irq(MVME147_IRQ_SCCB_STAT, scc_stat_int, IRQF_DISABLED,
                             "SCC-B status", port);
-        request_irq(MVME147_IRQ_SCCB_RX, scc_rx_int, IRQF_DISABLED,
+        if (error)
+                goto fail_free_b_tx;
+        error = request_irq(MVME147_IRQ_SCCB_RX, scc_rx_int, IRQF_DISABLED,
                             "SCC-B RX", port);
-        request_irq(MVME147_IRQ_SCCB_SPCOND, scc_spcond_int, IRQF_DISABLED,
-                            "SCC-B special cond", port);
+        if (error)
+                goto fail_free_b_stat;
+        error = request_irq(MVME147_IRQ_SCCB_SPCOND, scc_spcond_int,
+                            IRQF_DISABLED, "SCC-B special cond", port);
+        if (error)
+                goto fail_free_b_rx;
+
         {
                 SCC_ACCESS_INIT(port);
 
@@ -257,6 +276,23 @@ static int mvme147_scc_init(void)
         scc_init_drivers();
 
         return 0;
+
+fail_free_b_rx:
+        free_irq(MVME147_IRQ_SCCB_RX, port);
+fail_free_b_stat:
+        free_irq(MVME147_IRQ_SCCB_STAT, port);
+fail_free_b_tx:
+        free_irq(MVME147_IRQ_SCCB_TX, port);
+fail_free_a_spcond:
+        free_irq(MVME147_IRQ_SCCA_SPCOND, port);
+fail_free_a_rx:
+        free_irq(MVME147_IRQ_SCCA_RX, port);
+fail_free_a_stat:
+        free_irq(MVME147_IRQ_SCCA_STAT, port);
+fail_free_a_tx:
+        free_irq(MVME147_IRQ_SCCA_TX, port);
+fail:
+        return error;
 }
 #endif
 
@@ -265,6 +301,7 @@ static int mvme147_scc_init(void)
 static int mvme162_scc_init(void)
 {
         struct scc_port *port;
+        int error;
 
         if (!(mvme16x_config & MVME16x_CONFIG_GOT_SCCA))
                 return (-ENODEV);
@@ -277,14 +314,23 @@ static int mvme162_scc_init(void)
         port->datap = port->ctrlp + 2;
         port->port_a = &scc_ports[0];
         port->port_b = &scc_ports[1];
-        request_irq(MVME162_IRQ_SCCA_TX, scc_tx_int, IRQF_DISABLED,
+        error = request_irq(MVME162_IRQ_SCCA_TX, scc_tx_int, IRQF_DISABLED,
                             "SCC-A TX", port);
-        request_irq(MVME162_IRQ_SCCA_STAT, scc_stat_int, IRQF_DISABLED,
+        if (error)
+                goto fail;
+        error = request_irq(MVME162_IRQ_SCCA_STAT, scc_stat_int, IRQF_DISABLED,
                             "SCC-A status", port);
-        request_irq(MVME162_IRQ_SCCA_RX, scc_rx_int, IRQF_DISABLED,
+        if (error)
+                goto fail_free_a_tx;
+        error = request_irq(MVME162_IRQ_SCCA_RX, scc_rx_int, IRQF_DISABLED,
                             "SCC-A RX", port);
-        request_irq(MVME162_IRQ_SCCA_SPCOND, scc_spcond_int, IRQF_DISABLED,
-                            "SCC-A special cond", port);
+        if (error)
+                goto fail_free_a_stat;
+        error = request_irq(MVME162_IRQ_SCCA_SPCOND, scc_spcond_int,
+                            IRQF_DISABLED, "SCC-A special cond", port);
+        if (error)
+                goto fail_free_a_rx;
+
         {
                 SCC_ACCESS_INIT(port);
 
@@ -304,14 +350,22 @@ static int mvme162_scc_init(void)
         port->datap = port->ctrlp + 2;
         port->port_a = &scc_ports[0];
         port->port_b = &scc_ports[1];
-        request_irq(MVME162_IRQ_SCCB_TX, scc_tx_int, IRQF_DISABLED,
+        error = request_irq(MVME162_IRQ_SCCB_TX, scc_tx_int, IRQF_DISABLED,
                             "SCC-B TX", port);
-        request_irq(MVME162_IRQ_SCCB_STAT, scc_stat_int, IRQF_DISABLED,
+        if (error)
+                goto fail_free_a_spcond;
+        error = request_irq(MVME162_IRQ_SCCB_STAT, scc_stat_int, IRQF_DISABLED,
                             "SCC-B status", port);
-        request_irq(MVME162_IRQ_SCCB_RX, scc_rx_int, IRQF_DISABLED,
+        if (error)
+                goto fail_free_b_tx;
+        error = request_irq(MVME162_IRQ_SCCB_RX, scc_rx_int, IRQF_DISABLED,
                             "SCC-B RX", port);
-        request_irq(MVME162_IRQ_SCCB_SPCOND, scc_spcond_int, IRQF_DISABLED,
-                            "SCC-B special cond", port);
+        if (error)
+                goto fail_free_b_stat;
+        error = request_irq(MVME162_IRQ_SCCB_SPCOND, scc_spcond_int,
+                            IRQF_DISABLED, "SCC-B special cond", port);
+        if (error)
+                goto fail_free_b_rx;
 
         {
                 SCC_ACCESS_INIT(port);  /* Either channel will do */
@@ -328,6 +382,23 @@ static int mvme162_scc_init(void)
         scc_init_drivers();
 
         return 0;
+
+fail_free_b_rx:
+        free_irq(MVME162_IRQ_SCCB_RX, port);
+fail_free_b_stat:
+        free_irq(MVME162_IRQ_SCCB_STAT, port);
+fail_free_b_tx:
+        free_irq(MVME162_IRQ_SCCB_TX, port);
+fail_free_a_spcond:
+        free_irq(MVME162_IRQ_SCCA_SPCOND, port);
+fail_free_a_rx:
+        free_irq(MVME162_IRQ_SCCA_RX, port);
+fail_free_a_stat:
+        free_irq(MVME162_IRQ_SCCA_STAT, port);
+fail_free_a_tx:
+        free_irq(MVME162_IRQ_SCCA_TX, port);
+fail:
+        return error;
 }
 #endif
 
@@ -336,6 +407,7 @@ static int mvme162_scc_init(void)
 static int bvme6000_scc_init(void)
 {
         struct scc_port *port;
+        int error;
 
         printk(KERN_INFO "SCC: BVME6000 Serial Driver\n");
         /* Init channel A */
@@ -345,14 +417,23 @@ static int bvme6000_scc_init(void)
         port->datap = port->ctrlp + 4;
         port->port_a = &scc_ports[0];
         port->port_b = &scc_ports[1];
-        request_irq(BVME_IRQ_SCCA_TX, scc_tx_int, IRQF_DISABLED,
+        error = request_irq(BVME_IRQ_SCCA_TX, scc_tx_int, IRQF_DISABLED,
                             "SCC-A TX", port);
-        request_irq(BVME_IRQ_SCCA_STAT, scc_stat_int, IRQF_DISABLED,
+        if (error)
+                goto fail;
+        error = request_irq(BVME_IRQ_SCCA_STAT, scc_stat_int, IRQF_DISABLED,
                             "SCC-A status", port);
-        request_irq(BVME_IRQ_SCCA_RX, scc_rx_int, IRQF_DISABLED,
+        if (error)
+                goto fail_free_a_tx;
+        error = request_irq(BVME_IRQ_SCCA_RX, scc_rx_int, IRQF_DISABLED,
                             "SCC-A RX", port);
-        request_irq(BVME_IRQ_SCCA_SPCOND, scc_spcond_int, IRQF_DISABLED,
-                            "SCC-A special cond", port);
+        if (error)
+                goto fail_free_a_stat;
+        error = request_irq(BVME_IRQ_SCCA_SPCOND, scc_spcond_int,
+                            IRQF_DISABLED, "SCC-A special cond", port);
+        if (error)
+                goto fail_free_a_rx;
+
         {
                 SCC_ACCESS_INIT(port);
 
@@ -372,14 +453,22 @@ static int bvme6000_scc_init(void)
         port->datap = port->ctrlp + 4;
         port->port_a = &scc_ports[0];
         port->port_b = &scc_ports[1];
-        request_irq(BVME_IRQ_SCCB_TX, scc_tx_int, IRQF_DISABLED,
+        error = request_irq(BVME_IRQ_SCCB_TX, scc_tx_int, IRQF_DISABLED,
                             "SCC-B TX", port);
-        request_irq(BVME_IRQ_SCCB_STAT, scc_stat_int, IRQF_DISABLED,
+        if (error)
+                goto fail_free_a_spcond;
+        error = request_irq(BVME_IRQ_SCCB_STAT, scc_stat_int, IRQF_DISABLED,
                             "SCC-B status", port);
-        request_irq(BVME_IRQ_SCCB_RX, scc_rx_int, IRQF_DISABLED,
+        if (error)
+                goto fail_free_b_tx;
+        error = request_irq(BVME_IRQ_SCCB_RX, scc_rx_int, IRQF_DISABLED,
                             "SCC-B RX", port);
-        request_irq(BVME_IRQ_SCCB_SPCOND, scc_spcond_int, IRQF_DISABLED,
-                            "SCC-B special cond", port);
+        if (error)
+                goto fail_free_b_stat;
+        error = request_irq(BVME_IRQ_SCCB_SPCOND, scc_spcond_int,
+                            IRQF_DISABLED, "SCC-B special cond", port);
+        if (error)
+                goto fail_free_b_rx;
 
         {
                 SCC_ACCESS_INIT(port);  /* Either channel will do */
@@ -393,6 +482,23 @@ static int bvme6000_scc_init(void)
         scc_init_drivers();
 
         return 0;
+
+fail:
+        free_irq(BVME_IRQ_SCCA_STAT, port);
+fail_free_a_tx:
+        free_irq(BVME_IRQ_SCCA_RX, port);
+fail_free_a_stat:
+        free_irq(BVME_IRQ_SCCA_SPCOND, port);
+fail_free_a_rx:
+        free_irq(BVME_IRQ_SCCB_TX, port);
+fail_free_a_spcond:
+        free_irq(BVME_IRQ_SCCB_STAT, port);
+fail_free_b_tx:
+        free_irq(BVME_IRQ_SCCB_RX, port);
+fail_free_b_stat:
+        free_irq(BVME_IRQ_SCCB_SPCOND, port);
+fail_free_b_rx:
+        return error;
 }
 #endif