aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/char
diff options
context:
space:
mode:
authorAlan Cox <alan@lxorguk.ukuu.org.uk>2007-07-16 02:41:48 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-07-16 12:05:51 -0400
commitde1764af27520f6dfdac0ddf2209d78ddb9690d7 (patch)
tree124f3eb29239bb9eef109cd2d2fab1c8df829676 /drivers/char
parent35426128adaacf8cdabc2482598252d488b7ccb9 (diff)
synclink: remove bogus 'no change' termios optimisation from synclink drivers
Again this check is wrong now, and un-needed Signed-off-by: Alan Cox <alan@redhat.com> Cc: Paul Fulghum <paulkf@microgate.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/synclink.c8
-rw-r--r--drivers/char/synclink_gt.c8
-rw-r--r--drivers/char/synclinkmp.c8
3 files changed, 0 insertions, 24 deletions
diff --git a/drivers/char/synclink.c b/drivers/char/synclink.c
index f02a0795983f..f53e51ddb9d7 100644
--- a/drivers/char/synclink.c
+++ b/drivers/char/synclink.c
@@ -160,8 +160,6 @@ typedef struct _DMABUFFERENTRY
160 160
161#define IO_PIN_SHUTDOWN_LIMIT 100 161#define IO_PIN_SHUTDOWN_LIMIT 100
162 162
163#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))
164
165struct _input_signal_events { 163struct _input_signal_events {
166 int ri_up; 164 int ri_up;
167 int ri_down; 165 int ri_down;
@@ -3064,12 +3062,6 @@ static void mgsl_set_termios(struct tty_struct *tty, struct ktermios *old_termio
3064 printk("%s(%d):mgsl_set_termios %s\n", __FILE__,__LINE__, 3062 printk("%s(%d):mgsl_set_termios %s\n", __FILE__,__LINE__,
3065 tty->driver->name ); 3063 tty->driver->name );
3066 3064
3067 /* just return if nothing has changed */
3068 if ((tty->termios->c_cflag == old_termios->c_cflag)
3069 && (RELEVANT_IFLAG(tty->termios->c_iflag)
3070 == RELEVANT_IFLAG(old_termios->c_iflag)))
3071 return;
3072
3073 mgsl_change_params(info); 3065 mgsl_change_params(info);
3074 3066
3075 /* Handle transition to B0 status */ 3067 /* Handle transition to B0 status */
diff --git a/drivers/char/synclink_gt.c b/drivers/char/synclink_gt.c
index 02b49bc00028..428b514201f4 100644
--- a/drivers/char/synclink_gt.c
+++ b/drivers/char/synclink_gt.c
@@ -144,8 +144,6 @@ MODULE_PARM_DESC(dosyncppp, "Enable synchronous net device, 0=disable 1=enable")
144/* 144/*
145 * tty support and callbacks 145 * tty support and callbacks
146 */ 146 */
147#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))
148
149static struct tty_driver *serial_driver; 147static struct tty_driver *serial_driver;
150 148
151static int open(struct tty_struct *tty, struct file * filp); 149static int open(struct tty_struct *tty, struct file * filp);
@@ -823,12 +821,6 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)
823 821
824 DBGINFO(("%s set_termios\n", tty->driver->name)); 822 DBGINFO(("%s set_termios\n", tty->driver->name));
825 823
826 /* just return if nothing has changed */
827 if ((tty->termios->c_cflag == old_termios->c_cflag)
828 && (RELEVANT_IFLAG(tty->termios->c_iflag)
829 == RELEVANT_IFLAG(old_termios->c_iflag)))
830 return;
831
832 change_params(info); 824 change_params(info);
833 825
834 /* Handle transition to B0 status */ 826 /* Handle transition to B0 status */
diff --git a/drivers/char/synclinkmp.c b/drivers/char/synclinkmp.c
index ef93d055bdd7..a65407b32079 100644
--- a/drivers/char/synclinkmp.c
+++ b/drivers/char/synclinkmp.c
@@ -135,8 +135,6 @@ typedef struct _SCADESC_EX
135 135
136#define IO_PIN_SHUTDOWN_LIMIT 100 136#define IO_PIN_SHUTDOWN_LIMIT 100
137 137
138#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))
139
140struct _input_signal_events { 138struct _input_signal_events {
141 int ri_up; 139 int ri_up;
142 int ri_down; 140 int ri_down;
@@ -927,12 +925,6 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)
927 printk("%s(%d):%s set_termios()\n", __FILE__,__LINE__, 925 printk("%s(%d):%s set_termios()\n", __FILE__,__LINE__,
928 tty->driver->name ); 926 tty->driver->name );
929 927
930 /* just return if nothing has changed */
931 if ((tty->termios->c_cflag == old_termios->c_cflag)
932 && (RELEVANT_IFLAG(tty->termios->c_iflag)
933 == RELEVANT_IFLAG(old_termios->c_iflag)))
934 return;
935
936 change_params(info); 928 change_params(info);
937 929
938 /* Handle transition to B0 status */ 930 /* Handle transition to B0 status */