diff options
author | Eric Sesterhenn <snakebyte@gmx.de> | 2006-06-25 08:48:45 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-25 13:01:17 -0400 |
commit | 969dd061d81d9e2bc7f954859452ac81cc639711 (patch) | |
tree | fa6a75db7d19d56de9720716dfc7f688061b3e5e /drivers/char | |
parent | 2aa92581fb13e04e1440e5041b412cc06c782e0e (diff) |
[PATCH] Cyclades Cleanup
coverity choked at two !tty checks, in places where tty can never be NULL.
Since it removes some code we should remove these checks. (Coverity ids
#763,#762)
[akpm@osdl.org: even cleaner!]
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/char')
-rw-r--r-- | drivers/char/cyclades.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c index cc7acf877dc0..122e7a72a4e1 100644 --- a/drivers/char/cyclades.c +++ b/drivers/char/cyclades.c | |||
@@ -2833,9 +2833,8 @@ cy_write(struct tty_struct * tty, const unsigned char *buf, int count) | |||
2833 | return 0; | 2833 | return 0; |
2834 | } | 2834 | } |
2835 | 2835 | ||
2836 | if (!tty || !info->xmit_buf || !tmp_buf){ | 2836 | if (!info->xmit_buf || !tmp_buf) |
2837 | return 0; | 2837 | return 0; |
2838 | } | ||
2839 | 2838 | ||
2840 | CY_LOCK(info, flags); | 2839 | CY_LOCK(info, flags); |
2841 | while (1) { | 2840 | while (1) { |
@@ -2884,7 +2883,7 @@ cy_put_char(struct tty_struct *tty, unsigned char ch) | |||
2884 | if (serial_paranoia_check(info, tty->name, "cy_put_char")) | 2883 | if (serial_paranoia_check(info, tty->name, "cy_put_char")) |
2885 | return; | 2884 | return; |
2886 | 2885 | ||
2887 | if (!tty || !info->xmit_buf) | 2886 | if (!info->xmit_buf) |
2888 | return; | 2887 | return; |
2889 | 2888 | ||
2890 | CY_LOCK(info, flags); | 2889 | CY_LOCK(info, flags); |