[WATCHDOG] timers cleanup

- Use timer macros to set function and data members and to modify
  expiration time.
- Use DEFINE_TIMER for single (platform dependent) watchdog timers and
  do not init them at run-time in these cases.
- del_timer_sync is common in most cases -- we want to wait for timer
  function if it's still running.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Steve Hill <steve@navaho.co.uk>
Cc: Heiko Ronsdorf <hero@ihg.uni-duisburg.de>
Cc: Fernando Fuganti <fuganti@conectiva.com.br>
Cc: Gergely Madarasz <gorgo@itc.hu>
Cc: Ken Hollis <khollis@bitgate.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

1 files changed, 4 insertions, 9 deletions

diff --git a/drivers/char/watchdog/cpu5wdt.c b/drivers/char/watchdog/cpu5wdt.c
index 00bdabb90f27..bcd7e36ca0aa 100644
--- a/drivers/char/watchdog/cpu5wdt.c
+++ b/drivers/char/watchdog/cpu5wdt.c
@@ -80,10 +80,8 @@ static void cpu5wdt_trigger(unsigned long unused)
         outb(1, port + CPU5WDT_TRIGGER_REG);
 
         /* requeue?? */
-        if( cpu5wdt_device.queue && ticks ) {
-                cpu5wdt_device.timer.expires = jiffies + CPU5WDT_INTERVAL;
-                add_timer(&cpu5wdt_device.timer);
-        }
+        if (cpu5wdt_device.queue && ticks)
+                mod_timer(&cpu5wdt_device.timer, jiffies + CPU5WDT_INTERVAL);
         else {
                 /* ticks doesn't matter anyway */
                 complete(&cpu5wdt_device.stop);
@@ -109,8 +107,7 @@ static void cpu5wdt_start(void)
                 outb(1, port + CPU5WDT_MODE_REG);
                 outb(0, port + CPU5WDT_RESET_REG);
                 outb(0, port + CPU5WDT_ENABLE_REG);
-                cpu5wdt_device.timer.expires = jiffies + CPU5WDT_INTERVAL;
-                add_timer(&cpu5wdt_device.timer);
+                mod_timer(&cpu5wdt_device.timer, jiffies + CPU5WDT_INTERVAL);
         }
         /* if process dies, counter is not decremented */
         cpu5wdt_device.running++;
@@ -245,9 +242,7 @@ static int __devinit cpu5wdt_init(void)
 
         clear_bit(0, &cpu5wdt_device.inuse);
 
-        init_timer(&cpu5wdt_device.timer);
-        cpu5wdt_device.timer.function = cpu5wdt_trigger;
-        cpu5wdt_device.timer.data = 0;
+        setup_timer(&cpu5wdt_device.timer, cpu5wdt_trigger, 0);
 
         cpu5wdt_device.default_ticks = ticks;