diff options
author | Pavel Emelianov <xemul@openvz.org> | 2007-10-19 02:39:46 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-19 14:53:37 -0400 |
commit | a47afb0f9d794d525a372c8d69902147cc88222a (patch) | |
tree | 7bd67280e2edc1c3b1803d4a93bee794088e9342 /drivers/char/tty_io.c | |
parent | 858d72ead4864da0fb0b89b919524125ce998e27 (diff) |
pid namespaces: round up the API
The set of functions process_session, task_session, process_group and
task_pgrp is confusing, as the names can be mixed with each other when looking
at the code for a long time.
The proposals are to
* equip the functions that return the integer with _nr suffix to
represent that fact,
* and to make all functions work with task (not process) by making
the common prefix of the same name.
For monotony the routines signal_session() and set_signal_session() are
replaced with task_session_nr() and set_task_session(), especially since they
are only used with the explicit task->signal dereference.
Signed-off-by: Pavel Emelianov <xemul@openvz.org>
Acked-by: Serge E. Hallyn <serue@us.ibm.com>
Cc: Kirill Korotaev <dev@openvz.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Cedric Le Goater <clg@fr.ibm.com>
Cc: Herbert Poetzl <herbert@13thfloor.at>
Cc: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/tty_io.c')
-rw-r--r-- | drivers/char/tty_io.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c index 9c867cf6de64..9820f86831ee 100644 --- a/drivers/char/tty_io.c +++ b/drivers/char/tty_io.c | |||
@@ -3528,7 +3528,7 @@ void __do_SAK(struct tty_struct *tty) | |||
3528 | /* Kill the entire session */ | 3528 | /* Kill the entire session */ |
3529 | do_each_pid_task(session, PIDTYPE_SID, p) { | 3529 | do_each_pid_task(session, PIDTYPE_SID, p) { |
3530 | printk(KERN_NOTICE "SAK: killed process %d" | 3530 | printk(KERN_NOTICE "SAK: killed process %d" |
3531 | " (%s): process_session(p)==tty->session\n", | 3531 | " (%s): task_session_nr(p)==tty->session\n", |
3532 | p->pid, p->comm); | 3532 | p->pid, p->comm); |
3533 | send_sig(SIGKILL, p, 1); | 3533 | send_sig(SIGKILL, p, 1); |
3534 | } while_each_pid_task(session, PIDTYPE_SID, p); | 3534 | } while_each_pid_task(session, PIDTYPE_SID, p); |
@@ -3538,7 +3538,7 @@ void __do_SAK(struct tty_struct *tty) | |||
3538 | do_each_thread(g, p) { | 3538 | do_each_thread(g, p) { |
3539 | if (p->signal->tty == tty) { | 3539 | if (p->signal->tty == tty) { |
3540 | printk(KERN_NOTICE "SAK: killed process %d" | 3540 | printk(KERN_NOTICE "SAK: killed process %d" |
3541 | " (%s): process_session(p)==tty->session\n", | 3541 | " (%s): task_session_nr(p)==tty->session\n", |
3542 | p->pid, p->comm); | 3542 | p->pid, p->comm); |
3543 | send_sig(SIGKILL, p, 1); | 3543 | send_sig(SIGKILL, p, 1); |
3544 | continue; | 3544 | continue; |