diff options
author | Peter Huewe <PeterHuewe@gmx.de> | 2013-10-29 20:40:28 -0400 |
---|---|---|
committer | Peter Huewe <peterhuewe@gmx.de> | 2014-01-06 08:37:23 -0500 |
commit | 238b1eaa59e6a8e2993af0db9ec2255bfa53927b (patch) | |
tree | b332688b47a875a7d3d82585db36f4540b7bc5b8 /drivers/char/tpm | |
parent | 747d35bd9bb4ae6bd74b19baa5bbe32f3e0cee11 (diff) |
tpm/tpm_ppi: Check return value of acpi_get_name
If
status = acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer);
fails for whatever reason and does not return AE_OK
if (strstr(buffer.pointer, context) != NULL) {
does dereference a null pointer.
-> Check the return value and return the status to the caller
Found by coverity
Cc: stable@vger.kernel.org
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Diffstat (limited to 'drivers/char/tpm')
-rw-r--r-- | drivers/char/tpm/tpm_ppi.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/char/tpm/tpm_ppi.c b/drivers/char/tpm/tpm_ppi.c index 18c5810b646b..6ac9d275b732 100644 --- a/drivers/char/tpm/tpm_ppi.c +++ b/drivers/char/tpm/tpm_ppi.c | |||
@@ -30,6 +30,9 @@ static acpi_status ppi_callback(acpi_handle handle, u32 level, void *context, | |||
30 | acpi_status status; | 30 | acpi_status status; |
31 | struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL }; | 31 | struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL }; |
32 | status = acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer); | 32 | status = acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer); |
33 | if (ACPI_FAILURE(status)) | ||
34 | return status; | ||
35 | |||
33 | if (strstr(buffer.pointer, context) != NULL) { | 36 | if (strstr(buffer.pointer, context) != NULL) { |
34 | *return_value = handle; | 37 | *return_value = handle; |
35 | kfree(buffer.pointer); | 38 | kfree(buffer.pointer); |