diff options
author | Kylene Hall <kjhall@us.ibm.com> | 2005-06-24 01:01:48 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-06-24 03:05:24 -0400 |
commit | 3122a88a242454efe72930e56a3e4d56ee534f3c (patch) | |
tree | 123d3c91c303d77702b392b7ac136312eb0b7ec2 /drivers/char/tpm/tpm_atmel.c | |
parent | 700d8bdcd0fa815b08638b1e4d43b66d60cc6a8d (diff) |
[PATCH] tpm: Fix concerns with TPM driver -- use enums
Convert #defines to named enums where that preference has been indicated by
other kernel developers.
Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/char/tpm/tpm_atmel.c')
-rw-r--r-- | drivers/char/tpm/tpm_atmel.c | 21 |
1 files changed, 13 insertions, 8 deletions
diff --git a/drivers/char/tpm/tpm_atmel.c b/drivers/char/tpm/tpm_atmel.c index f9333e729b62..3271391892e8 100644 --- a/drivers/char/tpm/tpm_atmel.c +++ b/drivers/char/tpm/tpm_atmel.c | |||
@@ -22,17 +22,22 @@ | |||
22 | #include "tpm.h" | 22 | #include "tpm.h" |
23 | 23 | ||
24 | /* Atmel definitions */ | 24 | /* Atmel definitions */ |
25 | #define TPM_ATML_BASE 0x400 | 25 | enum tpm_atmel_addr{ |
26 | TPM_ATML_BASE = 0x400 | ||
27 | }; | ||
26 | 28 | ||
27 | /* write status bits */ | 29 | /* write status bits */ |
28 | #define ATML_STATUS_ABORT 0x01 | 30 | enum tpm_atmel_write_status { |
29 | #define ATML_STATUS_LASTBYTE 0x04 | 31 | ATML_STATUS_ABORT = 0x01, |
30 | 32 | ATML_STATUS_LASTBYTE = 0x04 | |
33 | }; | ||
31 | /* read status bits */ | 34 | /* read status bits */ |
32 | #define ATML_STATUS_BUSY 0x01 | 35 | enum tpm_atmel_read_status { |
33 | #define ATML_STATUS_DATA_AVAIL 0x02 | 36 | ATML_STATUS_BUSY = 0x01, |
34 | #define ATML_STATUS_REWRITE 0x04 | 37 | ATML_STATUS_DATA_AVAIL = 0x02, |
35 | 38 | ATML_STATUS_REWRITE = 0x04, | |
39 | ATML_STATUS_READY = 0x08 | ||
40 | }; | ||
36 | 41 | ||
37 | static int tpm_atml_recv(struct tpm_chip *chip, u8 * buf, size_t count) | 42 | static int tpm_atml_recv(struct tpm_chip *chip, u8 * buf, size_t count) |
38 | { | 43 | { |