aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/char/synclinkmp.c
diff options
context:
space:
mode:
authorJeff Garzik <jeff@garzik.org>2007-10-31 05:20:49 -0400
committerJeff Garzik <jgarzik@redhat.com>2008-04-20 19:03:43 -0400
commita6f97b293b08877d945ea3f28926aa446dd7ca2e (patch)
tree8e2c2e585ef056d36023dfb384b2806bebf312d3 /drivers/char/synclinkmp.c
parente8f39549580e04e0b8edd11bae834ae7f8322fc8 (diff)
drivers/char: minor irq handler cleanups
- remove always-false tests - don't overload 'irq' argument, pass data properly via dev_id - remove pointless casts from void* Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/char/synclinkmp.c')
-rw-r--r--drivers/char/synclinkmp.c22
1 files changed, 9 insertions, 13 deletions
diff --git a/drivers/char/synclinkmp.c b/drivers/char/synclinkmp.c
index f3e7807f78d9..c96062ea72b4 100644
--- a/drivers/char/synclinkmp.c
+++ b/drivers/char/synclinkmp.c
@@ -2586,9 +2586,9 @@ void isr_io_pin( SLMP_INFO *info, u16 status )
2586 * dev_id device ID supplied during interrupt registration 2586 * dev_id device ID supplied during interrupt registration
2587 * regs interrupted processor context 2587 * regs interrupted processor context
2588 */ 2588 */
2589static irqreturn_t synclinkmp_interrupt(int irq, void *dev_id) 2589static irqreturn_t synclinkmp_interrupt(int dummy, void *dev_id)
2590{ 2590{
2591 SLMP_INFO * info; 2591 SLMP_INFO *info = dev_id;
2592 unsigned char status, status0, status1=0; 2592 unsigned char status, status0, status1=0;
2593 unsigned char dmastatus, dmastatus0, dmastatus1=0; 2593 unsigned char dmastatus, dmastatus0, dmastatus1=0;
2594 unsigned char timerstatus0, timerstatus1=0; 2594 unsigned char timerstatus0, timerstatus1=0;
@@ -2597,12 +2597,8 @@ static irqreturn_t synclinkmp_interrupt(int irq, void *dev_id)
2597 unsigned short tmp; 2597 unsigned short tmp;
2598 2598
2599 if ( debug_level >= DEBUG_LEVEL_ISR ) 2599 if ( debug_level >= DEBUG_LEVEL_ISR )
2600 printk("%s(%d): synclinkmp_interrupt(%d)entry.\n", 2600 printk(KERN_DEBUG "%s(%d): synclinkmp_interrupt(%d)entry.\n",
2601 __FILE__,__LINE__,irq); 2601 __FILE__, __LINE__, info->irq_level);
2602
2603 info = (SLMP_INFO *)dev_id;
2604 if (!info)
2605 return IRQ_NONE;
2606 2602
2607 spin_lock(&info->lock); 2603 spin_lock(&info->lock);
2608 2604
@@ -2615,9 +2611,9 @@ static irqreturn_t synclinkmp_interrupt(int irq, void *dev_id)
2615 timerstatus0 = read_reg(info, ISR2); 2611 timerstatus0 = read_reg(info, ISR2);
2616 2612
2617 if ( debug_level >= DEBUG_LEVEL_ISR ) 2613 if ( debug_level >= DEBUG_LEVEL_ISR )
2618 printk("%s(%d):%s status0=%02x, dmastatus0=%02x, timerstatus0=%02x\n", 2614 printk(KERN_DEBUG "%s(%d):%s status0=%02x, dmastatus0=%02x, timerstatus0=%02x\n",
2619 __FILE__,__LINE__,info->device_name, 2615 __FILE__, __LINE__, info->device_name,
2620 status0,dmastatus0,timerstatus0); 2616 status0, dmastatus0, timerstatus0);
2621 2617
2622 if (info->port_count == 4) { 2618 if (info->port_count == 4) {
2623 /* get status for SCA1 (ports 2-3) */ 2619 /* get status for SCA1 (ports 2-3) */
@@ -2702,8 +2698,8 @@ static irqreturn_t synclinkmp_interrupt(int irq, void *dev_id)
2702 spin_unlock(&info->lock); 2698 spin_unlock(&info->lock);
2703 2699
2704 if ( debug_level >= DEBUG_LEVEL_ISR ) 2700 if ( debug_level >= DEBUG_LEVEL_ISR )
2705 printk("%s(%d):synclinkmp_interrupt(%d)exit.\n", 2701 printk(KERN_DEBUG "%s(%d):synclinkmp_interrupt(%d)exit.\n",
2706 __FILE__,__LINE__,irq); 2702 __FILE__, __LINE__, info->irq_level);
2707 return IRQ_HANDLED; 2703 return IRQ_HANDLED;
2708} 2704}
2709 2705