diff options
author | Eric Sesterhenn <snakebyte@gmx.de> | 2006-06-25 08:48:48 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-25 13:01:19 -0400 |
commit | 326f28e9ec4b2619c2fd410593fc95fcb0ba6b41 (patch) | |
tree | 2a11507d8ab266b1f0eac6d3b3f37e9d18ddec5d /drivers/char/synclinkmp.c | |
parent | fa791f5bdfa026a9abe1b48934943fd39f1e300b (diff) |
[PATCH] More !tty cleanups in drivers/char
Another bunch of checks in the char drivers .put_char() and .write()
routines, where tty can never be NULL. This patch removes these checks to
save some code. Coverity choked at those with the following bug ids:
isicom.c 767, 766
specialix.c 773, 774
synclink_cs.c 779, 781
synclink_gt.c 784, 785
synclinkmp.c 784, 785
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Cc: Paul Fulghum <paulkf@microgate.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/char/synclinkmp.c')
-rw-r--r-- | drivers/char/synclinkmp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/char/synclinkmp.c b/drivers/char/synclinkmp.c index 858740131115..21bf15ad9980 100644 --- a/drivers/char/synclinkmp.c +++ b/drivers/char/synclinkmp.c | |||
@@ -988,7 +988,7 @@ static int write(struct tty_struct *tty, | |||
988 | if (sanity_check(info, tty->name, "write")) | 988 | if (sanity_check(info, tty->name, "write")) |
989 | goto cleanup; | 989 | goto cleanup; |
990 | 990 | ||
991 | if (!tty || !info->tx_buf) | 991 | if (!info->tx_buf) |
992 | goto cleanup; | 992 | goto cleanup; |
993 | 993 | ||
994 | if (info->params.mode == MGSL_MODE_HDLC) { | 994 | if (info->params.mode == MGSL_MODE_HDLC) { |
@@ -1067,7 +1067,7 @@ static void put_char(struct tty_struct *tty, unsigned char ch) | |||
1067 | if (sanity_check(info, tty->name, "put_char")) | 1067 | if (sanity_check(info, tty->name, "put_char")) |
1068 | return; | 1068 | return; |
1069 | 1069 | ||
1070 | if (!tty || !info->tx_buf) | 1070 | if (!info->tx_buf) |
1071 | return; | 1071 | return; |
1072 | 1072 | ||
1073 | spin_lock_irqsave(&info->lock,flags); | 1073 | spin_lock_irqsave(&info->lock,flags); |