diff options
author | Eric Sesterhenn <snakebyte@gmx.de> | 2006-06-25 08:48:48 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-25 13:01:19 -0400 |
commit | 326f28e9ec4b2619c2fd410593fc95fcb0ba6b41 (patch) | |
tree | 2a11507d8ab266b1f0eac6d3b3f37e9d18ddec5d /drivers/char/specialix.c | |
parent | fa791f5bdfa026a9abe1b48934943fd39f1e300b (diff) |
[PATCH] More !tty cleanups in drivers/char
Another bunch of checks in the char drivers .put_char() and .write()
routines, where tty can never be NULL. This patch removes these checks to
save some code. Coverity choked at those with the following bug ids:
isicom.c 767, 766
specialix.c 773, 774
synclink_cs.c 779, 781
synclink_gt.c 784, 785
synclinkmp.c 784, 785
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Cc: Paul Fulghum <paulkf@microgate.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/char/specialix.c')
-rw-r--r-- | drivers/char/specialix.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/char/specialix.c b/drivers/char/specialix.c index 5343e9fc6ab7..1b5330299e30 100644 --- a/drivers/char/specialix.c +++ b/drivers/char/specialix.c | |||
@@ -1683,7 +1683,7 @@ static int sx_write(struct tty_struct * tty, | |||
1683 | 1683 | ||
1684 | bp = port_Board(port); | 1684 | bp = port_Board(port); |
1685 | 1685 | ||
1686 | if (!tty || !port->xmit_buf || !tmp_buf) { | 1686 | if (!port->xmit_buf || !tmp_buf) { |
1687 | func_exit(); | 1687 | func_exit(); |
1688 | return 0; | 1688 | return 0; |
1689 | } | 1689 | } |
@@ -1733,7 +1733,7 @@ static void sx_put_char(struct tty_struct * tty, unsigned char ch) | |||
1733 | return; | 1733 | return; |
1734 | } | 1734 | } |
1735 | dprintk (SX_DEBUG_TX, "check tty: %p %p\n", tty, port->xmit_buf); | 1735 | dprintk (SX_DEBUG_TX, "check tty: %p %p\n", tty, port->xmit_buf); |
1736 | if (!tty || !port->xmit_buf) { | 1736 | if (!port->xmit_buf) { |
1737 | func_exit(); | 1737 | func_exit(); |
1738 | return; | 1738 | return; |
1739 | } | 1739 | } |