aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/char/pc8736x_gpio.c
diff options
context:
space:
mode:
authorJim Cromie <jim.cromie@gmail.com>2006-06-27 05:54:23 -0400
committerLinus Torvalds <torvalds@g5.osdl.org>2006-06-27 20:32:43 -0400
commitf31000e573da052b6b8bcc21faff520b4e2eda7a (patch)
tree670d5e6e00da615f70d99a950cfe7b8603edad26 /drivers/char/pc8736x_gpio.c
parent58b087cda1e9e46c7061c2282f92bd8e1970bfe7 (diff)
[PATCH] chardev: GPIO for SCx200 & PC-8736x: use dev_dbg in common module
Use of dev_dbg() and friends is considered good practice. dev_dbg() needs a struct device *devp, but nsc_gpio is only a helper module, so it doesnt have/need its own. To provide devp to the user-modules (scx200 & pc8736x _gpio), we add it to the vtable, and set it during init. Also squeeze nsc_gpio_dump()'s format a little. [ 199.259879] pc8736x_gpio.0: io09: 0x0044 TS OD PUE EDGE LO DEBOUNCE Signed-off-by: Jim Cromie <jim.cromie@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/char/pc8736x_gpio.c')
-rw-r--r--drivers/char/pc8736x_gpio.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/char/pc8736x_gpio.c b/drivers/char/pc8736x_gpio.c
index b16fbef816c2..48ff1fc8b06d 100644
--- a/drivers/char/pc8736x_gpio.c
+++ b/drivers/char/pc8736x_gpio.c
@@ -207,8 +207,6 @@ static void pc8736x_gpio_change(unsigned index)
207 pc8736x_gpio_set(index, !pc8736x_gpio_get(index)); 207 pc8736x_gpio_set(index, !pc8736x_gpio_get(index));
208} 208}
209 209
210extern void nsc_gpio_dump(unsigned iminor);
211
212static struct nsc_gpio_ops pc8736x_access = { 210static struct nsc_gpio_ops pc8736x_access = {
213 .owner = THIS_MODULE, 211 .owner = THIS_MODULE,
214 .gpio_config = pc8736x_gpio_configure, 212 .gpio_config = pc8736x_gpio_configure,
@@ -260,6 +258,7 @@ static int __init pc8736x_gpio_init(void)
260 dev_err(&pdev->dev, "no device found\n"); 258 dev_err(&pdev->dev, "no device found\n");
261 goto undo_platform_dev_add; 259 goto undo_platform_dev_add;
262 } 260 }
261 pc8736x_access.dev = &pdev->dev;
263 262
264 /* Verify that chip and it's GPIO unit are both enabled. 263 /* Verify that chip and it's GPIO unit are both enabled.
265 My BIOS does this, so I take minimum action here 264 My BIOS does this, so I take minimum action here