diff options
author | Nick Piggin <npiggin@suse.de> | 2008-02-01 21:08:53 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-02-04 10:55:38 -0500 |
commit | 2f98735c9c24ea1f0d40a364d4e63611b689b795 (patch) | |
tree | a42b3802449af474d36cda3b6f9fb190a717defb /drivers/char/mspec.c | |
parent | fe2528b96b02173395f5a75e37714c07f3e25e73 (diff) |
vm audit: add VM_DONTEXPAND to mmap for drivers that need it
Drivers that register a ->fault handler, but do not range-check the
offset argument, must set VM_DONTEXPAND in the vm_flags in order to
prevent an expanding mremap from overflowing the resource.
I've audited the tree and attempted to fix these problems (usually by
adding VM_DONTEXPAND where it is not obvious).
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/mspec.c')
-rw-r--r-- | drivers/char/mspec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/mspec.c b/drivers/char/mspec.c index 82f2e27dca7d..ff146c2b08fd 100644 --- a/drivers/char/mspec.c +++ b/drivers/char/mspec.c | |||
@@ -283,7 +283,7 @@ mspec_mmap(struct file *file, struct vm_area_struct *vma, | |||
283 | vdata->refcnt = ATOMIC_INIT(1); | 283 | vdata->refcnt = ATOMIC_INIT(1); |
284 | vma->vm_private_data = vdata; | 284 | vma->vm_private_data = vdata; |
285 | 285 | ||
286 | vma->vm_flags |= (VM_IO | VM_RESERVED | VM_PFNMAP); | 286 | vma->vm_flags |= (VM_IO | VM_RESERVED | VM_PFNMAP | VM_DONTEXPAND); |
287 | if (vdata->type == MSPEC_FETCHOP || vdata->type == MSPEC_UNCACHED) | 287 | if (vdata->type == MSPEC_FETCHOP || vdata->type == MSPEC_UNCACHED) |
288 | vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); | 288 | vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); |
289 | vma->vm_ops = &mspec_vm_ops; | 289 | vma->vm_ops = &mspec_vm_ops; |