aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/char/mbcs.c
diff options
context:
space:
mode:
authorAlan Cox <alan@lxorguk.ukuu.org.uk>2007-07-19 04:47:53 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-07-19 13:04:43 -0400
commit39ef01e00daf6d860783f1a836f765265a9d3b47 (patch)
treeb118a71490e5f4cf58b6756e7f24e537838c8e37 /drivers/char/mbcs.c
parent4004c69ad68dd03733179277280ea2946990ba36 (diff)
mbcs: Remove lots of global symbols
MBCS has a collection of things that searches say are not used elsewhere and could be static. If this is the case they should be static, if not then someone at SGI should rename things like "soft_list" so they don't pollute the global namespace with generic names... Signed-off-by: Alan Cox <alan@redhat.com> Acked-by: Bruce Losure <blosure@sgi.com> Cc: Jes Sorensen <jes@sgi.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/mbcs.c')
-rw-r--r--drivers/char/mbcs.c20
1 files changed, 10 insertions, 10 deletions
diff --git a/drivers/char/mbcs.c b/drivers/char/mbcs.c
index 3daf5e0a27e1..7ee5d9444926 100644
--- a/drivers/char/mbcs.c
+++ b/drivers/char/mbcs.c
@@ -39,14 +39,14 @@
39#else 39#else
40#define DBG(fmt...) 40#define DBG(fmt...)
41#endif 41#endif
42int mbcs_major; 42static int mbcs_major;
43 43
44LIST_HEAD(soft_list); 44static LIST_HEAD(soft_list);
45 45
46/* 46/*
47 * file operations 47 * file operations
48 */ 48 */
49const struct file_operations mbcs_ops = { 49static const struct file_operations mbcs_ops = {
50 .open = mbcs_open, 50 .open = mbcs_open,
51 .llseek = mbcs_sram_llseek, 51 .llseek = mbcs_sram_llseek,
52 .read = mbcs_sram_read, 52 .read = mbcs_sram_read,
@@ -377,7 +377,7 @@ dmaread_exit:
377 return rv; 377 return rv;
378} 378}
379 379
380int mbcs_open(struct inode *ip, struct file *fp) 380static int mbcs_open(struct inode *ip, struct file *fp)
381{ 381{
382 struct mbcs_soft *soft; 382 struct mbcs_soft *soft;
383 int minor; 383 int minor;
@@ -394,7 +394,7 @@ int mbcs_open(struct inode *ip, struct file *fp)
394 return -ENODEV; 394 return -ENODEV;
395} 395}
396 396
397ssize_t mbcs_sram_read(struct file * fp, char __user *buf, size_t len, loff_t * off) 397static ssize_t mbcs_sram_read(struct file * fp, char __user *buf, size_t len, loff_t * off)
398{ 398{
399 struct cx_dev *cx_dev = fp->private_data; 399 struct cx_dev *cx_dev = fp->private_data;
400 struct mbcs_soft *soft = cx_dev->soft; 400 struct mbcs_soft *soft = cx_dev->soft;
@@ -418,7 +418,7 @@ ssize_t mbcs_sram_read(struct file * fp, char __user *buf, size_t len, loff_t *
418 return rv; 418 return rv;
419} 419}
420 420
421ssize_t 421static ssize_t
422mbcs_sram_write(struct file * fp, const char __user *buf, size_t len, loff_t * off) 422mbcs_sram_write(struct file * fp, const char __user *buf, size_t len, loff_t * off)
423{ 423{
424 struct cx_dev *cx_dev = fp->private_data; 424 struct cx_dev *cx_dev = fp->private_data;
@@ -443,7 +443,7 @@ mbcs_sram_write(struct file * fp, const char __user *buf, size_t len, loff_t * o
443 return rv; 443 return rv;
444} 444}
445 445
446loff_t mbcs_sram_llseek(struct file * filp, loff_t off, int whence) 446static loff_t mbcs_sram_llseek(struct file * filp, loff_t off, int whence)
447{ 447{
448 loff_t newpos; 448 loff_t newpos;
449 449
@@ -491,7 +491,7 @@ static void mbcs_gscr_pioaddr_set(struct mbcs_soft *soft)
491 soft->gscr_addr = mbcs_pioaddr(soft, MBCS_GSCR_START); 491 soft->gscr_addr = mbcs_pioaddr(soft, MBCS_GSCR_START);
492} 492}
493 493
494int mbcs_gscr_mmap(struct file *fp, struct vm_area_struct *vma) 494static int mbcs_gscr_mmap(struct file *fp, struct vm_area_struct *vma)
495{ 495{
496 struct cx_dev *cx_dev = fp->private_data; 496 struct cx_dev *cx_dev = fp->private_data;
497 struct mbcs_soft *soft = cx_dev->soft; 497 struct mbcs_soft *soft = cx_dev->soft;
@@ -793,7 +793,7 @@ static int mbcs_remove(struct cx_dev *dev)
793 return 0; 793 return 0;
794} 794}
795 795
796const struct cx_device_id __devinitdata mbcs_id_table[] = { 796static const struct cx_device_id __devinitdata mbcs_id_table[] = {
797 { 797 {
798 .part_num = MBCS_PART_NUM, 798 .part_num = MBCS_PART_NUM,
799 .mfg_num = MBCS_MFG_NUM, 799 .mfg_num = MBCS_MFG_NUM,
@@ -807,7 +807,7 @@ const struct cx_device_id __devinitdata mbcs_id_table[] = {
807 807
808MODULE_DEVICE_TABLE(cx, mbcs_id_table); 808MODULE_DEVICE_TABLE(cx, mbcs_id_table);
809 809
810struct cx_drv mbcs_driver = { 810static struct cx_drv mbcs_driver = {
811 .name = DEVICE_NAME, 811 .name = DEVICE_NAME,
812 .id_table = mbcs_id_table, 812 .id_table = mbcs_id_table,
813 .probe = mbcs_probe, 813 .probe = mbcs_probe,