diff options
author | Alan Cox <alan@redhat.com> | 2008-10-13 05:44:57 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-10-13 12:51:44 -0400 |
commit | 51383f69ec56fe3f425d5255fb43e18c445e061c (patch) | |
tree | f9d9e280892702c3a47ffa807c0937ea9c80e315 /drivers/char/istallion.c | |
parent | ea1afd256258f04a290aaa7fd5c2d4deb2e79e26 (diff) |
tty: Remove lots of NULL checks
Many tty drivers contain 'can't happen' checks against NULL pointers passed
in by the tty layer. These have never been possible to occur. Even more
importantly if they ever do occur we want to know as it would be a serious
bug.
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/istallion.c')
-rw-r--r-- | drivers/char/istallion.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c index 96ee1121acef..505d7a1f6b8c 100644 --- a/drivers/char/istallion.c +++ b/drivers/char/istallion.c | |||
@@ -1375,8 +1375,6 @@ static void stli_flushchars(struct tty_struct *tty) | |||
1375 | stli_txcookrealsize = 0; | 1375 | stli_txcookrealsize = 0; |
1376 | stli_txcooktty = NULL; | 1376 | stli_txcooktty = NULL; |
1377 | 1377 | ||
1378 | if (tty == NULL) | ||
1379 | return; | ||
1380 | if (cooktty == NULL) | 1378 | if (cooktty == NULL) |
1381 | return; | 1379 | return; |
1382 | if (tty != cooktty) | 1380 | if (tty != cooktty) |
@@ -1732,8 +1730,6 @@ static void stli_settermios(struct tty_struct *tty, struct ktermios *old) | |||
1732 | struct ktermios *tiosp; | 1730 | struct ktermios *tiosp; |
1733 | asyport_t aport; | 1731 | asyport_t aport; |
1734 | 1732 | ||
1735 | if (tty == NULL) | ||
1736 | return; | ||
1737 | portp = tty->driver_data; | 1733 | portp = tty->driver_data; |
1738 | if (portp == NULL) | 1734 | if (portp == NULL) |
1739 | return; | 1735 | return; |
@@ -1938,8 +1934,6 @@ static void stli_waituntilsent(struct tty_struct *tty, int timeout) | |||
1938 | struct stliport *portp; | 1934 | struct stliport *portp; |
1939 | unsigned long tend; | 1935 | unsigned long tend; |
1940 | 1936 | ||
1941 | if (tty == NULL) | ||
1942 | return; | ||
1943 | portp = tty->driver_data; | 1937 | portp = tty->driver_data; |
1944 | if (portp == NULL) | 1938 | if (portp == NULL) |
1945 | return; | 1939 | return; |