Merge rsync://rsync.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6

2 files changed, 31 insertions, 32 deletions

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index b36eef0e9d19..02a7dd7a8a55 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -1184,20 +1184,20 @@ static void port_outl(struct si_sm_io *io, unsigned int offset,
 static void port_cleanup(struct smi_info *info)
 {
         unsigned int addr = info->io.addr_data;
-        int          mapsize;
+        int          idx;
 
         if (addr) {
-                mapsize = ((info->io_size * info->io.regspacing)
-                           - (info->io.regspacing - info->io.regsize));
-
-                release_region (addr, mapsize);
+                for (idx = 0; idx < info->io_size; idx++) {
+                        release_region(addr + idx * info->io.regspacing,
+                                       info->io.regsize);
+                }
         }
 }
 
 static int port_setup(struct smi_info *info)
 {
         unsigned int addr = info->io.addr_data;
-        int          mapsize;
+        int          idx;
 
         if (!addr)
                 return -ENODEV;
@@ -1225,16 +1225,22 @@ static int port_setup(struct smi_info *info)
                 return -EINVAL;
         }
 
-        /* Calculate the total amount of memory to claim.  This is an
-         * unusual looking calculation, but it avoids claiming any
-         * more memory than it has to.  It will claim everything
-         * between the first address to the end of the last full
-         * register. */
-        mapsize = ((info->io_size * info->io.regspacing)
-                   - (info->io.regspacing - info->io.regsize));
-
-        if (request_region(addr, mapsize, DEVICE_NAME) == NULL)
-                return -EIO;
+        /* Some BIOSes reserve disjoint I/O regions in their ACPI
+         * tables.  This causes problems when trying to register the
+         * entire I/O region.  Therefore we must register each I/O
+         * port separately.
+         */
+        for (idx = 0; idx < info->io_size; idx++) {
+                if (request_region(addr + idx * info->io.regspacing,
+                                   info->io.regsize, DEVICE_NAME) == NULL) {
+                        /* Undo allocations */
+                        while (idx--) {
+                                release_region(addr + idx * info->io.regspacing,
+                                               info->io.regsize);
+                        }
+                        return -EIO;
+                }
+        }
         return 0;
 }
 
diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
index 2d11ddd99e55..8f8867170973 100644
--- a/drivers/char/ipmi/ipmi_watchdog.c
+++ b/drivers/char/ipmi/ipmi_watchdog.c
@@ -212,24 +212,16 @@ static int set_param_str(const char *val, struct kernel_param *kp)
 {
         action_fn  fn = (action_fn) kp->arg;
         int        rv = 0;
-        const char *end;
-        char       valcp[16];
-        int        len;
-
-        /* Truncate leading and trailing spaces. */
-        while (isspace(*val))
-                val++;
-        end = val + strlen(val) - 1;
-        while ((end >= val) && isspace(*end))
-                end--;
-        len = end - val + 1;
-        if (len > sizeof(valcp) - 1)
-                return -EINVAL;
-        memcpy(valcp, val, len);
-        valcp[len] = '\0';
+        char       *dup, *s;
+
+        dup = kstrdup(val, GFP_KERNEL);
+        if (!dup)
+                return -ENOMEM;
+
+        s = strstrip(dup);
 
         down_read(&register_sem);
-        rv = fn(valcp, NULL);
+        rv = fn(s, NULL);
         if (rv)
                 goto out_unlock;
 
@@ -239,6 +231,7 @@ static int set_param_str(const char *val, struct kernel_param *kp)
 
  out_unlock:
         up_read(&register_sem);
+        kfree(dup);
         return rv;
 }