aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/char/ipmi/ipmi_si_intf.c
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2014-10-06 15:17:52 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2014-10-07 13:22:32 -0400
commitcc4cbe9011bf995f48fa62f3c675e57284c50635 (patch)
tree915cc2e91a27973840659b82b9b8ad0a281eae26 /drivers/char/ipmi/ipmi_si_intf.c
parent08dc41696ad7f3f8bcb2ea8cb97935a6e79a1bd7 (diff)
ipmi: work around gcc-4.9 build warning
Building ipmi on arm with gcc-4.9 results in this warning for an allmodconfig build: drivers/char/ipmi/ipmi_si_intf.c: In function 'ipmi_thread': include/linux/time.h:28:5: warning: 'busy_until.tv_sec' may be used uninitialized in this function [-Wmaybe-uninitialized] if (lhs->tv_sec > rhs->tv_sec) ^ drivers/char/ipmi/ipmi_si_intf.c:1007:18: note: 'busy_until.tv_sec' was declared here struct timespec busy_until; ^ The warning is bogus and this case can not occur. Apparently this is a false positive resulting from gcc getting a little smarter about tracking assignments but not smart enough. Marking the ipmi_thread_busy_wait function as inline gives the gcc optimization logic enough information to figure out for itself that the case cannot happen, which gets rid of the warning without adding any fake initialization. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Corey Minyard <cminyard@mvista.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/ipmi/ipmi_si_intf.c')
-rw-r--r--drivers/char/ipmi/ipmi_si_intf.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 4fc89310bfb5..1c43f9ac0989 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -965,9 +965,9 @@ static inline int ipmi_si_is_busy(struct timespec *ts)
965 return ts->tv_nsec != -1; 965 return ts->tv_nsec != -1;
966} 966}
967 967
968static int ipmi_thread_busy_wait(enum si_sm_result smi_result, 968static inline int ipmi_thread_busy_wait(enum si_sm_result smi_result,
969 const struct smi_info *smi_info, 969 const struct smi_info *smi_info,
970 struct timespec *busy_until) 970 struct timespec *busy_until)
971{ 971{
972 unsigned int max_busy_us = 0; 972 unsigned int max_busy_us = 0;
973 973