diff options
author | Corey Minyard <cminyard@mvista.com> | 2008-04-29 04:01:02 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-29 11:06:14 -0400 |
commit | bda4c30aa6f7dc1483f39ea1dfe37bcab8a96207 (patch) | |
tree | 760c538139c5b41ef54a27d62e5a8a1b01cf1c60 /drivers/char/ipmi/ipmi_msghandler.c | |
parent | 4ea18425436e7c72716b7f8d314775f399821195 (diff) |
ipmi: run to completion fixes
The "run_to_completion" mode was somewhat broken. Locks need to be avoided in
run_to_completion mode, and it shouldn't be used by normal users, just
internally for panic situations.
This patch removes locks in run_to_completion mode and removes the user call
for setting the mode. The only user was the poweroff code, but it was easily
converted to use the polling interface.
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/ipmi/ipmi_msghandler.c')
-rw-r--r-- | drivers/char/ipmi/ipmi_msghandler.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 32b2b22996dc..9f0075ca34ba 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c | |||
@@ -1197,13 +1197,6 @@ int ipmi_unregister_for_cmd(ipmi_user_t user, | |||
1197 | return rv; | 1197 | return rv; |
1198 | } | 1198 | } |
1199 | 1199 | ||
1200 | void ipmi_user_set_run_to_completion(ipmi_user_t user, int val) | ||
1201 | { | ||
1202 | ipmi_smi_t intf = user->intf; | ||
1203 | if (intf->handlers) | ||
1204 | intf->handlers->set_run_to_completion(intf->send_info, val); | ||
1205 | } | ||
1206 | |||
1207 | static unsigned char | 1200 | static unsigned char |
1208 | ipmb_checksum(unsigned char *data, int size) | 1201 | ipmb_checksum(unsigned char *data, int size) |
1209 | { | 1202 | { |
@@ -4190,5 +4183,4 @@ EXPORT_SYMBOL(ipmi_get_my_address); | |||
4190 | EXPORT_SYMBOL(ipmi_set_my_LUN); | 4183 | EXPORT_SYMBOL(ipmi_set_my_LUN); |
4191 | EXPORT_SYMBOL(ipmi_get_my_LUN); | 4184 | EXPORT_SYMBOL(ipmi_get_my_LUN); |
4192 | EXPORT_SYMBOL(ipmi_smi_add_proc_entry); | 4185 | EXPORT_SYMBOL(ipmi_smi_add_proc_entry); |
4193 | EXPORT_SYMBOL(ipmi_user_set_run_to_completion); | ||
4194 | EXPORT_SYMBOL(ipmi_free_recv_msg); | 4186 | EXPORT_SYMBOL(ipmi_free_recv_msg); |