diff options
author | David S. Miller <davem@davemloft.net> | 2009-06-15 06:02:23 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-06-15 06:02:23 -0400 |
commit | 9cbc1cb8cd46ce1f7645b9de249b2ce8460129bb (patch) | |
tree | 8d104ec2a459346b99413b0b77421ca7b9936c1a /drivers/char/hw_random/virtio-rng.c | |
parent | ca44d6e60f9de26281fda203f58b570e1748c015 (diff) | |
parent | 45e3e1935e2857c54783291107d33323b3ef33c8 (diff) |
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/torvalds/linux-2.6
Conflicts:
Documentation/feature-removal-schedule.txt
drivers/scsi/fcoe/fcoe.c
net/core/drop_monitor.c
net/core/net-traces.c
Diffstat (limited to 'drivers/char/hw_random/virtio-rng.c')
-rw-r--r-- | drivers/char/hw_random/virtio-rng.c | 30 |
1 files changed, 19 insertions, 11 deletions
diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c index 86e83f883139..32216b623248 100644 --- a/drivers/char/hw_random/virtio-rng.c +++ b/drivers/char/hw_random/virtio-rng.c | |||
@@ -35,13 +35,13 @@ static DECLARE_COMPLETION(have_data); | |||
35 | 35 | ||
36 | static void random_recv_done(struct virtqueue *vq) | 36 | static void random_recv_done(struct virtqueue *vq) |
37 | { | 37 | { |
38 | int len; | 38 | unsigned int len; |
39 | 39 | ||
40 | /* We can get spurious callbacks, e.g. shared IRQs + virtio_pci. */ | 40 | /* We can get spurious callbacks, e.g. shared IRQs + virtio_pci. */ |
41 | if (!vq->vq_ops->get_buf(vq, &len)) | 41 | if (!vq->vq_ops->get_buf(vq, &len)) |
42 | return; | 42 | return; |
43 | 43 | ||
44 | data_left = len / sizeof(random_data[0]); | 44 | data_left += len; |
45 | complete(&have_data); | 45 | complete(&have_data); |
46 | } | 46 | } |
47 | 47 | ||
@@ -49,7 +49,7 @@ static void register_buffer(void) | |||
49 | { | 49 | { |
50 | struct scatterlist sg; | 50 | struct scatterlist sg; |
51 | 51 | ||
52 | sg_init_one(&sg, random_data, RANDOM_DATA_SIZE); | 52 | sg_init_one(&sg, random_data+data_left, RANDOM_DATA_SIZE-data_left); |
53 | /* There should always be room for one buffer. */ | 53 | /* There should always be room for one buffer. */ |
54 | if (vq->vq_ops->add_buf(vq, &sg, 0, 1, random_data) != 0) | 54 | if (vq->vq_ops->add_buf(vq, &sg, 0, 1, random_data) != 0) |
55 | BUG(); | 55 | BUG(); |
@@ -59,24 +59,32 @@ static void register_buffer(void) | |||
59 | /* At least we don't udelay() in a loop like some other drivers. */ | 59 | /* At least we don't udelay() in a loop like some other drivers. */ |
60 | static int virtio_data_present(struct hwrng *rng, int wait) | 60 | static int virtio_data_present(struct hwrng *rng, int wait) |
61 | { | 61 | { |
62 | if (data_left) | 62 | if (data_left >= sizeof(u32)) |
63 | return 1; | 63 | return 1; |
64 | 64 | ||
65 | again: | ||
65 | if (!wait) | 66 | if (!wait) |
66 | return 0; | 67 | return 0; |
67 | 68 | ||
68 | wait_for_completion(&have_data); | 69 | wait_for_completion(&have_data); |
70 | |||
71 | /* Not enough? Re-register. */ | ||
72 | if (unlikely(data_left < sizeof(u32))) { | ||
73 | register_buffer(); | ||
74 | goto again; | ||
75 | } | ||
76 | |||
69 | return 1; | 77 | return 1; |
70 | } | 78 | } |
71 | 79 | ||
72 | /* virtio_data_present() must have succeeded before this is called. */ | 80 | /* virtio_data_present() must have succeeded before this is called. */ |
73 | static int virtio_data_read(struct hwrng *rng, u32 *data) | 81 | static int virtio_data_read(struct hwrng *rng, u32 *data) |
74 | { | 82 | { |
75 | BUG_ON(!data_left); | 83 | BUG_ON(data_left < sizeof(u32)); |
76 | 84 | data_left -= sizeof(u32); | |
77 | *data = random_data[--data_left]; | 85 | *data = random_data[data_left / 4]; |
78 | 86 | ||
79 | if (!data_left) { | 87 | if (data_left < sizeof(u32)) { |
80 | init_completion(&have_data); | 88 | init_completion(&have_data); |
81 | register_buffer(); | 89 | register_buffer(); |
82 | } | 90 | } |
@@ -94,13 +102,13 @@ static int virtrng_probe(struct virtio_device *vdev) | |||
94 | int err; | 102 | int err; |
95 | 103 | ||
96 | /* We expect a single virtqueue. */ | 104 | /* We expect a single virtqueue. */ |
97 | vq = vdev->config->find_vq(vdev, 0, random_recv_done); | 105 | vq = virtio_find_single_vq(vdev, random_recv_done, "input"); |
98 | if (IS_ERR(vq)) | 106 | if (IS_ERR(vq)) |
99 | return PTR_ERR(vq); | 107 | return PTR_ERR(vq); |
100 | 108 | ||
101 | err = hwrng_register(&virtio_hwrng); | 109 | err = hwrng_register(&virtio_hwrng); |
102 | if (err) { | 110 | if (err) { |
103 | vdev->config->del_vq(vq); | 111 | vdev->config->del_vqs(vdev); |
104 | return err; | 112 | return err; |
105 | } | 113 | } |
106 | 114 | ||
@@ -112,7 +120,7 @@ static void virtrng_remove(struct virtio_device *vdev) | |||
112 | { | 120 | { |
113 | vdev->config->reset(vdev); | 121 | vdev->config->reset(vdev); |
114 | hwrng_unregister(&virtio_hwrng); | 122 | hwrng_unregister(&virtio_hwrng); |
115 | vdev->config->del_vq(vq); | 123 | vdev->config->del_vqs(vdev); |
116 | } | 124 | } |
117 | 125 | ||
118 | static struct virtio_device_id id_table[] = { | 126 | static struct virtio_device_id id_table[] = { |