diff options
author | H. Peter Anvin <hpa@zytor.com> | 2009-12-11 18:48:23 -0500 |
---|---|---|
committer | H. Peter Anvin <hpa@zytor.com> | 2009-12-11 18:48:23 -0500 |
commit | a01c7800420d2c294ca403988488a635d4087a6d (patch) | |
tree | a0a5eeb436a297dffead2dfbccbb0ad3013aa7d1 /drivers/char/hvc_xen.c | |
parent | b925585039cf39275c2e0e57512e5df27fa73aad (diff) |
nvram: Fix write beyond end condition; prove to gcc copy is safe
In nvram_write, first of all, correctly handle the case where the file
pointer is already beyond the end; we should return EOF in that case.
Second, make the logic a bit more explicit so that gcc can statically
prove that the copy_from_user() is safe. Once the condition of the
beyond-end filepointer is eliminated, the copy is safe but gcc can't
prove it, causing build failures for i386 allyesconfig.
Third, eliminate the entirely superfluous variable "len", and just use
the passed-in variable "count" instead.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <tip-*@git.kernel.org>
Diffstat (limited to 'drivers/char/hvc_xen.c')
0 files changed, 0 insertions, 0 deletions