diff options
author | Jani Nikula <ext-jani.1.nikula@nokia.com> | 2010-03-11 11:15:53 -0500 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2010-03-15 10:31:04 -0400 |
commit | 30c96ce56a195963764de9521087202ba73e9bff (patch) | |
tree | d2efc82338c0efea307cf9cb5a1cf10f218d4e26 /drivers/char/bsr.c | |
parent | 3e21ec224f0acbd2e9beeb3dea04edc1d36dbe1f (diff) |
powerpc/BSR: fix device_create() return value check
Use IS_ERR() instead of comparing to NULL.
Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Acked-by: Sonny Rao <sonnyrao@us.ibm.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/char/bsr.c')
-rw-r--r-- | drivers/char/bsr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c index c02db01f736e..3b31f744b7af 100644 --- a/drivers/char/bsr.c +++ b/drivers/char/bsr.c | |||
@@ -252,7 +252,7 @@ static int bsr_add_node(struct device_node *bn) | |||
252 | 252 | ||
253 | cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev, | 253 | cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev, |
254 | cur, cur->bsr_name); | 254 | cur, cur->bsr_name); |
255 | if (!cur->bsr_device) { | 255 | if (IS_ERR(cur->bsr_device)) { |
256 | printk(KERN_ERR "device_create failed for %s\n", | 256 | printk(KERN_ERR "device_create failed for %s\n", |
257 | cur->bsr_name); | 257 | cur->bsr_name); |
258 | cdev_del(&cur->bsr_cdev); | 258 | cdev_del(&cur->bsr_cdev); |