Manual merge with Linus.

Conflicts:
	arch/powerpc/kernel/setup-common.c
	drivers/input/keyboard/hil_kbd.c
	drivers/input/mouse/hil_ptr.c

5 files changed, 917 insertions, 739 deletions

diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index 879bbc26ce96..a59876a0bfa1 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -407,7 +407,6 @@ int register_cdrom(struct cdrom_device_info *cdi)
         ENSURE(get_mcn, CDC_MCN);
         ENSURE(reset, CDC_RESET);
         ENSURE(audio_ioctl, CDC_PLAY_AUDIO);
-        ENSURE(dev_ioctl, CDC_IOCTLS);
         ENSURE(generic_packet, CDC_GENERIC_PACKET);
         cdi->mc_flags = 0;
         cdo->n_minors = 0;
@@ -2196,395 +2195,586 @@ retry:
         return cdrom_read_cdda_old(cdi, ubuf, lba, nframes);    
 }
 
-/* Just about every imaginable ioctl is supported in the Uniform layer
- * these days. ATAPI / SCSI specific code now mainly resides in
- * mmc_ioct().
- */
-int cdrom_ioctl(struct file * file, struct cdrom_device_info *cdi,
-                struct inode *ip, unsigned int cmd, unsigned long arg)
+static int cdrom_ioctl_multisession(struct cdrom_device_info *cdi,
+                void __user *argp)
 {
-        struct cdrom_device_ops *cdo = cdi->ops;
+        struct cdrom_multisession ms_info;
+        u8 requested_format;
         int ret;
 
-        /* Try the generic SCSI command ioctl's first.. */
-        ret = scsi_cmd_ioctl(file, ip->i_bdev->bd_disk, cmd, (void __user *)arg);
-        if (ret != -ENOTTY)
+        cdinfo(CD_DO_IOCTL, "entering CDROMMULTISESSION\n");
+
+        if (!(cdi->ops->capability & CDC_MULTI_SESSION))
+                return -ENOSYS;
+
+        if (copy_from_user(&ms_info, argp, sizeof(ms_info)))
+                return -EFAULT;
+
+        requested_format = ms_info.addr_format;
+        if (requested_format != CDROM_MSF && requested_format != CDROM_LBA)
+                return -EINVAL;
+        ms_info.addr_format = CDROM_LBA;
+
+        ret = cdi->ops->get_last_session(cdi, &ms_info);
+        if (ret)
                 return ret;
 
-        /* the first few commands do not deal with audio drive_info, but
-           only with routines in cdrom device operations. */
-        switch (cmd) {
-        case CDROMMULTISESSION: {
-                struct cdrom_multisession ms_info;
-                u_char requested_format;
-                cdinfo(CD_DO_IOCTL, "entering CDROMMULTISESSION\n"); 
-                if (!(cdo->capability & CDC_MULTI_SESSION))
-                        return -ENOSYS;
-                IOCTL_IN(arg, struct cdrom_multisession, ms_info);
-                requested_format = ms_info.addr_format;
-                if (!((requested_format == CDROM_MSF) ||
-                        (requested_format == CDROM_LBA)))
-                                return -EINVAL;
-                ms_info.addr_format = CDROM_LBA;
-                if ((ret=cdo->get_last_session(cdi, &ms_info)))
+        sanitize_format(&ms_info.addr, &ms_info.addr_format, requested_format);
+
+        if (copy_to_user(argp, &ms_info, sizeof(ms_info)))
+                return -EFAULT;
+
+        cdinfo(CD_DO_IOCTL, "CDROMMULTISESSION successful\n");
+        return 0;
+}
+
+static int cdrom_ioctl_eject(struct cdrom_device_info *cdi)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROMEJECT\n");
+
+        if (!CDROM_CAN(CDC_OPEN_TRAY))
+                return -ENOSYS;
+        if (cdi->use_count != 1 || keeplocked)
+                return -EBUSY;
+        if (CDROM_CAN(CDC_LOCK)) {
+                int ret = cdi->ops->lock_door(cdi, 0);
+                if (ret)
                         return ret;
-                sanitize_format(&ms_info.addr, &ms_info.addr_format,
-                                requested_format);
-                IOCTL_OUT(arg, struct cdrom_multisession, ms_info);
-                cdinfo(CD_DO_IOCTL, "CDROMMULTISESSION successful\n"); 
-                return 0;
-                }
+        }
 
-        case CDROMEJECT: {
-                cdinfo(CD_DO_IOCTL, "entering CDROMEJECT\n"); 
-                if (!CDROM_CAN(CDC_OPEN_TRAY))
-                        return -ENOSYS;
-                if (cdi->use_count != 1 || keeplocked)
-                        return -EBUSY;
-                if (CDROM_CAN(CDC_LOCK))
-                        if ((ret=cdo->lock_door(cdi, 0)))
-                                return ret;
+        return cdi->ops->tray_move(cdi, 1);
+}
 
-                return cdo->tray_move(cdi, 1);
-                }
+static int cdrom_ioctl_closetray(struct cdrom_device_info *cdi)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROMCLOSETRAY\n");
 
-        case CDROMCLOSETRAY: {
-                cdinfo(CD_DO_IOCTL, "entering CDROMCLOSETRAY\n"); 
-                if (!CDROM_CAN(CDC_CLOSE_TRAY))
-                        return -ENOSYS;
-                return cdo->tray_move(cdi, 0);
-                }
+        if (!CDROM_CAN(CDC_CLOSE_TRAY))
+                return -ENOSYS;
+        return cdi->ops->tray_move(cdi, 0);
+}
 
-        case CDROMEJECT_SW: {
-                cdinfo(CD_DO_IOCTL, "entering CDROMEJECT_SW\n"); 
-                if (!CDROM_CAN(CDC_OPEN_TRAY))
-                        return -ENOSYS;
-                if (keeplocked)
-                        return -EBUSY;
-                cdi->options &= ~(CDO_AUTO_CLOSE | CDO_AUTO_EJECT);
-                if (arg)
-                        cdi->options |= CDO_AUTO_CLOSE | CDO_AUTO_EJECT;
-                return 0;
-                }
+static int cdrom_ioctl_eject_sw(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROMEJECT_SW\n");
 
-        case CDROM_MEDIA_CHANGED: {
-                struct cdrom_changer_info *info;
-                int changed;
+        if (!CDROM_CAN(CDC_OPEN_TRAY))
+                return -ENOSYS;
+        if (keeplocked)
+                return -EBUSY;
 
-                cdinfo(CD_DO_IOCTL, "entering CDROM_MEDIA_CHANGED\n"); 
-                if (!CDROM_CAN(CDC_MEDIA_CHANGED))
-                        return -ENOSYS;
+        cdi->options &= ~(CDO_AUTO_CLOSE | CDO_AUTO_EJECT);
+        if (arg)
+                cdi->options |= CDO_AUTO_CLOSE | CDO_AUTO_EJECT;
+        return 0;
+}
 
-                /* cannot select disc or select current disc */
-                if (!CDROM_CAN(CDC_SELECT_DISC) || arg == CDSL_CURRENT)
-                        return media_changed(cdi, 1);
+static int cdrom_ioctl_media_changed(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        struct cdrom_changer_info *info;
+        int ret;
 
-                if ((unsigned int)arg >= cdi->capacity)
-                        return -EINVAL;
+        cdinfo(CD_DO_IOCTL, "entering CDROM_MEDIA_CHANGED\n");
 
-                info = kmalloc(sizeof(*info), GFP_KERNEL);
-                if (!info)
-                        return -ENOMEM;
+        if (!CDROM_CAN(CDC_MEDIA_CHANGED))
+                return -ENOSYS;
 
-                if ((ret = cdrom_read_mech_status(cdi, info))) {
-                        kfree(info);
-                        return ret;
-                }
+        /* cannot select disc or select current disc */
+        if (!CDROM_CAN(CDC_SELECT_DISC) || arg == CDSL_CURRENT)
+                return media_changed(cdi, 1);
 
-                changed = info->slots[arg].change;
-                kfree(info);
-                return changed;
-                }
+        if ((unsigned int)arg >= cdi->capacity)
+                return -EINVAL;
 
-        case CDROM_SET_OPTIONS: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_SET_OPTIONS\n"); 
-                /* options need to be in sync with capability. too late for
-                   that, so we have to check each one separately... */
-                switch (arg) {
-                case CDO_USE_FFLAGS:
-                case CDO_CHECK_TYPE:
-                        break;
-                case CDO_LOCK:
-                        if (!CDROM_CAN(CDC_LOCK))
-                                return -ENOSYS;
-                        break;
-                case 0:
-                        return cdi->options;
-                /* default is basically CDO_[AUTO_CLOSE|AUTO_EJECT] */
-                default:
-                        if (!CDROM_CAN(arg))
-                                return -ENOSYS;
-                }
-                cdi->options |= (int) arg;
-                return cdi->options;
-                }
+        info = kmalloc(sizeof(*info), GFP_KERNEL);
+        if (!info)
+                return -ENOMEM;
 
-        case CDROM_CLEAR_OPTIONS: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_CLEAR_OPTIONS\n"); 
-                cdi->options &= ~(int) arg;
-                return cdi->options;
-                }
+        ret = cdrom_read_mech_status(cdi, info);
+        if (!ret)
+                ret = info->slots[arg].change;
+        kfree(info);
+        return ret;
+}
 
-        case CDROM_SELECT_SPEED: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_SELECT_SPEED\n"); 
-                if (!CDROM_CAN(CDC_SELECT_SPEED))
-                        return -ENOSYS;
-                return cdo->select_speed(cdi, arg);
-                }
+static int cdrom_ioctl_set_options(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_SET_OPTIONS\n");
 
-        case CDROM_SELECT_DISC: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_SELECT_DISC\n"); 
-                if (!CDROM_CAN(CDC_SELECT_DISC))
+        /*
+         * Options need to be in sync with capability.
+         * Too late for that, so we have to check each one separately.
+         */
+        switch (arg) {
+        case CDO_USE_FFLAGS:
+        case CDO_CHECK_TYPE:
+                break;
+        case CDO_LOCK:
+                if (!CDROM_CAN(CDC_LOCK))
+                        return -ENOSYS;
+                break;
+        case 0:
+                return cdi->options;
+        /* default is basically CDO_[AUTO_CLOSE|AUTO_EJECT] */
+        default:
+                if (!CDROM_CAN(arg))
                         return -ENOSYS;
+        }
+        cdi->options |= (int) arg;
+        return cdi->options;
+}
 
-                if ((arg != CDSL_CURRENT) && (arg != CDSL_NONE))
-                        if ((int)arg >= cdi->capacity)
-                                return -EINVAL;
-
-                /* cdo->select_disc is a hook to allow a driver-specific
-                 * way of seleting disc.  However, since there is no
-                 * equiv hook for cdrom_slot_status this may not 
-                 * actually be useful...
-                 */
-                if (cdo->select_disc != NULL)
-                        return cdo->select_disc(cdi, arg);
-
-                /* no driver specific select_disc(), call our own */
-                cdinfo(CD_CHANGER, "Using generic cdrom_select_disc()\n"); 
-                return cdrom_select_disc(cdi, arg);
-                }
+static int cdrom_ioctl_clear_options(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_CLEAR_OPTIONS\n");
 
-        case CDROMRESET: {
-                if (!capable(CAP_SYS_ADMIN))
-                        return -EACCES;
-                cdinfo(CD_DO_IOCTL, "entering CDROM_RESET\n");
-                if (!CDROM_CAN(CDC_RESET))
-                        return -ENOSYS;
-                invalidate_bdev(ip->i_bdev, 0);
-                return cdo->reset(cdi);
-                }
+        cdi->options &= ~(int) arg;
+        return cdi->options;
+}
 
-        case CDROM_LOCKDOOR: {
-                cdinfo(CD_DO_IOCTL, "%socking door.\n", arg ? "L" : "Unl");
-                if (!CDROM_CAN(CDC_LOCK))
-                        return -EDRIVE_CANT_DO_THIS;
-                keeplocked = arg ? 1 : 0;
-                /* don't unlock the door on multiple opens,but allow root
-                 * to do so */
-                if ((cdi->use_count != 1) && !arg && !capable(CAP_SYS_ADMIN))
-                        return -EBUSY;
-                return cdo->lock_door(cdi, arg);
-                }
+static int cdrom_ioctl_select_speed(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_SELECT_SPEED\n");
 
-        case CDROM_DEBUG: {
-                if (!capable(CAP_SYS_ADMIN))
-                        return -EACCES;
-                cdinfo(CD_DO_IOCTL, "%sabling debug.\n", arg ? "En" : "Dis");
-                debug = arg ? 1 : 0;
-                return debug;
-                }
+        if (!CDROM_CAN(CDC_SELECT_SPEED))
+                return -ENOSYS;
+        return cdi->ops->select_speed(cdi, arg);
+}
 
-        case CDROM_GET_CAPABILITY: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_GET_CAPABILITY\n");
-                return (cdo->capability & ~cdi->mask);
-                }
+static int cdrom_ioctl_select_disc(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_SELECT_DISC\n");
+
+        if (!CDROM_CAN(CDC_SELECT_DISC))
+                return -ENOSYS;
+
+        if (arg != CDSL_CURRENT && arg != CDSL_NONE) {
+                if ((int)arg >= cdi->capacity)
+                        return -EINVAL;
+        }
+
+        /*
+         * ->select_disc is a hook to allow a driver-specific way of
+         * seleting disc.  However, since there is no equivalent hook for
+         * cdrom_slot_status this may not actually be useful...
+         */
+        if (cdi->ops->select_disc)
+                return cdi->ops->select_disc(cdi, arg);
+
+        cdinfo(CD_CHANGER, "Using generic cdrom_select_disc()\n");
+        return cdrom_select_disc(cdi, arg);
+}
+
+static int cdrom_ioctl_reset(struct cdrom_device_info *cdi,
+                struct block_device *bdev)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_RESET\n");
+
+        if (!capable(CAP_SYS_ADMIN))
+                return -EACCES;
+        if (!CDROM_CAN(CDC_RESET))
+                return -ENOSYS;
+        invalidate_bdev(bdev, 0);
+        return cdi->ops->reset(cdi);
+}
+
+static int cdrom_ioctl_lock_door(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "%socking door.\n", arg ? "L" : "Unl");
+
+        if (!CDROM_CAN(CDC_LOCK))
+                return -EDRIVE_CANT_DO_THIS;
+
+        keeplocked = arg ? 1 : 0;
+
+        /*
+         * Don't unlock the door on multiple opens by default, but allow
+         * root to do so.
+         */
+        if (cdi->use_count != 1 && !arg && !capable(CAP_SYS_ADMIN))
+                return -EBUSY;
+        return cdi->ops->lock_door(cdi, arg);
+}
+
+static int cdrom_ioctl_debug(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "%sabling debug.\n", arg ? "En" : "Dis");
+
+        if (!capable(CAP_SYS_ADMIN))
+                return -EACCES;
+        debug = arg ? 1 : 0;
+        return debug;
+}
 
-/* The following function is implemented, although very few audio
+static int cdrom_ioctl_get_capability(struct cdrom_device_info *cdi)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_GET_CAPABILITY\n");
+        return (cdi->ops->capability & ~cdi->mask);
+}
+
+/*
+ * The following function is implemented, although very few audio
  * discs give Universal Product Code information, which should just be
  * the Medium Catalog Number on the box.  Note, that the way the code
  * is written on the CD is /not/ uniform across all discs!
  */
-        case CDROM_GET_MCN: {
-                struct cdrom_mcn mcn;
-                cdinfo(CD_DO_IOCTL, "entering CDROM_GET_MCN\n"); 
-                if (!(cdo->capability & CDC_MCN))
-                        return -ENOSYS;
-                if ((ret=cdo->get_mcn(cdi, &mcn)))
-                        return ret;
-                IOCTL_OUT(arg, struct cdrom_mcn, mcn);
-                cdinfo(CD_DO_IOCTL, "CDROM_GET_MCN successful\n"); 
-                return 0;
-                }
+static int cdrom_ioctl_get_mcn(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_mcn mcn;
+        int ret;
 
-        case CDROM_DRIVE_STATUS: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_DRIVE_STATUS\n"); 
-                if (!(cdo->capability & CDC_DRIVE_STATUS))
-                        return -ENOSYS;
-                if (!CDROM_CAN(CDC_SELECT_DISC))
-                        return cdo->drive_status(cdi, CDSL_CURRENT);
-                if ((arg == CDSL_CURRENT) || (arg == CDSL_NONE)) 
-                        return cdo->drive_status(cdi, CDSL_CURRENT);
-                if (((int)arg >= cdi->capacity))
-                        return -EINVAL;
-                return cdrom_slot_status(cdi, arg);
-                }
+        cdinfo(CD_DO_IOCTL, "entering CDROM_GET_MCN\n");
 
-        /* Ok, this is where problems start.  The current interface for the
-           CDROM_DISC_STATUS ioctl is flawed.  It makes the false assumption
-           that CDs are all CDS_DATA_1 or all CDS_AUDIO, etc.  Unfortunatly,
-           while this is often the case, it is also very common for CDs to
-           have some tracks with data, and some tracks with audio.  Just 
-           because I feel like it, I declare the following to be the best
-           way to cope.  If the CD has ANY data tracks on it, it will be
-           returned as a data CD.  If it has any XA tracks, I will return
-           it as that.  Now I could simplify this interface by combining these 
-           returns with the above, but this more clearly demonstrates
-           the problem with the current interface.  Too bad this wasn't 
-           designed to use bitmasks...         -Erik 
-
-           Well, now we have the option CDS_MIXED: a mixed-type CD. 
-           User level programmers might feel the ioctl is not very useful.
-                                                ---david
-        */
-        case CDROM_DISC_STATUS: {
-                tracktype tracks;
-                cdinfo(CD_DO_IOCTL, "entering CDROM_DISC_STATUS\n"); 
-                cdrom_count_tracks(cdi, &tracks);
-                if (tracks.error) 
-                        return(tracks.error);
-
-                /* Policy mode on */
-                if (tracks.audio > 0) {
-                        if (tracks.data==0 && tracks.cdi==0 && tracks.xa==0) 
-                                return CDS_AUDIO;
-                        else
-                                return CDS_MIXED;
-                }
-                if (tracks.cdi > 0) return CDS_XA_2_2;
-                if (tracks.xa > 0) return CDS_XA_2_1;
-                if (tracks.data > 0) return CDS_DATA_1;
-                /* Policy mode off */
+        if (!(cdi->ops->capability & CDC_MCN))
+                return -ENOSYS;
+        ret = cdi->ops->get_mcn(cdi, &mcn);
+        if (ret)
+                return ret;
 
-                cdinfo(CD_WARNING,"This disc doesn't have any tracks I recognize!\n");
-                return CDS_NO_INFO;
-                }
+        if (copy_to_user(argp, &mcn, sizeof(mcn)))
+                return -EFAULT;
+        cdinfo(CD_DO_IOCTL, "CDROM_GET_MCN successful\n");
+        return 0;
+}
 
-        case CDROM_CHANGER_NSLOTS: {
-                cdinfo(CD_DO_IOCTL, "entering CDROM_CHANGER_NSLOTS\n"); 
-                return cdi->capacity;
-                }
+static int cdrom_ioctl_drive_status(struct cdrom_device_info *cdi,
+                unsigned long arg)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_DRIVE_STATUS\n");
+
+        if (!(cdi->ops->capability & CDC_DRIVE_STATUS))
+                return -ENOSYS;
+        if (!CDROM_CAN(CDC_SELECT_DISC) ||
+            (arg == CDSL_CURRENT || arg == CDSL_NONE))
+                return cdi->ops->drive_status(cdi, CDSL_CURRENT);
+        if (((int)arg >= cdi->capacity))
+                return -EINVAL;
+        return cdrom_slot_status(cdi, arg);
+}
+
+/*
+ * Ok, this is where problems start.  The current interface for the
+ * CDROM_DISC_STATUS ioctl is flawed.  It makes the false assumption that
+ * CDs are all CDS_DATA_1 or all CDS_AUDIO, etc.  Unfortunatly, while this
+ * is often the case, it is also very common for CDs to have some tracks
+ * with data, and some tracks with audio.  Just because I feel like it,
+ * I declare the following to be the best way to cope.  If the CD has ANY
+ * data tracks on it, it will be returned as a data CD.  If it has any XA
+ * tracks, I will return it as that.  Now I could simplify this interface
+ * by combining these  returns with the above, but this more clearly
+ * demonstrates the problem with the current interface.  Too bad this
+ * wasn't designed to use bitmasks...         -Erik
+ *
+ * Well, now we have the option CDS_MIXED: a mixed-type CD.
+ * User level programmers might feel the ioctl is not very useful.
+ *                                      ---david
+ */
+static int cdrom_ioctl_disc_status(struct cdrom_device_info *cdi)
+{
+        tracktype tracks;
+
+        cdinfo(CD_DO_IOCTL, "entering CDROM_DISC_STATUS\n");
+
+        cdrom_count_tracks(cdi, &tracks);
+        if (tracks.error)
+                return tracks.error;
+
+        /* Policy mode on */
+        if (tracks.audio > 0) {
+                if (!tracks.data && !tracks.cdi && !tracks.xa)
+                        return CDS_AUDIO;
+                else
+                        return CDS_MIXED;
         }
 
-        /* use the ioctls that are implemented through the generic_packet()
-           interface. this may look at bit funny, but if -ENOTTY is
-           returned that particular ioctl is not implemented and we
-           let it go through the device specific ones. */
+        if (tracks.cdi > 0)
+                return CDS_XA_2_2;
+        if (tracks.xa > 0)
+                return CDS_XA_2_1;
+        if (tracks.data > 0)
+                return CDS_DATA_1;
+        /* Policy mode off */
+
+        cdinfo(CD_WARNING,"This disc doesn't have any tracks I recognize!\n");
+        return CDS_NO_INFO;
+}
+
+static int cdrom_ioctl_changer_nslots(struct cdrom_device_info *cdi)
+{
+        cdinfo(CD_DO_IOCTL, "entering CDROM_CHANGER_NSLOTS\n");
+        return cdi->capacity;
+}
+
+static int cdrom_ioctl_get_subchnl(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_subchnl q;
+        u8 requested, back;
+        int ret;
+
+        /* cdinfo(CD_DO_IOCTL,"entering CDROMSUBCHNL\n");*/
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        if (copy_from_user(&q, argp, sizeof(q)))
+                return -EFAULT;
+
+        requested = q.cdsc_format;
+        if (requested != CDROM_MSF && requested != CDROM_LBA)
+                return -EINVAL;
+        q.cdsc_format = CDROM_MSF;
+
+        ret = cdi->ops->audio_ioctl(cdi, CDROMSUBCHNL, &q);
+        if (ret)
+                return ret;
+
+        back = q.cdsc_format; /* local copy */
+        sanitize_format(&q.cdsc_absaddr, &back, requested);
+        sanitize_format(&q.cdsc_reladdr, &q.cdsc_format, requested);
+
+        if (copy_to_user(argp, &q, sizeof(q)))
+                return -EFAULT;
+        /* cdinfo(CD_DO_IOCTL, "CDROMSUBCHNL successful\n"); */
+        return 0;
+}
+
+static int cdrom_ioctl_read_tochdr(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_tochdr header;
+        int ret;
+
+        /* cdinfo(CD_DO_IOCTL, "entering CDROMREADTOCHDR\n"); */
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        if (copy_from_user(&header, argp, sizeof(header)))
+                return -EFAULT;
+
+        ret = cdi->ops->audio_ioctl(cdi, CDROMREADTOCHDR, &header);
+        if (ret)
+                return ret;
+
+        if (copy_to_user(argp, &header, sizeof(header)))
+                return -EFAULT;
+        /* cdinfo(CD_DO_IOCTL, "CDROMREADTOCHDR successful\n"); */
+        return 0;
+}
+
+static int cdrom_ioctl_read_tocentry(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_tocentry entry;
+        u8 requested_format;
+        int ret;
+
+        /* cdinfo(CD_DO_IOCTL, "entering CDROMREADTOCENTRY\n"); */
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        if (copy_from_user(&entry, argp, sizeof(entry)))
+                return -EFAULT;
+
+        requested_format = entry.cdte_format;
+        if (requested_format != CDROM_MSF && requested_format != CDROM_LBA)
+                return -EINVAL;
+        /* make interface to low-level uniform */
+        entry.cdte_format = CDROM_MSF;
+        ret = cdi->ops->audio_ioctl(cdi, CDROMREADTOCENTRY, &entry);
+        if (ret)
+                return ret;
+        sanitize_format(&entry.cdte_addr, &entry.cdte_format, requested_format);
+
+        if (copy_to_user(argp, &entry, sizeof(entry)))
+                return -EFAULT;
+        /* cdinfo(CD_DO_IOCTL, "CDROMREADTOCENTRY successful\n"); */
+        return 0;
+}
+
+static int cdrom_ioctl_play_msf(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_msf msf;
+
+        cdinfo(CD_DO_IOCTL, "entering CDROMPLAYMSF\n");
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        if (copy_from_user(&msf, argp, sizeof(msf)))
+                return -EFAULT;
+        return cdi->ops->audio_ioctl(cdi, CDROMPLAYMSF, &msf);
+}
+
+static int cdrom_ioctl_play_trkind(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_ti ti;
+        int ret;
+
+        cdinfo(CD_DO_IOCTL, "entering CDROMPLAYTRKIND\n");
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        if (copy_from_user(&ti, argp, sizeof(ti)))
+                return -EFAULT;
+
+        ret = check_for_audio_disc(cdi, cdi->ops);
+        if (ret)
+                return ret;
+        return cdi->ops->audio_ioctl(cdi, CDROMPLAYTRKIND, &ti);
+}
+static int cdrom_ioctl_volctrl(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_volctrl volume;
+
+        cdinfo(CD_DO_IOCTL, "entering CDROMVOLCTRL\n");
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        if (copy_from_user(&volume, argp, sizeof(volume)))
+                return -EFAULT;
+        return cdi->ops->audio_ioctl(cdi, CDROMVOLCTRL, &volume);
+}
+
+static int cdrom_ioctl_volread(struct cdrom_device_info *cdi,
+                void __user *argp)
+{
+        struct cdrom_volctrl volume;
+        int ret;
+
+        cdinfo(CD_DO_IOCTL, "entering CDROMVOLREAD\n");
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+
+        ret = cdi->ops->audio_ioctl(cdi, CDROMVOLREAD, &volume);
+        if (ret)
+                return ret;
+
+        if (copy_to_user(argp, &volume, sizeof(volume)))
+                return -EFAULT;
+        return 0;
+}
+
+static int cdrom_ioctl_audioctl(struct cdrom_device_info *cdi,
+                unsigned int cmd)
+{
+        int ret;
+
+        cdinfo(CD_DO_IOCTL, "doing audio ioctl (start/stop/pause/resume)\n");
+
+        if (!CDROM_CAN(CDC_PLAY_AUDIO))
+                return -ENOSYS;
+        ret = check_for_audio_disc(cdi, cdi->ops);
+        if (ret)
+                return ret;
+        return cdi->ops->audio_ioctl(cdi, cmd, NULL);
+}
+
+/*
+ * Just about every imaginable ioctl is supported in the Uniform layer
+ * these days.
+ * ATAPI / SCSI specific code now mainly resides in mmc_ioctl().
+ */
+int cdrom_ioctl(struct file * file, struct cdrom_device_info *cdi,
+                struct inode *ip, unsigned int cmd, unsigned long arg)
+{
+        void __user *argp = (void __user *)arg;
+        int ret;
+
+        /*
+         * Try the generic SCSI command ioctl's first.
+         */
+        ret = scsi_cmd_ioctl(file, ip->i_bdev->bd_disk, cmd, argp);
+        if (ret != -ENOTTY)
+                return ret;
+
+        switch (cmd) {
+        case CDROMMULTISESSION:
+                return cdrom_ioctl_multisession(cdi, argp);
+        case CDROMEJECT:
+                return cdrom_ioctl_eject(cdi);
+        case CDROMCLOSETRAY:
+                return cdrom_ioctl_closetray(cdi);
+        case CDROMEJECT_SW:
+                return cdrom_ioctl_eject_sw(cdi, arg);
+        case CDROM_MEDIA_CHANGED:
+                return cdrom_ioctl_media_changed(cdi, arg);
+        case CDROM_SET_OPTIONS:
+                return cdrom_ioctl_set_options(cdi, arg);
+        case CDROM_CLEAR_OPTIONS:
+                return cdrom_ioctl_clear_options(cdi, arg);
+        case CDROM_SELECT_SPEED:
+                return cdrom_ioctl_select_speed(cdi, arg);
+        case CDROM_SELECT_DISC:
+                return cdrom_ioctl_select_disc(cdi, arg);
+        case CDROMRESET:
+                return cdrom_ioctl_reset(cdi, ip->i_bdev);
+        case CDROM_LOCKDOOR:
+                return cdrom_ioctl_lock_door(cdi, arg);
+        case CDROM_DEBUG:
+                return cdrom_ioctl_debug(cdi, arg);
+        case CDROM_GET_CAPABILITY:
+                return cdrom_ioctl_get_capability(cdi);
+        case CDROM_GET_MCN:
+                return cdrom_ioctl_get_mcn(cdi, argp);
+        case CDROM_DRIVE_STATUS:
+                return cdrom_ioctl_drive_status(cdi, arg);
+        case CDROM_DISC_STATUS:
+                return cdrom_ioctl_disc_status(cdi);
+        case CDROM_CHANGER_NSLOTS:
+                return cdrom_ioctl_changer_nslots(cdi);
+        }
+
+        /*
+         * Use the ioctls that are implemented through the generic_packet()
+         * interface. this may look at bit funny, but if -ENOTTY is
+         * returned that particular ioctl is not implemented and we
+         * let it go through the device specific ones.
+         */
         if (CDROM_CAN(CDC_GENERIC_PACKET)) {
                 ret = mmc_ioctl(cdi, cmd, arg);
-                if (ret != -ENOTTY) {
+                if (ret != -ENOTTY)
                         return ret;
-                }
         }
 
-        /* note: most of the cdinfo() calls are commented out here,
-           because they fill up the sys log when CD players poll
-           the drive. */
+        /*
+         * Note: most of the cdinfo() calls are commented out here,
+         * because they fill up the sys log when CD players poll
+         * the drive.
+         */
         switch (cmd) {
-        case CDROMSUBCHNL: {
-                struct cdrom_subchnl q;
-                u_char requested, back;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                /* cdinfo(CD_DO_IOCTL,"entering CDROMSUBCHNL\n");*/ 
-                IOCTL_IN(arg, struct cdrom_subchnl, q);
-                requested = q.cdsc_format;
-                if (!((requested == CDROM_MSF) ||
-                      (requested == CDROM_LBA)))
-                        return -EINVAL;
-                q.cdsc_format = CDROM_MSF;
-                if ((ret=cdo->audio_ioctl(cdi, cmd, &q)))
-                        return ret;
-                back = q.cdsc_format; /* local copy */
-                sanitize_format(&q.cdsc_absaddr, &back, requested);
-                sanitize_format(&q.cdsc_reladdr, &q.cdsc_format, requested);
-                IOCTL_OUT(arg, struct cdrom_subchnl, q);
-                /* cdinfo(CD_DO_IOCTL, "CDROMSUBCHNL successful\n"); */ 
-                return 0;
-                }
-        case CDROMREADTOCHDR: {
-                struct cdrom_tochdr header;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                /* cdinfo(CD_DO_IOCTL, "entering CDROMREADTOCHDR\n"); */ 
-                IOCTL_IN(arg, struct cdrom_tochdr, header);
-                if ((ret=cdo->audio_ioctl(cdi, cmd, &header)))
-                        return ret;
-                IOCTL_OUT(arg, struct cdrom_tochdr, header);
-                /* cdinfo(CD_DO_IOCTL, "CDROMREADTOCHDR successful\n"); */ 
-                return 0;
-                }
-        case CDROMREADTOCENTRY: {
-                struct cdrom_tocentry entry;
-                u_char requested_format;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                /* cdinfo(CD_DO_IOCTL, "entering CDROMREADTOCENTRY\n"); */ 
-                IOCTL_IN(arg, struct cdrom_tocentry, entry);
-                requested_format = entry.cdte_format;
-                if (!((requested_format == CDROM_MSF) || 
-                        (requested_format == CDROM_LBA)))
-                                return -EINVAL;
-                /* make interface to low-level uniform */
-                entry.cdte_format = CDROM_MSF;
-                if ((ret=cdo->audio_ioctl(cdi, cmd, &entry)))
-                        return ret;
-                sanitize_format(&entry.cdte_addr,
-                &entry.cdte_format, requested_format);
-                IOCTL_OUT(arg, struct cdrom_tocentry, entry);
-                /* cdinfo(CD_DO_IOCTL, "CDROMREADTOCENTRY successful\n"); */ 
-                return 0;
-                }
-        case CDROMPLAYMSF: {
-                struct cdrom_msf msf;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                cdinfo(CD_DO_IOCTL, "entering CDROMPLAYMSF\n"); 
-                IOCTL_IN(arg, struct cdrom_msf, msf);
-                return cdo->audio_ioctl(cdi, cmd, &msf);
-                }
-        case CDROMPLAYTRKIND: {
-                struct cdrom_ti ti;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                cdinfo(CD_DO_IOCTL, "entering CDROMPLAYTRKIND\n"); 
-                IOCTL_IN(arg, struct cdrom_ti, ti);
-                CHECKAUDIO;
-                return cdo->audio_ioctl(cdi, cmd, &ti);
-                }
-        case CDROMVOLCTRL: {
-                struct cdrom_volctrl volume;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                cdinfo(CD_DO_IOCTL, "entering CDROMVOLCTRL\n"); 
-                IOCTL_IN(arg, struct cdrom_volctrl, volume);
-                return cdo->audio_ioctl(cdi, cmd, &volume);
-                }
-        case CDROMVOLREAD: {
-                struct cdrom_volctrl volume;
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                cdinfo(CD_DO_IOCTL, "entering CDROMVOLREAD\n"); 
-                if ((ret=cdo->audio_ioctl(cdi, cmd, &volume)))
-                        return ret;
-                IOCTL_OUT(arg, struct cdrom_volctrl, volume);
-                return 0;
-                }
+        case CDROMSUBCHNL:
+                return cdrom_ioctl_get_subchnl(cdi, argp);
+        case CDROMREADTOCHDR:
+                return cdrom_ioctl_read_tochdr(cdi, argp);
+        case CDROMREADTOCENTRY:
+                return cdrom_ioctl_read_tocentry(cdi, argp);
+        case CDROMPLAYMSF:
+                return cdrom_ioctl_play_msf(cdi, argp);
+        case CDROMPLAYTRKIND:
+                return cdrom_ioctl_play_trkind(cdi, argp);
+        case CDROMVOLCTRL:
+                return cdrom_ioctl_volctrl(cdi, argp);
+        case CDROMVOLREAD:
+                return cdrom_ioctl_volread(cdi, argp);
         case CDROMSTART:
         case CDROMSTOP:
         case CDROMPAUSE:
-        case CDROMRESUME: {
-                if (!CDROM_CAN(CDC_PLAY_AUDIO))
-                        return -ENOSYS;
-                cdinfo(CD_DO_IOCTL, "doing audio ioctl (start/stop/pause/resume)\n"); 
-                CHECKAUDIO;
-                return cdo->audio_ioctl(cdi, cmd, NULL);
-                }
-        } /* switch */
+        case CDROMRESUME:
+                return cdrom_ioctl_audioctl(cdi, cmd);
+        }
 
-        /* do the device specific ioctls */
-        if (CDROM_CAN(CDC_IOCTLS))
-                return cdo->dev_ioctl(cdi, cmd, arg);
-        
         return -ENOSYS;
 }
 
diff --git a/drivers/cdrom/cdu31a.c b/drivers/cdrom/cdu31a.c
index 378e88d20757..72ffd64e8b1e 100644
--- a/drivers/cdrom/cdu31a.c
+++ b/drivers/cdrom/cdu31a.c
@@ -2668,7 +2668,7 @@ static int scd_audio_ioctl(struct cdrom_device_info *cdi,
         return retval;
 }
 
-static int scd_dev_ioctl(struct cdrom_device_info *cdi,
+static int scd_read_audio(struct cdrom_device_info *cdi,
                          unsigned int cmd, unsigned long arg)
 {
         void __user *argp = (void __user *)arg;
@@ -2894,11 +2894,10 @@ static struct cdrom_device_ops scd_dops = {
         .get_mcn                = scd_get_mcn,
         .reset                  = scd_reset,
         .audio_ioctl            = scd_audio_ioctl,
-        .dev_ioctl              = scd_dev_ioctl,
         .capability             = CDC_OPEN_TRAY | CDC_CLOSE_TRAY | CDC_LOCK |
                                   CDC_SELECT_SPEED | CDC_MULTI_SESSION |
                                   CDC_MCN | CDC_MEDIA_CHANGED | CDC_PLAY_AUDIO |
-                                  CDC_RESET | CDC_IOCTLS | CDC_DRIVE_STATUS,
+                                  CDC_RESET | CDC_DRIVE_STATUS,
         .n_minors               = 1,
 };
 
@@ -2936,6 +2935,9 @@ static int scd_block_ioctl(struct inode *inode, struct file *file,
                 case CDROMCLOSETRAY:
                         retval = scd_tray_move(&scd_info, 0);
                         break;
+                case CDROMREADAUDIO:
+                        retval = scd_read_audio(&scd_info, CDROMREADAUDIO, arg);
+                        break;
                 default:
                         retval = cdrom_ioctl(file, &scd_info, inode, cmd, arg);
         }
diff --git a/drivers/cdrom/cm206.c b/drivers/cdrom/cm206.c
index ce127f7ec0f6..f43a988dd413 100644
--- a/drivers/cdrom/cm206.c
+++ b/drivers/cdrom/cm206.c
@@ -218,12 +218,12 @@ static int cm206_base = CM206_BASE;
 static int cm206_irq = CM206_IRQ;
 #ifdef MODULE
 static int cm206[2] = { 0, 0 }; /* for compatible `insmod' parameter passing */
+module_param_array(cm206, int, NULL, 0);        /* base,irq or irq,base */
 #endif
 
-MODULE_PARM(cm206_base, "i");   /* base */
-MODULE_PARM(cm206_irq, "i");    /* irq */
-MODULE_PARM(cm206, "1-2i");     /* base,irq or irq,base */
-MODULE_PARM(auto_probe, "i");   /* auto probe base and irq */
+module_param(cm206_base, int, 0);       /* base */
+module_param(cm206_irq, int, 0);        /* irq */
+module_param(auto_probe, bool, 0);      /* auto probe base and irq */
 MODULE_LICENSE("GPL");
 
 #define POLLOOP 100             /* milliseconds */
@@ -1157,32 +1157,6 @@ static int cm206_audio_ioctl(struct cdrom_device_info *cdi, unsigned int cmd,
         }
 }
 
-/* Ioctl. These ioctls are specific to the cm206 driver. I have made
-   some driver statistics accessible through ioctl calls.
- */
-
-static int cm206_ioctl(struct cdrom_device_info *cdi, unsigned int cmd,
-                       unsigned long arg)
-{
-        switch (cmd) {
-#ifdef STATISTICS
-        case CM206CTL_GET_STAT:
-                if (arg >= NR_STATS)
-                        return -EINVAL;
-                else
-                        return cd->stats[arg];
-        case CM206CTL_GET_LAST_STAT:
-                if (arg >= NR_STATS)
-                        return -EINVAL;
-                else
-                        return cd->last_stat[arg];
-#endif
-        default:
-                debug(("Unknown ioctl call 0x%x\n", cmd));
-                return -EINVAL;
-        }
-}
-
 static int cm206_media_changed(struct cdrom_device_info *cdi, int disc_nr)
 {
         if (cd != NULL) {
@@ -1321,11 +1295,10 @@ static struct cdrom_device_ops cm206_dops = {
         .get_mcn                = cm206_get_upc,
         .reset                  = cm206_reset,
         .audio_ioctl            = cm206_audio_ioctl,
-        .dev_ioctl              = cm206_ioctl,
         .capability             = CDC_CLOSE_TRAY | CDC_OPEN_TRAY | CDC_LOCK |
                                   CDC_MULTI_SESSION | CDC_MEDIA_CHANGED |
                                   CDC_MCN | CDC_PLAY_AUDIO | CDC_SELECT_SPEED |
-                                  CDC_IOCTLS | CDC_DRIVE_STATUS,
+                                  CDC_DRIVE_STATUS,
         .n_minors               = 1,
 };
 
@@ -1350,6 +1323,21 @@ static int cm206_block_release(struct inode *inode, struct file *file)
 static int cm206_block_ioctl(struct inode *inode, struct file *file,
                                 unsigned cmd, unsigned long arg)
 {
+        switch (cmd) {
+#ifdef STATISTICS
+        case CM206CTL_GET_STAT:
+                if (arg >= NR_STATS)
+                        return -EINVAL;
+                return cd->stats[arg];
+        case CM206CTL_GET_LAST_STAT:
+                if (arg >= NR_STATS)
+                        return -EINVAL;
+                return cd->last_stat[arg];
+#endif
+        default:
+                break;
+        }
+
         return cdrom_ioctl(file, &cm206_info, inode, cmd, arg);
 }
 
diff --git a/drivers/cdrom/sbpcd.c b/drivers/cdrom/sbpcd.c
index 466e9c2974bd..05c9e865ecaf 100644
--- a/drivers/cdrom/sbpcd.c
+++ b/drivers/cdrom/sbpcd.c
@@ -464,8 +464,13 @@ static int sbpcd[] =
 static  __cacheline_aligned DEFINE_SPINLOCK(sbpcd_lock);
 static struct request_queue *sbpcd_queue;
 
-MODULE_PARM(sbpcd, "2i");
-MODULE_PARM(max_drives, "i");
+/* You can only set the first pair, from old MODULE_PARM code.  */
+static int sbpcd_set(const char *val, struct kernel_param *kp)
+{
+        get_options((char *)val, 2, (int *)sbpcd);
+        return 0;
+}
+module_param_call(sbpcd, sbpcd_set, NULL, NULL, 0);
 
 #define NUM_PROBE  (sizeof(sbpcd) / sizeof(int))
 
@@ -553,6 +558,7 @@ static unsigned char msgnum;
 static char msgbuf[80];
 
 static int max_drives = MAX_DRIVES;
+module_param(max_drives, int, 0);
 #ifndef MODULE
 static unsigned char setup_done;
 static const char *str_sb_l = "soundblaster";
@@ -4160,332 +4166,6 @@ static int sbpcd_get_last_session(struct cdrom_device_info *cdi, struct cdrom_mu
         return  0;
 }
 
-/*==========================================================================*/
-/*==========================================================================*/
-/*
- * ioctl support
- */
-static int sbpcd_dev_ioctl(struct cdrom_device_info *cdi, u_int cmd,
-                      u_long arg)
-{
-        struct sbpcd_drive *p = cdi->handle;
-        int i;
-        
-        msg(DBG_IO2,"ioctl(%s, 0x%08lX, 0x%08lX)\n", cdi->name, cmd, arg);
-        if (p->drv_id==-1) {
-                msg(DBG_INF, "ioctl: bad device: %s\n", cdi->name);
-                return (-ENXIO);             /* no such drive */
-        }
-        down(&ioctl_read_sem);
-        if (p != current_drive)
-                switch_drive(p);
-        
-        msg(DBG_IO2,"ioctl: device %s, request %04X\n",cdi->name,cmd);
-        switch (cmd)            /* Sun-compatible */
-        {
-        case DDIOCSDBG:         /* DDI Debug */
-                if (!capable(CAP_SYS_ADMIN)) RETURN_UP(-EPERM);
-                i=sbpcd_dbg_ioctl(arg,1);
-                RETURN_UP(i);
-        case CDROMRESET:      /* hard reset the drive */
-                msg(DBG_IOC,"ioctl: CDROMRESET entered.\n");
-                i=DriveReset();
-                current_drive->audio_state=0;
-                RETURN_UP(i);
-                
-        case CDROMREADMODE1:
-                msg(DBG_IOC,"ioctl: CDROMREADMODE1 requested.\n");
-#ifdef SAFE_MIXED
-                if (current_drive->has_data>1) RETURN_UP(-EBUSY);
-#endif /* SAFE_MIXED */
-                cc_ModeSelect(CD_FRAMESIZE);
-                cc_ModeSense();
-                current_drive->mode=READ_M1;
-                RETURN_UP(0);
-                
-        case CDROMREADMODE2: /* not usable at the moment */
-                msg(DBG_IOC,"ioctl: CDROMREADMODE2 requested.\n");
-#ifdef SAFE_MIXED
-                if (current_drive->has_data>1) RETURN_UP(-EBUSY);
-#endif /* SAFE_MIXED */
-                cc_ModeSelect(CD_FRAMESIZE_RAW1);
-                cc_ModeSense();
-                current_drive->mode=READ_M2;
-                RETURN_UP(0);
-                
-        case CDROMAUDIOBUFSIZ: /* configure the audio buffer size */
-                msg(DBG_IOC,"ioctl: CDROMAUDIOBUFSIZ entered.\n");
-                if (current_drive->sbp_audsiz>0)
-                        vfree(current_drive->aud_buf);
-                current_drive->aud_buf=NULL;
-                current_drive->sbp_audsiz=arg;
-                
-                if (current_drive->sbp_audsiz>16)
-                {
-                        current_drive->sbp_audsiz = 0;
-                        RETURN_UP(current_drive->sbp_audsiz);
-                }
-        
-                if (current_drive->sbp_audsiz>0)
-                {
-                        current_drive->aud_buf=(u_char *) vmalloc(current_drive->sbp_audsiz*CD_FRAMESIZE_RAW);
-                        if (current_drive->aud_buf==NULL)
-                        {
-                                msg(DBG_INF,"audio buffer (%d frames) not available.\n",current_drive->sbp_audsiz);
-                                current_drive->sbp_audsiz=0;
-                        }
-                        else msg(DBG_INF,"audio buffer size: %d frames.\n",current_drive->sbp_audsiz);
-                }
-                RETURN_UP(current_drive->sbp_audsiz);
-
-        case CDROMREADAUDIO:
-        { /* start of CDROMREADAUDIO */
-                int i=0, j=0, frame, block=0;
-                u_int try=0;
-                u_long timeout;
-                u_char *p;
-                u_int data_tries = 0;
-                u_int data_waits = 0;
-                u_int data_retrying = 0;
-                int status_tries;
-                int error_flag;
-                
-                msg(DBG_IOC,"ioctl: CDROMREADAUDIO entered.\n");
-                if (fam0_drive) RETURN_UP(-EINVAL);
-                if (famL_drive) RETURN_UP(-EINVAL);
-                if (famV_drive) RETURN_UP(-EINVAL);
-                if (famT_drive) RETURN_UP(-EINVAL);
-#ifdef SAFE_MIXED
-                if (current_drive->has_data>1) RETURN_UP(-EBUSY);
-#endif /* SAFE_MIXED */ 
-                if (current_drive->aud_buf==NULL) RETURN_UP(-EINVAL);
-                if (copy_from_user(&read_audio, (void __user *)arg,
-                                   sizeof(struct cdrom_read_audio)))
-                        RETURN_UP(-EFAULT);
-                if (read_audio.nframes < 0 || read_audio.nframes>current_drive->sbp_audsiz) RETURN_UP(-EINVAL);
-                if (!access_ok(VERIFY_WRITE, read_audio.buf,
-                              read_audio.nframes*CD_FRAMESIZE_RAW))
-                        RETURN_UP(-EFAULT);
-                
-                if (read_audio.addr_format==CDROM_MSF) /* MSF-bin specification of where to start */
-                        block=msf2lba(&read_audio.addr.msf.minute);
-                else if (read_audio.addr_format==CDROM_LBA) /* lba specification of where to start */
-                        block=read_audio.addr.lba;
-                else RETURN_UP(-EINVAL);
-#if 000
-                i=cc_SetSpeed(speed_150,0,0);
-                if (i) msg(DBG_AUD,"read_audio: SetSpeed error %d\n", i);
-#endif
-                msg(DBG_AUD,"read_audio: lba: %d, msf: %06X\n",
-                    block, blk2msf(block));
-                msg(DBG_AUD,"read_audio: before cc_ReadStatus.\n");
-#if OLD_BUSY
-                while (busy_data) sbp_sleep(HZ/10); /* wait a bit */
-                busy_audio=1;
-#endif /* OLD_BUSY */ 
-                error_flag=0;
-                for (data_tries=5; data_tries>0; data_tries--)
-                {
-                        msg(DBG_AUD,"data_tries=%d ...\n", data_tries);
-                        current_drive->mode=READ_AU;
-                        cc_ModeSelect(CD_FRAMESIZE_RAW);
-                        cc_ModeSense();
-                        for (status_tries=3; status_tries > 0; status_tries--)
-                        {
-                                flags_cmd_out |= f_respo3;
-                                cc_ReadStatus();
-                                if (sbp_status() != 0) break;
-                                if (st_check) cc_ReadError();
-                                sbp_sleep(1);    /* wait a bit, try again */
-                        }
-                        if (status_tries == 0)
-                        {
-                                msg(DBG_AUD,"read_audio: sbp_status: failed after 3 tries in line %d.\n", __LINE__);
-                                continue;
-                        }
-                        msg(DBG_AUD,"read_audio: sbp_status: ok.\n");
-                        
-                        flags_cmd_out = f_putcmd | f_respo2 | f_ResponseStatus | f_obey_p_check;
-                        if (fam0L_drive)
-                        {
-                                flags_cmd_out |= f_lopsta | f_getsta | f_bit1;
-                                cmd_type=READ_M2;
-                                drvcmd[0]=CMD0_READ_XA; /* "read XA frames", old drives */
-                                drvcmd[1]=(block>>16)&0x000000ff;
-                                drvcmd[2]=(block>>8)&0x000000ff;
-                                drvcmd[3]=block&0x000000ff;
-                                drvcmd[4]=0;
-                                drvcmd[5]=read_audio.nframes; /* # of frames */
-                                drvcmd[6]=0;
-                        }
-                        else if (fam1_drive)
-                        {
-                                drvcmd[0]=CMD1_READ; /* "read frames", new drives */
-                                lba2msf(block,&drvcmd[1]); /* msf-bin format required */
-                                drvcmd[4]=0;
-                                drvcmd[5]=0;
-                                drvcmd[6]=read_audio.nframes; /* # of frames */
-                        }
-                        else if (fam2_drive)
-                        {
-                                drvcmd[0]=CMD2_READ_XA2;
-                                lba2msf(block,&drvcmd[1]); /* msf-bin format required */
-                                drvcmd[4]=0;
-                                drvcmd[5]=read_audio.nframes; /* # of frames */
-                                drvcmd[6]=0x11; /* raw mode */
-                        }
-                        else if (famT_drive) /* CD-55A: not tested yet */
-                        {
-                        }
-                        msg(DBG_AUD,"read_audio: before giving \"read\" command.\n");
-                        flags_cmd_out=f_putcmd;
-                        response_count=0;
-                        i=cmd_out();
-                        if (i<0) msg(DBG_INF,"error giving READ AUDIO command: %0d\n", i);
-                        sbp_sleep(0);
-                        msg(DBG_AUD,"read_audio: after giving \"read\" command.\n");
-                        for (frame=1;frame<2 && !error_flag; frame++)
-                        {
-                                try=maxtim_data;
-                                for (timeout=jiffies+9*HZ; ; )
-                                {
-                                        for ( ; try!=0;try--)
-                                        {
-                                                j=inb(CDi_status);
-                                                if (!(j&s_not_data_ready)) break;
-                                                if (!(j&s_not_result_ready)) break;
-                                                if (fam0L_drive) if (j&s_attention) break;
-                                        }
-                                        if (try != 0 || time_after_eq(jiffies, timeout)) break;
-                                        if (data_retrying == 0) data_waits++;
-                                        data_retrying = 1;
-                                        sbp_sleep(1);
-                                        try = 1;
-                                }
-                                if (try==0)
-                                {
-                                        msg(DBG_INF,"read_audio: sbp_data: CDi_status timeout.\n");
-                                        error_flag++;
-                                        break;
-                                }
-                                msg(DBG_AUD,"read_audio: sbp_data: CDi_status ok.\n");
-                                if (j&s_not_data_ready)
-                                {
-                                        msg(DBG_INF, "read_audio: sbp_data: DATA_READY timeout.\n");
-                                        error_flag++;
-                                        break;
-                                }
-                                msg(DBG_AUD,"read_audio: before reading data.\n");
-                                error_flag=0;
-                                p = current_drive->aud_buf;
-                                if (sbpro_type==1) OUT(CDo_sel_i_d,1);
-                                if (do_16bit)
-                                {
-                                        u_short *p2 = (u_short *) p;
-
-                                        for (; (u_char *) p2 < current_drive->aud_buf + read_audio.nframes*CD_FRAMESIZE_RAW;)
-                                        {
-                                                if ((inb_p(CDi_status)&s_not_data_ready)) continue;
-
-                                                /* get one sample */
-                                                *p2++ = inw_p(CDi_data);
-                                                *p2++ = inw_p(CDi_data);
-                                        }
-                                } else {
-                                        for (; p < current_drive->aud_buf + read_audio.nframes*CD_FRAMESIZE_RAW;)
-                                        {
-                                                if ((inb_p(CDi_status)&s_not_data_ready)) continue;
-
-                                                /* get one sample */
-                                                *p++ = inb_p(CDi_data);
-                                                *p++ = inb_p(CDi_data);
-                                                *p++ = inb_p(CDi_data);
-                                                *p++ = inb_p(CDi_data);
-                                        }
-                                }
-                                if (sbpro_type==1) OUT(CDo_sel_i_d,0);
-                                data_retrying = 0;
-                        }
-                        msg(DBG_AUD,"read_audio: after reading data.\n");
-                        if (error_flag)    /* must have been spurious D_RDY or (ATTN&&!D_RDY) */
-                        {
-                                msg(DBG_AUD,"read_audio: read aborted by drive\n");
-#if 0000
-                                i=cc_DriveReset();                /* ugly fix to prevent a hang */
-#else
-                                i=cc_ReadError();
-#endif
-                                continue;
-                        }
-                        if (fam0L_drive)
-                        {
-                                i=maxtim_data;
-                                for (timeout=jiffies+9*HZ; time_before(jiffies, timeout); timeout--)
-                                {
-                                        for ( ;i!=0;i--)
-                                        {
-                                                j=inb(CDi_status);
-                                                if (!(j&s_not_data_ready)) break;
-                                                if (!(j&s_not_result_ready)) break;
-                                                if (j&s_attention) break;
-                                        }
-                                        if (i != 0 || time_after_eq(jiffies, timeout)) break;
-                                        sbp_sleep(0);
-                                        i = 1;
-                                }
-                                if (i==0) msg(DBG_AUD,"read_audio: STATUS TIMEOUT AFTER READ");
-                                if (!(j&s_attention))
-                                {
-                                        msg(DBG_AUD,"read_audio: sbp_data: timeout waiting DRV_ATTN - retrying\n");
-                                        i=cc_DriveReset();  /* ugly fix to prevent a hang */
-                                        continue;
-                                }
-                        }
-                        do
-                        {
-                                if (fam0L_drive) cc_ReadStatus();
-                                i=ResponseStatus();  /* builds status_bits, returns orig. status (old) or faked p_success (new) */
-                                if (i<0) { msg(DBG_AUD,
-                                               "read_audio: cc_ReadStatus error after read: %02X\n",
-                                               current_drive->status_bits);
-                                           continue; /* FIXME */
-                                   }
-                        }
-                        while ((fam0L_drive)&&(!st_check)&&(!(i&p_success)));
-                        if (st_check)
-                        {
-                                i=cc_ReadError();
-                                msg(DBG_AUD,"read_audio: cc_ReadError was necessary after read: %02X\n",i);
-                                continue;
-                        }
-                        if (copy_to_user(read_audio.buf,
-                                         current_drive->aud_buf,
-                                         read_audio.nframes * CD_FRAMESIZE_RAW))
-                                RETURN_UP(-EFAULT);
-                        msg(DBG_AUD,"read_audio: copy_to_user done.\n");
-                        break;
-                }
-                cc_ModeSelect(CD_FRAMESIZE);
-                cc_ModeSense();
-                current_drive->mode=READ_M1;
-#if OLD_BUSY
-                busy_audio=0;
-#endif /* OLD_BUSY */ 
-                if (data_tries == 0)
-                {
-                        msg(DBG_AUD,"read_audio: failed after 5 tries in line %d.\n", __LINE__);
-                        RETURN_UP(-EIO);
-                }
-                msg(DBG_AUD,"read_audio: successful return.\n");
-                RETURN_UP(0);
-        } /* end of CDROMREADAUDIO */
-                
-        default:
-                msg(DBG_IOC,"ioctl: unknown function request %04X\n", cmd);
-                RETURN_UP(-EINVAL);
-        } /* end switch(cmd) */
-}
-
 static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                        void * arg)
 {
@@ -4530,7 +4210,7 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                 default:
                         RETURN_UP(-EINVAL);
                 }
-                
+
         case CDROMRESUME: /* resume paused audio play */
                 msg(DBG_IOC,"ioctl: CDROMRESUME entered.\n");
                 /* resume playing audio tracks when a previous PLAY AUDIO call has  */
@@ -4544,12 +4224,12 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                 if (i<0) RETURN_UP(-EIO);
                 current_drive->audio_state=audio_playing;
                 RETURN_UP(0);
-                
+
         case CDROMPLAYMSF:
                 msg(DBG_IOC,"ioctl: CDROMPLAYMSF entered.\n");
 #ifdef SAFE_MIXED
                 if (current_drive->has_data>1) RETURN_UP(-EBUSY);
-#endif /* SAFE_MIXED */ 
+#endif /* SAFE_MIXED */
                 if (current_drive->audio_state==audio_playing)
                 {
                         i=cc_Pause_Resume(1);
@@ -4584,7 +4264,7 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                 msg(DBG_IOC,"ioctl: CDROMPLAYTRKIND entered.\n");
 #ifdef SAFE_MIXED
                 if (current_drive->has_data>1) RETURN_UP(-EBUSY);
-#endif /* SAFE_MIXED */ 
+#endif /* SAFE_MIXED */
                 if (current_drive->audio_state==audio_playing)
                 {
                         msg(DBG_IOX,"CDROMPLAYTRKIND: already audio_playing.\n");
@@ -4654,13 +4334,13 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                 cc_DriveReset();
 #endif
                 RETURN_UP(i);
-                
+
         case CDROMSTART:  /* Spin up the drive */
                 msg(DBG_IOC,"ioctl: CDROMSTART entered.\n");
                 cc_SpinUp();
                 current_drive->audio_state=0;
                 RETURN_UP(0);
-                
+
         case CDROMVOLCTRL:   /* Volume control */
                 msg(DBG_IOC,"ioctl: CDROMVOLCTRL entered.\n");
                 memcpy(&volctrl,(char *) arg,sizeof(volctrl));
@@ -4670,7 +4350,7 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                 current_drive->vol_ctrl1=volctrl.channel1;
                 i=cc_SetVolume();
                 RETURN_UP(0);
-                
+
         case CDROMVOLREAD:   /* read Volume settings from drive */
                 msg(DBG_IOC,"ioctl: CDROMVOLREAD entered.\n");
                 st=cc_GetVolume();
@@ -4694,7 +4374,7 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                 if (i<0) {
                         j=cc_ReadError(); /* clear out error status from drive */
                         current_drive->audio_state=CDROM_AUDIO_NO_STATUS;
-                        /* get and set the disk state here, 
+                        /* get and set the disk state here,
                         probably not the right place, but who cares!
                         It makes it work properly! --AJK */
                         if (current_drive->CD_changed==0xFF) {
@@ -4715,8 +4395,8 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                         }
                 }
                 memcpy(&SC, (void *) arg, sizeof(struct cdrom_subchnl));
-                /* 
-                        This virtual crap is very bogus! 
+                /*
+                        This virtual crap is very bogus!
                         It doesn't detect when the cd is done playing audio!
                         Lets do this right with proper hardware register reading!
                 */
@@ -4775,7 +4455,7 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
                     SC.cdsc_trk,SC.cdsc_ind,
                     SC.cdsc_absaddr,SC.cdsc_reladdr);
                 RETURN_UP(0);
-                
+
         default:
                 msg(DBG_IOC,"ioctl: unknown function request %04X\n", cmd);
                 RETURN_UP(-EINVAL);
@@ -4788,7 +4468,7 @@ static int sbpcd_audio_ioctl(struct cdrom_device_info *cdi, u_int cmd,
 static void sbp_transfer(struct request *req)
 {
         long offs;
-        
+
         while ( (req->nr_sectors > 0) &&
                (req->sector/4 >= current_drive->sbp_first_frame) &&
                (req->sector/4 <= current_drive->sbp_last_frame) )
@@ -4807,11 +4487,11 @@ static void sbp_transfer(struct request *req)
  *
  *  This is a kludge so we don't need to modify end_request.
  *  We put the req we take out after INIT_REQUEST in the requests list,
- *  so that end_request will discard it. 
+ *  so that end_request will discard it.
  *
  *  The bug could be present in other block devices, perhaps we
  *  should modify INIT_REQUEST and end_request instead, and
- *  change every block device.. 
+ *  change every block device..
  *
  *  Could be a race here?? Could e.g. a timer interrupt schedule() us?
  *  If so, we should copy end_request here, and do it right.. (or
@@ -4883,19 +4563,19 @@ static void do_sbpcd_request(request_queue_t * q)
         while (busy_audio) sbp_sleep(HZ); /* wait a bit */
         busy_data=1;
 #endif /* OLD_BUSY */
-        
+
         if (p->audio_state==audio_playing) goto err_done;
         if (p != current_drive)
                 switch_drive(p);
 
         block = req->sector; /* always numbered as 512-byte-pieces */
         nsect = req->nr_sectors; /* always counted as 512-byte-pieces */
-        
+
         msg(DBG_BSZ,"read sector %d (%d sectors)\n", block, nsect);
 #if 0
         msg(DBG_MUL,"read LBA %d\n", block/4);
 #endif
-        
+
         sbp_transfer(req);
         /* if we satisfied the request from the buffer, we're done. */
         if (req->nr_sectors == 0)
@@ -4914,10 +4594,10 @@ static void do_sbpcd_request(request_queue_t * q)
         i=prepare(0,0); /* at moment not really a hassle check, but ... */
         if (i!=0)
                 msg(DBG_INF,"\"prepare\" tells error %d -- ignored\n", i);
-#endif /* FUTURE */ 
-        
+#endif /* FUTURE */
+
         if (!st_spinning) cc_SpinUp();
-        
+
         for (data_tries=n_retries; data_tries > 0; data_tries--)
         {
                 for (status_tries=3; status_tries > 0; status_tries--)
@@ -4940,7 +4620,7 @@ static void do_sbpcd_request(request_queue_t * q)
                 {
 #ifdef SAFE_MIXED
                         current_drive->has_data=2; /* is really a data disk */
-#endif /* SAFE_MIXED */ 
+#endif /* SAFE_MIXED */
 #ifdef DEBUG_GTL
                         printk(" do_sbpcd_request[%do](%p:%ld+%ld) end 3, Time:%li\n",
                                 xnr, req, req->sector, req->nr_sectors, jiffies);
@@ -4951,7 +4631,7 @@ static void do_sbpcd_request(request_queue_t * q)
                         goto request_loop;
                 }
         }
-        
+
  err_done:
 #if OLD_BUSY
         busy_data=0;
@@ -4976,7 +4656,7 @@ static void sbp_read_cmd(struct request *req)
 
         int i;
         int block;
-        
+
         current_drive->sbp_first_frame=current_drive->sbp_last_frame=-1;      /* purge buffer */
         current_drive->sbp_current = 0;
         block=req->sector/4;
@@ -4993,7 +4673,7 @@ static void sbp_read_cmd(struct request *req)
                         current_drive->sbp_read_frames=1;
                 }
         }
-        
+
         flags_cmd_out = f_putcmd | f_respo2 | f_ResponseStatus | f_obey_p_check;
         clr_cmdbuf();
         if (famV_drive)
@@ -5092,7 +4772,7 @@ static int sbp_data(struct request *req)
         int success;
         int wait;
         int duration;
-        
+
         error_flag=0;
         success=0;
 #if LONG_TIMING
@@ -5105,12 +4785,12 @@ static int sbp_data(struct request *req)
         for (frame=0;frame<current_drive->sbp_read_frames&&!error_flag; frame++)
         {
                 SBPCD_CLI;
-                
+
                 del_timer(&data_timer);
                 data_timer.expires=jiffies+max_latency;
                 timed_out_data=0;
                 add_timer(&data_timer);
-                while (!timed_out_data) 
+                while (!timed_out_data)
                 {
                         if (current_drive->f_multisession) try=maxtim_data*4;
                         else try=maxtim_data;
@@ -5207,9 +4887,9 @@ static int sbp_data(struct request *req)
                         else
                           {
                             sbp_sleep(1);
-                            OUT(CDo_sel_i_d,0); 
+                            OUT(CDo_sel_i_d,0);
                             i=inb(CDi_status);
-                          } 
+                          }
                         if (!(i&s_not_data_ready))
                         {
                                 OUT(CDo_sel_i_d,1);
@@ -5311,7 +4991,7 @@ static int sbp_data(struct request *req)
                 }
                 SBPCD_STI;
         }
-        
+
 #if 0
         if (!success)
 #endif
@@ -5370,7 +5050,326 @@ static int sbpcd_block_ioctl(struct inode *inode, struct file *file,
                                 unsigned cmd, unsigned long arg)
 {
         struct sbpcd_drive *p = inode->i_bdev->bd_disk->private_data;
-        return cdrom_ioctl(file, p->sbpcd_infop, inode, cmd, arg);
+        struct cdrom_device_info *cdi = p->sbpcd_infop;
+        int ret, i;
+
+        ret = cdrom_ioctl(file, p->sbpcd_infop, inode, cmd, arg);
+        if (ret != -ENOSYS)
+                return ret;
+
+        msg(DBG_IO2,"ioctl(%s, 0x%08lX, 0x%08lX)\n", cdi->name, cmd, arg);
+        if (p->drv_id==-1) {
+                msg(DBG_INF, "ioctl: bad device: %s\n", cdi->name);
+                return (-ENXIO);             /* no such drive */
+        }
+        down(&ioctl_read_sem);
+        if (p != current_drive)
+                switch_drive(p);
+        
+        msg(DBG_IO2,"ioctl: device %s, request %04X\n",cdi->name,cmd);
+        switch (cmd)            /* Sun-compatible */
+        {
+        case DDIOCSDBG:         /* DDI Debug */
+                if (!capable(CAP_SYS_ADMIN)) RETURN_UP(-EPERM);
+                i=sbpcd_dbg_ioctl(arg,1);
+                RETURN_UP(i);
+        case CDROMRESET:      /* hard reset the drive */
+                msg(DBG_IOC,"ioctl: CDROMRESET entered.\n");
+                i=DriveReset();
+                current_drive->audio_state=0;
+                RETURN_UP(i);
+
+        case CDROMREADMODE1:
+                msg(DBG_IOC,"ioctl: CDROMREADMODE1 requested.\n");
+#ifdef SAFE_MIXED
+                if (current_drive->has_data>1) RETURN_UP(-EBUSY);
+#endif /* SAFE_MIXED */
+                cc_ModeSelect(CD_FRAMESIZE);
+                cc_ModeSense();
+                current_drive->mode=READ_M1;
+                RETURN_UP(0);
+
+        case CDROMREADMODE2: /* not usable at the moment */
+                msg(DBG_IOC,"ioctl: CDROMREADMODE2 requested.\n");
+#ifdef SAFE_MIXED
+                if (current_drive->has_data>1) RETURN_UP(-EBUSY);
+#endif /* SAFE_MIXED */
+                cc_ModeSelect(CD_FRAMESIZE_RAW1);
+                cc_ModeSense();
+                current_drive->mode=READ_M2;
+                RETURN_UP(0);
+
+        case CDROMAUDIOBUFSIZ: /* configure the audio buffer size */
+                msg(DBG_IOC,"ioctl: CDROMAUDIOBUFSIZ entered.\n");
+                if (current_drive->sbp_audsiz>0)
+                        vfree(current_drive->aud_buf);
+                current_drive->aud_buf=NULL;
+                current_drive->sbp_audsiz=arg;
+
+                if (current_drive->sbp_audsiz>16)
+                {
+                        current_drive->sbp_audsiz = 0;
+                        RETURN_UP(current_drive->sbp_audsiz);
+                }
+        
+                if (current_drive->sbp_audsiz>0)
+                {
+                        current_drive->aud_buf=(u_char *) vmalloc(current_drive->sbp_audsiz*CD_FRAMESIZE_RAW);
+                        if (current_drive->aud_buf==NULL)
+                        {
+                                msg(DBG_INF,"audio buffer (%d frames) not available.\n",current_drive->sbp_audsiz);
+                                current_drive->sbp_audsiz=0;
+                        }
+                        else msg(DBG_INF,"audio buffer size: %d frames.\n",current_drive->sbp_audsiz);
+                }
+                RETURN_UP(current_drive->sbp_audsiz);
+
+        case CDROMREADAUDIO:
+        { /* start of CDROMREADAUDIO */
+                int i=0, j=0, frame, block=0;
+                u_int try=0;
+                u_long timeout;
+                u_char *p;
+                u_int data_tries = 0;
+                u_int data_waits = 0;
+                u_int data_retrying = 0;
+                int status_tries;
+                int error_flag;
+
+                msg(DBG_IOC,"ioctl: CDROMREADAUDIO entered.\n");
+                if (fam0_drive) RETURN_UP(-EINVAL);
+                if (famL_drive) RETURN_UP(-EINVAL);
+                if (famV_drive) RETURN_UP(-EINVAL);
+                if (famT_drive) RETURN_UP(-EINVAL);
+#ifdef SAFE_MIXED
+                if (current_drive->has_data>1) RETURN_UP(-EBUSY);
+#endif /* SAFE_MIXED */
+                if (current_drive->aud_buf==NULL) RETURN_UP(-EINVAL);
+                if (copy_from_user(&read_audio, (void __user *)arg,
+                                   sizeof(struct cdrom_read_audio)))
+                        RETURN_UP(-EFAULT);
+                if (read_audio.nframes < 0 || read_audio.nframes>current_drive->sbp_audsiz) RETURN_UP(-EINVAL);
+                if (!access_ok(VERIFY_WRITE, read_audio.buf,
+                              read_audio.nframes*CD_FRAMESIZE_RAW))
+                        RETURN_UP(-EFAULT);
+
+                if (read_audio.addr_format==CDROM_MSF) /* MSF-bin specification of where to start */
+                        block=msf2lba(&read_audio.addr.msf.minute);
+                else if (read_audio.addr_format==CDROM_LBA) /* lba specification of where to start */
+                        block=read_audio.addr.lba;
+                else RETURN_UP(-EINVAL);
+#if 000
+                i=cc_SetSpeed(speed_150,0,0);
+                if (i) msg(DBG_AUD,"read_audio: SetSpeed error %d\n", i);
+#endif
+                msg(DBG_AUD,"read_audio: lba: %d, msf: %06X\n",
+                    block, blk2msf(block));
+                msg(DBG_AUD,"read_audio: before cc_ReadStatus.\n");
+#if OLD_BUSY
+                while (busy_data) sbp_sleep(HZ/10); /* wait a bit */
+                busy_audio=1;
+#endif /* OLD_BUSY */
+                error_flag=0;
+                for (data_tries=5; data_tries>0; data_tries--)
+                {
+                        msg(DBG_AUD,"data_tries=%d ...\n", data_tries);
+                        current_drive->mode=READ_AU;
+                        cc_ModeSelect(CD_FRAMESIZE_RAW);
+                        cc_ModeSense();
+                        for (status_tries=3; status_tries > 0; status_tries--)
+                        {
+                                flags_cmd_out |= f_respo3;
+                                cc_ReadStatus();
+                                if (sbp_status() != 0) break;
+                                if (st_check) cc_ReadError();
+                                sbp_sleep(1);    /* wait a bit, try again */
+                        }
+                        if (status_tries == 0)
+                        {
+                                msg(DBG_AUD,"read_audio: sbp_status: failed after 3 tries in line %d.\n", __LINE__);
+                                continue;
+                        }
+                        msg(DBG_AUD,"read_audio: sbp_status: ok.\n");
+
+                        flags_cmd_out = f_putcmd | f_respo2 | f_ResponseStatus | f_obey_p_check;
+                        if (fam0L_drive)
+                        {
+                                flags_cmd_out |= f_lopsta | f_getsta | f_bit1;
+                                cmd_type=READ_M2;
+                                drvcmd[0]=CMD0_READ_XA; /* "read XA frames", old drives */
+                                drvcmd[1]=(block>>16)&0x000000ff;
+                                drvcmd[2]=(block>>8)&0x000000ff;
+                                drvcmd[3]=block&0x000000ff;
+                                drvcmd[4]=0;
+                                drvcmd[5]=read_audio.nframes; /* # of frames */
+                                drvcmd[6]=0;
+                        }
+                        else if (fam1_drive)
+                        {
+                                drvcmd[0]=CMD1_READ; /* "read frames", new drives */
+                                lba2msf(block,&drvcmd[1]); /* msf-bin format required */
+                                drvcmd[4]=0;
+                                drvcmd[5]=0;
+                                drvcmd[6]=read_audio.nframes; /* # of frames */
+                        }
+                        else if (fam2_drive)
+                        {
+                                drvcmd[0]=CMD2_READ_XA2;
+                                lba2msf(block,&drvcmd[1]); /* msf-bin format required */
+                                drvcmd[4]=0;
+                                drvcmd[5]=read_audio.nframes; /* # of frames */
+                                drvcmd[6]=0x11; /* raw mode */
+                        }
+                        else if (famT_drive) /* CD-55A: not tested yet */
+                        {
+                        }
+                        msg(DBG_AUD,"read_audio: before giving \"read\" command.\n");
+                        flags_cmd_out=f_putcmd;
+                        response_count=0;
+                        i=cmd_out();
+                        if (i<0) msg(DBG_INF,"error giving READ AUDIO command: %0d\n", i);
+                        sbp_sleep(0);
+                        msg(DBG_AUD,"read_audio: after giving \"read\" command.\n");
+                        for (frame=1;frame<2 && !error_flag; frame++)
+                        {
+                                try=maxtim_data;
+                                for (timeout=jiffies+9*HZ; ; )
+                                {
+                                        for ( ; try!=0;try--)
+                                        {
+                                                j=inb(CDi_status);
+                                                if (!(j&s_not_data_ready)) break;
+                                                if (!(j&s_not_result_ready)) break;
+                                                if (fam0L_drive) if (j&s_attention) break;
+                                        }
+                                        if (try != 0 || time_after_eq(jiffies, timeout)) break;
+                                        if (data_retrying == 0) data_waits++;
+                                        data_retrying = 1;
+                                        sbp_sleep(1);
+                                        try = 1;
+                                }
+                                if (try==0)
+                                {
+                                        msg(DBG_INF,"read_audio: sbp_data: CDi_status timeout.\n");
+                                        error_flag++;
+                                        break;
+                                }
+                                msg(DBG_AUD,"read_audio: sbp_data: CDi_status ok.\n");
+                                if (j&s_not_data_ready)
+                                {
+                                        msg(DBG_INF, "read_audio: sbp_data: DATA_READY timeout.\n");
+                                        error_flag++;
+                                        break;
+                                }
+                                msg(DBG_AUD,"read_audio: before reading data.\n");
+                                error_flag=0;
+                                p = current_drive->aud_buf;
+                                if (sbpro_type==1) OUT(CDo_sel_i_d,1);
+                                if (do_16bit)
+                                {
+                                        u_short *p2 = (u_short *) p;
+
+                                        for (; (u_char *) p2 < current_drive->aud_buf + read_audio.nframes*CD_FRAMESIZE_RAW;)
+                                        {
+                                                if ((inb_p(CDi_status)&s_not_data_ready)) continue;
+
+                                                /* get one sample */
+                                                *p2++ = inw_p(CDi_data);
+                                                *p2++ = inw_p(CDi_data);
+                                        }
+                                } else {
+                                        for (; p < current_drive->aud_buf + read_audio.nframes*CD_FRAMESIZE_RAW;)
+                                        {
+                                                if ((inb_p(CDi_status)&s_not_data_ready)) continue;
+
+                                                /* get one sample */
+                                                *p++ = inb_p(CDi_data);
+                                                *p++ = inb_p(CDi_data);
+                                                *p++ = inb_p(CDi_data);
+                                                *p++ = inb_p(CDi_data);
+                                        }
+                                }
+                                if (sbpro_type==1) OUT(CDo_sel_i_d,0);
+                                data_retrying = 0;
+                        }
+                        msg(DBG_AUD,"read_audio: after reading data.\n");
+                        if (error_flag)    /* must have been spurious D_RDY or (ATTN&&!D_RDY) */
+                        {
+                                msg(DBG_AUD,"read_audio: read aborted by drive\n");
+#if 0000
+                                i=cc_DriveReset();                /* ugly fix to prevent a hang */
+#else
+                                i=cc_ReadError();
+#endif
+                                continue;
+                        }
+                        if (fam0L_drive)
+                        {
+                                i=maxtim_data;
+                                for (timeout=jiffies+9*HZ; time_before(jiffies, timeout); timeout--)
+                                {
+                                        for ( ;i!=0;i--)
+                                        {
+                                                j=inb(CDi_status);
+                                                if (!(j&s_not_data_ready)) break;
+                                                if (!(j&s_not_result_ready)) break;
+                                                if (j&s_attention) break;
+                                        }
+                                        if (i != 0 || time_after_eq(jiffies, timeout)) break;
+                                        sbp_sleep(0);
+                                        i = 1;
+                                }
+                                if (i==0) msg(DBG_AUD,"read_audio: STATUS TIMEOUT AFTER READ");
+                                if (!(j&s_attention))
+                                {
+                                        msg(DBG_AUD,"read_audio: sbp_data: timeout waiting DRV_ATTN - retrying\n");
+                                        i=cc_DriveReset();  /* ugly fix to prevent a hang */
+                                        continue;
+                                }
+                        }
+                        do
+                        {
+                                if (fam0L_drive) cc_ReadStatus();
+                                i=ResponseStatus();  /* builds status_bits, returns orig. status (old) or faked p_success (new) */
+                                if (i<0) { msg(DBG_AUD,
+                                               "read_audio: cc_ReadStatus error after read: %02X\n",
+                                               current_drive->status_bits);
+                                           continue; /* FIXME */
+                                   }
+                        }
+                        while ((fam0L_drive)&&(!st_check)&&(!(i&p_success)));
+                        if (st_check)
+                        {
+                                i=cc_ReadError();
+                                msg(DBG_AUD,"read_audio: cc_ReadError was necessary after read: %02X\n",i);
+                                continue;
+                        }
+                        if (copy_to_user(read_audio.buf,
+                                         current_drive->aud_buf,
+                                         read_audio.nframes * CD_FRAMESIZE_RAW))
+                                RETURN_UP(-EFAULT);
+                        msg(DBG_AUD,"read_audio: copy_to_user done.\n");
+                        break;
+                }
+                cc_ModeSelect(CD_FRAMESIZE);
+                cc_ModeSense();
+                current_drive->mode=READ_M1;
+#if OLD_BUSY
+                busy_audio=0;
+#endif /* OLD_BUSY */
+                if (data_tries == 0)
+                {
+                        msg(DBG_AUD,"read_audio: failed after 5 tries in line %d.\n", __LINE__);
+                        RETURN_UP(-EIO);
+                }
+                msg(DBG_AUD,"read_audio: successful return.\n");
+                RETURN_UP(0);
+        } /* end of CDROMREADAUDIO */
+
+        default:
+                msg(DBG_IOC,"ioctl: unknown function request %04X\n", cmd);
+                RETURN_UP(-EINVAL);
+        } /* end switch(cmd) */
 }
 
 static int sbpcd_block_media_changed(struct gendisk *disk)
@@ -5478,10 +5477,9 @@ static struct cdrom_device_ops sbpcd_dops = {
         .get_mcn                = sbpcd_get_mcn,
         .reset                  = sbpcd_reset,
         .audio_ioctl            = sbpcd_audio_ioctl,
-        .dev_ioctl              = sbpcd_dev_ioctl,
         .capability             = CDC_CLOSE_TRAY | CDC_OPEN_TRAY | CDC_LOCK |
                                 CDC_MULTI_SESSION | CDC_MEDIA_CHANGED |
-                                CDC_MCN | CDC_PLAY_AUDIO | CDC_IOCTLS,
+                                CDC_MCN | CDC_PLAY_AUDIO,
         .n_minors               = 1,
 };
 
diff --git a/drivers/cdrom/viocd.c b/drivers/cdrom/viocd.c
index e27617259552..c0f817ba7adb 100644
--- a/drivers/cdrom/viocd.c
+++ b/drivers/cdrom/viocd.c
@@ -627,7 +627,7 @@ static struct cdrom_device_ops viocd_dops = {
         .media_changed = viocd_media_changed,
         .lock_door = viocd_lock_door,
         .generic_packet = viocd_packet,
-        .capability = CDC_CLOSE_TRAY | CDC_OPEN_TRAY | CDC_LOCK | CDC_SELECT_SPEED | CDC_SELECT_DISC | CDC_MULTI_SESSION | CDC_MCN | CDC_MEDIA_CHANGED | CDC_PLAY_AUDIO | CDC_RESET | CDC_IOCTLS | CDC_DRIVE_STATUS | CDC_GENERIC_PACKET | CDC_CD_R | CDC_CD_RW | CDC_DVD | CDC_DVD_R | CDC_DVD_RAM | CDC_RAM
+        .capability = CDC_CLOSE_TRAY | CDC_OPEN_TRAY | CDC_LOCK | CDC_SELECT_SPEED | CDC_SELECT_DISC | CDC_MULTI_SESSION | CDC_MCN | CDC_MEDIA_CHANGED | CDC_PLAY_AUDIO | CDC_RESET | CDC_DRIVE_STATUS | CDC_GENERIC_PACKET | CDC_CD_R | CDC_CD_RW | CDC_DVD | CDC_DVD_R | CDC_DVD_RAM | CDC_RAM
 };
 
 static int __init find_capability(const char *type)